You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/02/17 05:21:09 UTC
[GitHub] [james-project] chibenwa opened a new pull request #299: JAMES-3431 Fix various issues reported on DSN
chibenwa opened a new pull request #299:
URL: https://github.com/apache/james-project/pull/299
Otto, Karsten Andreas reported the following issues so far regarding DSN
```
1. When I send a mail to an unknown user, the DSN report (part 1) has no text after "Error message:". There is a comment in the mail MailDispatcher class that might explain it?
// In order for this server to meet the requirements of the SMTP
// specification, mails on the ERROR processor must be returned to
// the sender. Note that this email doesn't include any details
// regarding the details of the failure(s).
// In the future we may wish to address this.
Anyways, this is no big issue for us, as we can describe the problem in the <messageString>. But the empty text is confusing, I thought it to be a bug at first.
=> Please change the report generation to just hide the "Error message:" part if there is no error message to report.
2. I see a strange date format in the DSN report (part 2), e.g.
Last-Attempt-Date: Mon, 15 Feb 2021 15:45:20 XXXXX (CET)
According to rfc3464#section-2.3.7 this header must use the numeric timezone format (+hh:mm/-hh:mm). Does the XXXXX serve any special purpose?
=> Please fix this date format here to comply with the RFC.
3. We would also like to have the Arrival-Date (rfc3464#section-2.2.5) header in the DSN report (part 2) as well. In the past I found it a useful diagnostic in conjunction with Last-Attempt-Date, especially with delayed delivery cases. Does James per chance already record the timestamp on each incoming mail?
=> Please add the Arrival-Date header to the DSN report. Record the necessary timestamp on mail arrival if James does not have this data already.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on a change in pull request #299: JAMES-3431 Fix various issues reported on DSN
Posted by GitBox <gi...@apache.org>.
Arsnael commented on a change in pull request #299:
URL: https://github.com/apache/james-project/pull/299#discussion_r577386789
##########
File path: server/mailet/mailets/src/test/java/org/apache/james/transport/mailets/DSNBounceTest.java
##########
@@ -1276,6 +1279,50 @@ void envIdShouldBePositioned() throws Exception {
assertThat(IOUtils.toString(actualContent, StandardCharsets.UTF_8)).isEqualTo(expectedContent);
}
+ @Test
+ void ArrivalDateShouldBePositioned() throws Exception {
Review comment:
`arrivalDateShouldBePositioned`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa closed pull request #299: JAMES-3431 Fix various issues reported on DSN
Posted by GitBox <gi...@apache.org>.
chibenwa closed pull request #299:
URL: https://github.com/apache/james-project/pull/299
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #299: JAMES-3431 Fix various issues reported on DSN
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #299:
URL: https://github.com/apache/james-project/pull/299#issuecomment-783856935
Merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org