You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by alsorokin <gi...@git.apache.org> on 2015/05/22 09:22:06 UTC
[GitHub] cordova-mobile-spec pull request: CB-8843 Fixed mobilespec tests t...
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/130
CB-8843 Fixed mobilespec tests to pass on Android
https://issues.apache.org/jira/browse/CB-8843
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-mobile-spec CB-8843
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-mobile-spec/pull/130.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #130
----
commit 440468f9cc24000e8f74bcc76ade7da7ef174487
Author: alsorokin <al...@akvelon.com>
Date: 2015-05-22T07:19:03Z
CB-8843 Fixed mobilespec tests to pass on Android
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-8843 Fixed mobilespec tests t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/130
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-8843 Fixed mobilespec tests t...
Posted by alsorokin <gi...@git.apache.org>.
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/130#discussion_r30874137
--- Diff: cordova-plugin-mobilespec-tests/tests/whitelist.tests.js ---
@@ -202,7 +202,7 @@ exports.defineAutoTests = function () {
itShouldReject('http://www.apache.org.evil.com/');
itShouldAccept('file:///foo');
if (cordova.platformId == 'android')
- itShouldAccept('content:///foo');
+ itShouldReject('content:///foo');
--- End diff --
It has been changed in https://github.com/apache/cordova-mobile-spec/commit/b8401eb3c99573de6e6ae6af952f32d19bd2cd28#diff-e3ccd521f7df2ab57e6ee9133e737b36R205
I have asked the author of this change if this is intentional but received no reply.
I suppose that it was not intentional so I am reverting that change here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org