You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/06/16 07:00:41 UTC

[GitHub] [zeppelin] zjffdu opened a new pull request #4140: [ZEPPELIN-5413] Throw proper error message when user set execution.runtime-mode in flink sql

zjffdu opened a new pull request #4140:
URL: https://github.com/apache/zeppelin/pull/4140


   
   ### What is this PR for?
   
   `execution.runtime-mode` is available in flink sql-client, but it is not available in zeppelin flink interpreter. So we need to throw proper error message when user set execution.runtime-mode in flink sql. 
   
   ### What type of PR is it?
   [Improvement]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-5413
   
   ### How should this be tested?
   * Manually tested
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on pull request #4140: [ZEPPELIN-5413] Throw proper error message when user set execution.runtime-mode in flink sql

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4140:
URL: https://github.com/apache/zeppelin/pull/4140#issuecomment-865702746


   Will merge if no more comment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4140: [ZEPPELIN-5413] Throw proper error message when user set execution.runtime-mode in flink sql

Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #4140:
URL: https://github.com/apache/zeppelin/pull/4140#discussion_r654116082



##########
File path: flink/flink-scala-parent/src/main/java/org/apache/zeppelin/flink/FlinkSqlInterrpeter.java
##########
@@ -502,11 +502,17 @@ public void callSelect(String sql, InterpreterContext context) throws IOExceptio
 
   public abstract void callInnerSelect(String sql, InterpreterContext context) throws IOException;
 
-  public void callSet(String key, String value, InterpreterContext context) throws IOException {
+  public void callSet(String key, String value, InterpreterContext context) throws Exception {
+    if (key.equals("execution.runtime-mode")) {

Review comment:
       Fixed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] asfgit closed pull request #4140: [ZEPPELIN-5413] Throw proper error message when user set execution.runtime-mode in flink sql

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4140:
URL: https://github.com/apache/zeppelin/pull/4140


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org