[jira] [Commented] (HBASE-8938) Thrift2 does not close scanner instance

["Lars George (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-8938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13707011#comment-13707011 ] 

Lars George commented on HBASE-8938:
------------------------------------

Hey [~madani], since you are working on this, it looks like the current status for Thrift 1/2 is that it simply removes the reference for the scanner, but that is it. The rest is taken care of by the garbage collector (which I presume calls close() internally). 

You are saying that closing it explicitly is necessary? Do you have tested or debugged what the difference is?
                
> Thrift2 does not close scanner instance
> ---------------------------------------
>
>                 Key: HBASE-8938
>                 URL: https://issues.apache.org/jira/browse/HBASE-8938
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Thrift
>    Affects Versions: 0.94.0
>            Reporter: Hamed Madani
>              Labels: thrift2
>         Attachments: HBASE-8938-0.94.patch, HBASE-8938.patch
>
>
> closeScanner at *ThriftHBaseServiceHandler* simply remove scannerId from internal map, but fails to close the scanner instance. 
> {code}
>   public void closeScanner(int scannerId) throws TIOError, TIllegalArgument, TException {
>     if (removeScanner(scannerId) == null) {
>       TIllegalArgument ex = new TIllegalArgument();
>       ex.setMessage("Invalid scanner Id");
>       throw ex;
>     }
>   }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira