You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/01/10 17:29:41 UTC
[GitHub] vanzin commented on a change in pull request #9206: [SPARK-11235]
[network] Add ability to stream data using network lib.
vanzin commented on a change in pull request #9206: [SPARK-11235] [network] Add ability to stream data using network lib.
URL: https://github.com/apache/spark/pull/9206#discussion_r246852157
##########
File path: network/common/src/main/java/org/apache/spark/network/client/TransportResponseHandler.java
##########
@@ -50,6 +55,8 @@
private final Map<Long, RpcResponseCallback> outstandingRpcs;
+ private final Queue<StreamCallback> streamCallbacks;
Review comment:
The map is unnecessary, as explained. The queue is enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org