Re: [Patch] Network framework enhancement replaced by netty 3.2.5. (#11)

[Chen Qi <ka...@gmail.com>]

Hi Alex:

  I understand your comment, but I am sorry now I am in vacation, will back to work it in next Tuesday(6/5), so I think in next week, I can change the patch like your suggested, thanks!

--Kaka Chen

在 2012-5-31，上午6:34， Alex Huang 写道:

> I will take that.  My first comment is to introduce new NettyAgentManager implementations rather than changing the original one and then just change the DefaultComponentLibrary to point to the new NettyAgentManager.  That way we can make it official once we have more testing but still can fall back to the old one if there's problems.  I will review the rest of the changes.
> 
> --Alex
> 
>> -----Original Message-----
>> From: David Nalley [mailto:david@gnsa.us]
>> Sent: Wednesday, May 30, 2012 3:25 PM
>> To: cloudstack-dev@incubator.apache.org
>> Cc: Chiradeep Vittal; Alex Huang
>> Subject: Re: [Patch] Network framework enhancement replaced by netty
>> 3.2.5. (#11)
>> 
>> Chiradeep, Alex:
>> 
>> Would one of you mind taking a look at this patch and provide a review. It's a
>> pretty sizable change.
>> It's been sitting around without comment for almost two weeks.
>> 
>> --David
>> 
>> 
>> On Fri, May 18, 2012 at 1:01 AM, David Nalley <da...@gnsa.us> wrote:
>>> Sorry - this is the message that should have hit the list instead.
>>> 
>>> ---------- Forwarded message ----------
>>> From: kaka11chen
>>> <reply+i-4636031-f3de27e9db22119d589b87578d61f39cbff20c46-
>> 1129409@repl
>>> y.github.com>
>>> Date: Thu, May 17, 2012 at 11:10 PM
>>> Subject: [CloudStack] Network framework enhancement replaced by netty
>>> 3.2.5. (#11)
>>> To: hudsoncloudies <ke...@cloudstack.org>
>>> 
>>> 
>>> Our performance test for network framework in the cloudstack.
>>> http://cloudstack.org/forum/10-developer-and-api-support/10711-the-net
>>> work-communication-framework-of-cloudstack-may-be-a-problem.html
>>> 
>>> you can found utils sub-project the netty implements and performance
>>> test and other sub-projects are changed by this implements. Thanks!
>>> 
>>> author: kakachen email: kaka11.chen@gmail.com from zhejiang university
>>> 
>>> You can merge this Pull Request by running:
>>> 
>>>  git pull https://github.com/kaka11chen/CloudStack master
>>> 
>>> Or you can view, comment on it, or merge it online at:
>>> 
>>>  https://github.com/CloudStack/CloudStack/pull/11
>>> 
>>> -- Commit Summary --
>>> 
>>> * add netty support to utils
>>> * add netty-3.2.5 jar to deps
>>> * change to netty in agent
>>> * change to netty in server
>>> * add netty jar to package.xml
>>> * add netty jar to debian-deps.install
>>> * resolve compile problem
>>> * resolve compile problem
>>> 
>>> -- File Changes --
>>> 
>>> M agent/src/com/cloud/agent/Agent.java (119) M build/package.xml (1) M
>>> debian/cloud-deps.install (1) M deps/.classpath (1) M
>>> server/src/com/cloud/agent/VmmAgentShell.java (17) M
>>> server/src/com/cloud/agent/manager/AgentManagerImpl.java (38) M
>>> server/src/com/cloud/agent/manager/ClusteredAgentAttache.java (60) M
>>> server/src/com/cloud/agent/manager/ClusteredAgentManagerImpl.java
>>> (280) M
>> server/src/com/cloud/agent/manager/ConnectedAgentAttache.java
>>> (11) A utils/examples/cloud.keystore (0) A
>>> utils/examples/com/cloud/utils/netty/Client.java (58) A
>>> utils/examples/com/cloud/utils/netty/EchoClient.java (109) A
>>> utils/examples/com/cloud/utils/netty/EchoServer.java (76) A
>>> utils/examples/com/cloud/utils/netty/ThrTestUtils.java (18) A
>>> utils/examples/com/cloud/utils/nio/Client.java (59) A
>>> utils/examples/com/cloud/utils/nio/EchoClient.java (114) A
>>> utils/examples/com/cloud/utils/nio/EchoServer.java (89) A
>>> utils/examples/com/cloud/utils/nio/ThrTestUtils.java (19) A
>>> utils/src/com/cloud/utils/netty/ChannelHandler.java (103) A
>>> utils/src/com/cloud/utils/netty/DataConstants.java (47) A
>>> utils/src/com/cloud/utils/netty/FrameDecoder.java (176) A
>>> utils/src/com/cloud/utils/netty/FrameEncoder.java (49) A
>>> utils/src/com/cloud/utils/netty/HandlerFactory.java (5) A
>>> utils/src/com/cloud/utils/netty/Link.java (38) A
>>> utils/src/com/cloud/utils/netty/NettyClient.java (116) A
>>> utils/src/com/cloud/utils/netty/NettyServer.java (98) A
>>> utils/src/com/cloud/utils/netty/SslContextFactory.java (140) A
>>> utils/src/com/cloud/utils/netty/Task.java (83) A
>>> utils/src/com/cloud/utils/netty/TrustAllManager.java (26)
>>> 
>>> -- Patch Links --
>>> 
>>>  https://github.com/CloudStack/CloudStack/pull/11.patch
>>>  https://github.com/CloudStack/CloudStack/pull/11.diff
>>> 
>>> ---
>>> Reply to this email directly or view it on GitHub:
>>> https://github.com/CloudStack/CloudStack/pull/11