You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/07/21 08:05:20 UTC

[GitHub] [maven-shared-utils] roxspring commented on pull request #41: [MSHARED-860] deprecate PropertyUtils constructor and clean up docs

roxspring commented on pull request #41:
URL: https://github.com/apache/maven-shared-utils/pull/41#issuecomment-661703131


   > Question: Doesn't
   > 
   > ```
   > try ( InputStream in = is )
   > ```
   > 
   > end with closing the InputStream in (aka is)?
   
   This has already been discussed here:
   https://github.com/apache/maven-shared-utils/pull/41/files#r432415800
   
   In short: Yes it closes the `InputStream` but the original code did too and changing the behaviour would be bad.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org