You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "choo121600 (via GitHub)" <gi...@apache.org> on 2025/12/14 04:26:19 UTC
[PR] Feat e2e test for Dags pagination [airflow]
choo121600 opened a new pull request, #59400:
URL: https://github.com/apache/airflow/pull/59400
E2E test to verify pagination functionality on the Dags list page.
Add `dags-pagination.spec.ts` E2E test that verifies:
- Pagination buttons are visible
- Clicking next page & previous page
<img width="1314" height="1164" alt="image" src="https://github.com/user-attachments/assets/660975db-7139-4517-898d-20be8cf30a7a" />
closes: #59308
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat e2e test for Dags pagination [airflow]
Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on PR #59400:
URL: https://github.com/apache/airflow/pull/59400#issuecomment-3663471371
I think `dag-trigger.spec.ts` should also be moved to `dag-list.spec.ts`. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat e2e test for Dags pagination [airflow]
Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on PR #59400:
URL: https://github.com/apache/airflow/pull/59400#issuecomment-3663429649
CI failure that I don’t understand why👀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat e2e test for Dags pagination [airflow]
Posted by "vatsrahul1001 (via GitHub)" <gi...@apache.org>.
vatsrahul1001 commented on PR #59400:
URL: https://github.com/apache/airflow/pull/59400#issuecomment-3663486483
> CI failure that I don’t understand why👀
Was due to Sphinx. Fixed after merging https://github.com/apache/airflow/pull/59538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat e2e test for Dags pagination [airflow]
Posted by "vatsrahul1001 (via GitHub)" <gi...@apache.org>.
vatsrahul1001 merged PR #59400:
URL: https://github.com/apache/airflow/pull/59400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat e2e test for Dags pagination [airflow]
Posted by "vatsrahul1001 (via GitHub)" <gi...@apache.org>.
vatsrahul1001 commented on PR #59400:
URL: https://github.com/apache/airflow/pull/59400#issuecomment-3661938904
> LGTM
>
> Just one nit to make it easier for follow up PRs:
>
> Can we put that into a `airflow-core/src/airflow/ui/tests/e2e/specs/dags-list.spec.ts` file.
>
> Similarly to `https://github.com/apache/airflow/pull/59374` so all `daglist` related tests are in the same file.
Yeah agree with @pierrejeambrun all of test realted to dag list should be in a file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat e2e test for Dags pagination [airflow]
Posted by "vatsrahul1001 (via GitHub)" <gi...@apache.org>.
vatsrahul1001 commented on PR #59400:
URL: https://github.com/apache/airflow/pull/59400#issuecomment-3661936758
@choo121600 We noticed all of the UI e2e test skipped as `additional-prod-image-tests` skipped. I have fixed this in https://github.com/apache/airflow/pull/59523 and now rebase now tests should run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat e2e test for Dags pagination [airflow]
Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on PR #59400:
URL: https://github.com/apache/airflow/pull/59400#issuecomment-3663489936
> > I think `dag-trigger.spec.ts` should also be moved to `dag-list.spec.ts`. What do you think?
>
> Yes, should be in `dag-list.spec.ts`. Would you like to address that in separate PR?
Yes, once this PR is merged, I’ll move it in a separate PR ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat e2e test for Dags pagination [airflow]
Posted by "vatsrahul1001 (via GitHub)" <gi...@apache.org>.
vatsrahul1001 commented on PR #59400:
URL: https://github.com/apache/airflow/pull/59400#issuecomment-3661990785
Now all of the UI e2e tests ran fine.
<img width="1617" height="560" alt="image" src="https://github.com/user-attachments/assets/36984d60-a294-4571-8a57-5c907a03375c" />
@choo121600 we should be good to merge after put test to file `airflow-core/src/airflow/ui/tests/e2e/specs/dags-list.spec.ts`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat e2e test for Dags pagination [airflow]
Posted by "vatsrahul1001 (via GitHub)" <gi...@apache.org>.
vatsrahul1001 commented on PR #59400:
URL: https://github.com/apache/airflow/pull/59400#issuecomment-3663483644
> I think `dag-trigger.spec.ts` should also be moved to `dag-list.spec.ts`. What do you think?
Yes, should in to `dag-list.spec.ts`. Would you like to address that in seperate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org