You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/24 02:39:05 UTC
[GitHub] [flink] JingsongLi commented on a change in pull request #8212:
[FLINK-11519][table] Add function related catalog APIs
JingsongLi commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs
URL: https://github.com/apache/flink/pull/8212#discussion_r277937225
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ReadableWritableCatalog.java
##########
@@ -131,4 +133,47 @@ void createTable(ObjectPath tablePath, CatalogBaseTable table, boolean ignoreIfE
void alterTable(ObjectPath tableName, CatalogBaseTable newTable, boolean ignoreIfNotExists)
throws TableNotExistException, CatalogException;
+ // ------ functions ------
+
+ /**
+ * Create a function.
+ *
+ * @param functionPath Path of the function
+ * @param function The function to be created
Review comment:
Comments can be considered for alignment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services