[GitHub] [incubator-superset] nytai commented on a change in pull request #10746: refactor: convert DatasetList schema filter to use new distinct api

[GitBox <gi...@apache.org>]

nytai commented on a change in pull request #10746:
URL: https://github.com/apache/incubator-superset/pull/10746#discussion_r480511927



##########
File path: superset/views/base_api.py
##########
@@ -412,5 +412,9 @@ def distinct(self, column_name: str, **kwargs: Any) -> FlaskResponse:
         # Apply pagination
         result = self.datamodel.apply_pagination(query, page, page_size).all()
         # produce response
-        result = [{"text": item[0]} for item in result if item[0] is not None]
+        result = [
+            {"text": item[0], "value": item[0]}

Review comment:
       changed this to be compliant with the existing `/related` api




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org