[jira] [Comment Edited] (IGNITE-17899) Properly stop resources in TableManager

["Sergey Uttsel (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-17899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626585#comment-17626585 ] 

Sergey Uttsel edited comment on IGNITE-17899 at 11/14/22 8:32 AM:
------------------------------------------------------------------

MvTableStorage is implemented ManuallyCloseable now.
All components in TableManager#cleanUpTablesResources will be stopped even if one of these throws an exception during stopping.


was (Author: sergey uttsel):
MvTableStorage is implemented AutoCloseable now.
All components in TableManager#cleanUpTablesResources will be stopped even if one of these throws an exception during stopping.

> Properly stop resources in TableManager
> ---------------------------------------
>
>                 Key: IGNITE-17899
>                 URL: https://issues.apache.org/jira/browse/IGNITE-17899
>             Project: Ignite
>          Issue Type: Task
>            Reporter: Mirza Aliev
>            Assignee: Sergey Uttsel
>            Priority: Major
>              Labels: ignite-3
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> It's required to add sort of stopAll logic that will try to stop all resources even if some of them throws an exception on stop in {{org.apache.ignite.internal.table.distributed.TableManager#cleanUpTablesResources}}.  Currently, if some components throws exception during `TableManager` stop, other components won't be stopped.
> I'd rather use something similar to {{org.apache.ignite.internal.util.IgniteUtils#closeAll(java.util.Collection<? extends java.lang.AutoCloseable>)}}.
> Also `MvTableStorage` must be `AutoClosable`



--
This message was sent by Atlassian Jira
(v8.20.10#820010)