You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Damien Diederen <dd...@apache.org> on 2021/01/19 12:40:14 UTC

[VOTE] Apache ZooKeeper release 3.7.0 candidate 0

Dear all,

This is a first release candidate for ZooKeeper 3.7.0.

It introduces a number of new features, notably:

  * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
  
  * Quota enforcement (ZOOKEEPER-3301);
  
  * Host name canonicalization in quorum SASL authentication (ZOOKEEPER-4030);

  * Support for BCFKS key/trust store format (ZOOKEEPER-3950);

  * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);

  * A "whoami" API and CLI command (ZOOKEEPER-3969);

  * The possibility of disabling digest authentication (ZOOKEEPER-3979);
  
  * Multiple SASL "superUsers" (ZOOKEEPER-3959);
  
  * Fast-tracking of throttled requests (ZOOKEEPER-3683);
    
  * Additional security metrics (ZOOKEEPER-3978);

  * SASL support in the C and Perl clients (ZOOKEEPER-1112, ZOOKEEPER-3714);

  * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);

  * Notes on how to benchmark ZooKeeper with the YCSB tool (ZOOKEEPER-3264).

The release notes are available here:
  
  https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-0/website/releasenotes.html
  https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346617

*** Please download, test and vote by January 24th 2020, 23:59 UTC+0. ***

Source files:

  https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-0/

Maven staging repo:

  https://repository.apache.org/content/repositories/orgapachezookeeper-1065/

The release candidate tag in git to be voted upon: release-3.7.0-0

  https://github.com/apache/zookeeper/tree/release-3.7.0-0

ZooKeeper's KEYS file containing PGP keys we use to sign the release:

  https://www.apache.org/dist/zookeeper/KEYS

The staging version of the website is:

  https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-0/website/

Should we release this candidate?

Damien Diederen


Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 0

Posted by Enrico Olivelli <eo...@gmail.com>.
+1 (binding)
- checked checksums and signatures
- built from sources (MacOs + jdk8)
- C client tests executed using dev/docker/run.sh environment
- run smoke tests against the binaries (with JDK8 and JDK16-ea)
- tested ZooKeeperServerEmbedded, using staged maven repository

Thank you Damien !

Enrico

Il giorno mar 19 gen 2021 alle ore 13:40 Damien Diederen <
ddiederen@apache.org> ha scritto:

>
> Dear all,
>
> This is a first release candidate for ZooKeeper 3.7.0.
>
> It introduces a number of new features, notably:
>
>   * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
>
>   * Quota enforcement (ZOOKEEPER-3301);
>
>   * Host name canonicalization in quorum SASL authentication
> (ZOOKEEPER-4030);
>
>   * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
>
>   * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);
>
>   * A "whoami" API and CLI command (ZOOKEEPER-3969);
>
>   * The possibility of disabling digest authentication (ZOOKEEPER-3979);
>
>   * Multiple SASL "superUsers" (ZOOKEEPER-3959);
>
>   * Fast-tracking of throttled requests (ZOOKEEPER-3683);
>
>   * Additional security metrics (ZOOKEEPER-3978);
>
>   * SASL support in the C and Perl clients (ZOOKEEPER-1112,
> ZOOKEEPER-3714);
>
>   * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
>
>   * Notes on how to benchmark ZooKeeper with the YCSB tool
> (ZOOKEEPER-3264).
>
> The release notes are available here:
>
>
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-0/website/releasenotes.html
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346617
>
> *** Please download, test and vote by January 24th 2020, 23:59 UTC+0. ***
>
> Source files:
>
>   https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-0/
>
> Maven staging repo:
>
>
> https://repository.apache.org/content/repositories/orgapachezookeeper-1065/
>
> The release candidate tag in git to be voted upon: release-3.7.0-0
>
>   https://github.com/apache/zookeeper/tree/release-3.7.0-0
>
> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
>
>   https://www.apache.org/dist/zookeeper/KEYS
>
> The staging version of the website is:
>
>
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-0/website/
>
> Should we release this candidate?
>
> Damien Diederen
>
>

Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 1

Posted by Enrico Olivelli <eo...@gmail.com>.
I have not tested this RC yet, but for 3.7.0 I saw all tests passing on Mac.
I will test today and report by feedback

Enrico

Il giorno mer 27 gen 2021 alle ore 11:33 Norbert Kalmar
<nk...@cloudera.com.invalid> ha scritto:

> Hi all,
>
> My problem isn't that it's flaky (although that is a problem, a long
> standing one), but that it looks like it fails consistently on macOS, with
> the same error, on 2 different environments. (Anyone had success running
> tests on macOS? That would be a push for me to also +1 it)
> I'm not strongly -1 because of this, as tests run fine on linux systems,
> and it's our primary platform. Also, it builds and runs fine. So this is
> something we can perhaps fix for the upcoming 3.7.1, and just roll out
> 3.7.0 as is.
>
> Sorry for the many emails, here is a summary so far:
>
> Patrick Hunt +1 (binding)
> Máté Szalay-Bekő +0 (non-binding)
> Norbert Kalmar -1 (non-binding, and tentative)
>
> Thanks for putting together the release Damien, everything looks flawless
> on that part :)
>
> - Norbert
>
> On Tue, Jan 26, 2021 at 10:17 PM Damien Diederen <dd...@apache.org>
> wrote:
>
> >
> > Greetings, all,
> >
> > I have seen your reports, and am planning to dig into them ASAP.
> >
> > As Máté remarked, I have found tests with -Dsurefire-forkcount > 1 to be
> > quite unreliable as of late.  This is something I had been planning to
> > look into—but perhaps not at the same time as preparing this release :)
> >
> > FWIW, branch-3.7.0 "passed" on Jenkins:
> >
> >
> >
> https://ci-hadoop.apache.org/view/ZooKeeper/job/zookeeper-multi-branch-build/
> >
> > That was just luck, however; one can see that branch-3.7 has failed
> > despite holding the same contents.
> >
> > Best, -D
> >
> >
> >
> > Norbert Kalmar <nk...@cloudera.com.INVALID> writes:
> > > Sorry, the linked test is just an assertion error, no exception there.
> > > I had another test failure which had an error thrown. I will
> investigate
> > > further, as this might be some macOD address issue/collission yet
> again:
> > >
> > > [ERROR] Tests run: 10, Failures: 0, Errors: 1, Skipped: 0, Time
> elapsed:
> > > 26.229 s <<< FAILURE! - in
> > org.apache.zookeeper.server.quorum.CnxManagerTest
> > > [ERROR] testCnxManagerListenerThreadConfigurableRetry  Time elapsed:
> > 0.178
> > > s  <<< ERROR!
> > > java.net.BindException: Address already in use
> > > at sun.nio.ch.Net.bind0(Native Method)
> > > at
> > >
> >
> org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:662)
> > > at
> > >
> >
> org.apache.zookeeper.server.ServerCnxnFactory.configure(ServerCnxnFactory.java:109)
> > > at
> > >
> >
> org.apache.zookeeper.server.ServerCnxnFactory.createFactory(ServerCnxnFactory.java:191)
> > > at
> > >
> >
> org.apache.zookeeper.server.ServerCnxnFactory.createFactory(ServerCnxnFactory.java:186)
> > > at
> > >
> >
> org.apache.zookeeper.server.quorum.QuorumPeer.<init>(QuorumPeer.java:1253)
> > > at
> > >
> >
> org.apache.zookeeper.server.quorum.CnxManagerTest.testCnxManagerListenerThreadConfigurableRetry(CnxManagerTest.java:309)
> > >
> > >
> > >
> > > On Mon, Jan 25, 2021 at 5:20 PM Norbert Kalmar <nk...@cloudera.com>
> > wrote:
> > >
> > >> -1 (non-binding!)
> > >>
> > >> - built the source, run locally, gave a few basic commands
> > >> - run tests on macOS 10.13.6, openjdk 1.8.0_242 - issues found, see
> > below
> > >> - checked files in tarball
> > >> - checked signatures
> > >>
> > >> I had the same problem as Máté. unit tests did not pass on MacOS.
> > Nothing
> > >> has changed in my environment since I did the 3.5.9 release, and it
> had
> > no
> > >> issue back then.
> > >>
> > >> I gave a -1 because this error doesn't only occur to me.
> > >>
> > >> The test that failed:
> > >>
> > >> [ERROR] Tests run: 7, Failures: 1, Errors: 0, Skipped: 1, Time
> elapsed:
> > >> 62.332 s <<< FAILURE! - in
> > >> org.apache.zookeeper.server.util.RequestPathMetricsCollectorTest
> > >>
> > >> [ERROR] testMultiThreadPerf  Time elapsed: 4.816 s  <<< FAILURE!
> > >>
> > >> org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
> > >>
> > >> at
> > >>
> >
> org.apache.zookeeper.server.util.RequestPathMetricsCollectorTest.testMultiThreadPerf(RequestPathMetricsCollectorTest.java:448)
> > >>
> > >>
> > >>
> > >> - Norbert
> > >>
> > >>
> > >>
> > >> On Mon, Jan 25, 2021 at 1:39 PM Szalay-Bekő Máté <
> > >> szalay.beko.mate@gmail.com> wrote:
> > >>
> > >>> +0 (and not even binding :) )
> > >>>
> > >>> - I built the source code (-Pfull-build) on Ubuntu 18.04.3 using
> > OpenJDK
> > >>> 8u265 and maven 3.6.3.
> > >>> - I also built and executed unit tests for zkpython
> > >>> - the unit tests passed for the C-client and for python client
> > >>> - checkstyle and spotbugs passed
> > >>> - apache-rat passed
> > >>> - owasp (CVE check) passed
> > >>> - fatjar built (-Pfatjar)
> > >>> - I executed a quick rolling-upgrade test from 3.5.9 and from 3.6.2.
> > >>> (using
> > >>> https://github.com/symat/zk-rolling-upgrade-test)
> > >>>
> > >>> for some reason the java unit tests failed for me.
> > >>>
> > >>> On mac (jdk 1.8.212 and maven 3.6.3), I got all the unit tests
> executed
> > >>> successfully, but then the maven job still failed for hbase-server
> test
> > >>> with error message (with -DforkCount=4 and even with -DforkCount=1)
> > like:
> > >>> -------------
> > >>> [ERROR] ExecutionException There was an error in the forked process
> > >>> [ERROR] unable to create new native thread
> > >>> [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException:
> > >>> ExecutionException There was an error in the forked process
> > >>> [ERROR] unable to create new native thread
> > >>> [ERROR] at
> > >>>
> > >>>
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:510)
> > >>> -------------
> > >>>
> > >>>
> > >>> Then I tried on a dockerized environment (ubuntu 18.4, OpenJDK 8u265
> > and
> > >>> maven 3.6.3) and I got other kinds of strange maven errors:
> > >>> -------------------
> > >>> [ERROR] Caused by:
> > >>> org.apache.maven.surefire.booter.SurefireBooterForkException: The
> > forked
> > >>> VM
> > >>> terminated without properly saying goodbye. VM crash or System.exit
> > >>> called?
> > >>> [ERROR] Command was /bin/sh -c cd
> > >>> /tmp/zk/apache-zookeeper-3.7.0/zookeeper-server &&
> > >>> /home/symat/.sdkman/candidates/java/8.0.265-open/jre/bin/java
> -Xmx512m
> > >>> -Dtest.junit.threads=8 -Dzookeeper.junit.threadid=3
> > >>>
> > >>>
> >
> -javaagent:/home/symat/.m2/repository/org/jmockit/jmockit/1.48/jmockit-1.48.jar
> > >>> -jar
> > >>>
> > >>>
> >
> /tmp/zk/apache-zookeeper-3.7.0/zookeeper-server/target/surefire/surefirebooter8828313385463488429.jar
> > >>> /tmp/zk/apache-zookeeper-3.7.0/zookeeper-server/target/surefire
> > >>> 2021-01-25T11-54-03_621-jvmRun3 surefire4024538135165099286tmp
> > >>> surefire_37800399112966511000tmp
> > >>> [ERROR] Process Exit Code: 0
> > >>> [ERROR]         at
> > >>>
> > >>>
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:669)
> > >>> [ERROR]         at
> > >>>
> > >>>
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.access$600(ForkStarter.java:115)
> > >>> [ERROR]         at
> > >>>
> > >>>
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter$2.call(ForkStarter.java:444)
> > >>> [ERROR]         at
> > >>>
> > >>>
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter$2.call(ForkStarter.java:420)
> > >>> [ERROR]         at
> > >>> java.util.concurrent.FutureTask.run(FutureTask.java:266)
> > >>> [ERROR]         at
> > >>>
> > >>>
> >
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> > >>> [ERROR]         at
> > >>>
> > >>>
> >
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> > >>> [ERROR]         at java.lang.Thread.run(Thread.java:748)
> > >>> [ERROR]
> > >>> --------------------------------------
> > >>>
> > >>>
> > >>> These issues might be very well specific to my local (mac or docker
> on
> > >>> mac)
> > >>> environments. This is why I didn't vote with -1
> > >>> Can someone else run the java unit tests successfully locally?
> > >>>
> > >>> I also tried to check if the CI was green for the last PR on 3.7.0 (
> > >>> https://github.com/apache/zookeeper/pull/1586/checks), but it looks
> > the
> > >>> CI
> > >>> haven't even started to execute the tests, due to errors in the
> > "install C
> > >>> dependencies" step.
> > >>>
> > >>> Regards,
> > >>> Mate
> > >>>
> > >>> On Sun, Jan 24, 2021 at 11:39 PM Patrick Hunt <ph...@apache.org>
> > wrote:
> > >>>
> > >>> > +1. xsum/sig verified. rat ran clean. built and dependency checks
> are
> > >>> fine.
> > >>> > Tried running some manual clusters and it was successful.
> > >>> >
> > >>> > Regards,
> > >>> >
> > >>> > Patrick
> > >>> >
> > >>> >
> > >>> > On Sun, Jan 24, 2021 at 12:11 PM Damien Diederen <
> > ddiederen@apache.org>
> > >>> > wrote:
> > >>> >
> > >>> > >
> > >>> > > Dear all,
> > >>> > >
> > >>> > > This is a second release candidate for ZooKeeper 3.7.0.  Compared
> > to
> > >>> > > RC0, it fixes a tarball generation issue, includes a description
> of
> > >>> the
> > >>> > > 'whoami' CLI command, and incorporates a contribution to
> > ZooInspector.
> > >>> > >
> > >>> > > ZooKeeper 3.7.0 introduces a number of new features, notably:
> > >>> > >
> > >>> > >   * An API to start a ZooKeeper server from Java
> (ZOOKEEPER-3874);
> > >>> > >
> > >>> > >   * Quota enforcement (ZOOKEEPER-3301);
> > >>> > >
> > >>> > >   * Host name canonicalization in quorum SASL authentication
> > >>> > > (ZOOKEEPER-4030);
> > >>> > >
> > >>> > >   * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
> > >>> > >
> > >>> > >   * A choice of mandatory authentication scheme(s)
> > (ZOOKEEPER-3561);
> > >>> > >
> > >>> > >   * A "whoami" API and CLI command (ZOOKEEPER-3969);
> > >>> > >
> > >>> > >   * The possibility of disabling digest authentication
> > >>> (ZOOKEEPER-3979);
> > >>> > >
> > >>> > >   * Multiple SASL "superUsers" (ZOOKEEPER-3959);
> > >>> > >
> > >>> > >   * Fast-tracking of throttled requests (ZOOKEEPER-3683);
> > >>> > >
> > >>> > >   * Additional security metrics (ZOOKEEPER-3978);
> > >>> > >
> > >>> > >   * SASL support in the C and Perl clients (ZOOKEEPER-1112,
> > >>> > > ZOOKEEPER-3714);
> > >>> > >
> > >>> > >   * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
> > >>> > >
> > >>> > >   * Notes on how to benchmark ZooKeeper with the YCSB tool
> > >>> > > (ZOOKEEPER-3264).
> > >>> > >
> > >>> > > The release notes are available here:
> > >>> > >
> > >>> > >
> > >>> > >
> > >>> >
> > >>>
> >
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/website/releasenotes.html
> > >>> > >
> > >>> > >
> > >>> >
> > >>>
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346617
> > >>> > >
> > >>> > > *** Please download, test and vote by January 31st 2020, 23:59
> > UTC+0.
> > >>> ***
> > >>> > >
> > >>> > > Source files:
> > >>> > >
> > >>> > >
> > https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/
> > >>> > >
> > >>> > > Maven staging repo:
> > >>> > >
> > >>> > >
> > >>> > >
> > >>> >
> > >>>
> >
> https://repository.apache.org/content/repositories/orgapachezookeeper-1066/
> > >>> > >
> > >>> > > The release candidate tag in git to be voted upon:
> release-3.7.0-1
> > >>> > >
> > >>> > >   https://github.com/apache/zookeeper/tree/release-3.7.0-1
> > >>> > >
> > >>> > > ZooKeeper's KEYS file containing PGP keys we use to sign the
> > release:
> > >>> > >
> > >>> > >   https://www.apache.org/dist/zookeeper/KEYS
> > >>> > >
> > >>> > > The staging version of the website is:
> > >>> > >
> > >>> > >
> > >>> > >
> > >>> >
> > >>>
> >
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/website/
> > >>> > >
> > >>> > > Should we release this candidate?
> > >>> > >
> > >>> > > Damien Diederen
> > >>> > >
> > >>> >
> > >>>
> > >>
> >
>

Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 1

Posted by Norbert Kalmar <nk...@cloudera.com.INVALID>.
Hi all,

My problem isn't that it's flaky (although that is a problem, a long
standing one), but that it looks like it fails consistently on macOS, with
the same error, on 2 different environments. (Anyone had success running
tests on macOS? That would be a push for me to also +1 it)
I'm not strongly -1 because of this, as tests run fine on linux systems,
and it's our primary platform. Also, it builds and runs fine. So this is
something we can perhaps fix for the upcoming 3.7.1, and just roll out
3.7.0 as is.

Sorry for the many emails, here is a summary so far:

Patrick Hunt +1 (binding)
Máté Szalay-Bekő +0 (non-binding)
Norbert Kalmar -1 (non-binding, and tentative)

Thanks for putting together the release Damien, everything looks flawless
on that part :)

- Norbert

On Tue, Jan 26, 2021 at 10:17 PM Damien Diederen <dd...@apache.org>
wrote:

>
> Greetings, all,
>
> I have seen your reports, and am planning to dig into them ASAP.
>
> As Máté remarked, I have found tests with -Dsurefire-forkcount > 1 to be
> quite unreliable as of late.  This is something I had been planning to
> look into—but perhaps not at the same time as preparing this release :)
>
> FWIW, branch-3.7.0 "passed" on Jenkins:
>
>
> https://ci-hadoop.apache.org/view/ZooKeeper/job/zookeeper-multi-branch-build/
>
> That was just luck, however; one can see that branch-3.7 has failed
> despite holding the same contents.
>
> Best, -D
>
>
>
> Norbert Kalmar <nk...@cloudera.com.INVALID> writes:
> > Sorry, the linked test is just an assertion error, no exception there.
> > I had another test failure which had an error thrown. I will investigate
> > further, as this might be some macOD address issue/collission yet again:
> >
> > [ERROR] Tests run: 10, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> > 26.229 s <<< FAILURE! - in
> org.apache.zookeeper.server.quorum.CnxManagerTest
> > [ERROR] testCnxManagerListenerThreadConfigurableRetry  Time elapsed:
> 0.178
> > s  <<< ERROR!
> > java.net.BindException: Address already in use
> > at sun.nio.ch.Net.bind0(Native Method)
> > at
> >
> org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:662)
> > at
> >
> org.apache.zookeeper.server.ServerCnxnFactory.configure(ServerCnxnFactory.java:109)
> > at
> >
> org.apache.zookeeper.server.ServerCnxnFactory.createFactory(ServerCnxnFactory.java:191)
> > at
> >
> org.apache.zookeeper.server.ServerCnxnFactory.createFactory(ServerCnxnFactory.java:186)
> > at
> >
> org.apache.zookeeper.server.quorum.QuorumPeer.<init>(QuorumPeer.java:1253)
> > at
> >
> org.apache.zookeeper.server.quorum.CnxManagerTest.testCnxManagerListenerThreadConfigurableRetry(CnxManagerTest.java:309)
> >
> >
> >
> > On Mon, Jan 25, 2021 at 5:20 PM Norbert Kalmar <nk...@cloudera.com>
> wrote:
> >
> >> -1 (non-binding!)
> >>
> >> - built the source, run locally, gave a few basic commands
> >> - run tests on macOS 10.13.6, openjdk 1.8.0_242 - issues found, see
> below
> >> - checked files in tarball
> >> - checked signatures
> >>
> >> I had the same problem as Máté. unit tests did not pass on MacOS.
> Nothing
> >> has changed in my environment since I did the 3.5.9 release, and it had
> no
> >> issue back then.
> >>
> >> I gave a -1 because this error doesn't only occur to me.
> >>
> >> The test that failed:
> >>
> >> [ERROR] Tests run: 7, Failures: 1, Errors: 0, Skipped: 1, Time elapsed:
> >> 62.332 s <<< FAILURE! - in
> >> org.apache.zookeeper.server.util.RequestPathMetricsCollectorTest
> >>
> >> [ERROR] testMultiThreadPerf  Time elapsed: 4.816 s  <<< FAILURE!
> >>
> >> org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
> >>
> >> at
> >>
> org.apache.zookeeper.server.util.RequestPathMetricsCollectorTest.testMultiThreadPerf(RequestPathMetricsCollectorTest.java:448)
> >>
> >>
> >>
> >> - Norbert
> >>
> >>
> >>
> >> On Mon, Jan 25, 2021 at 1:39 PM Szalay-Bekő Máté <
> >> szalay.beko.mate@gmail.com> wrote:
> >>
> >>> +0 (and not even binding :) )
> >>>
> >>> - I built the source code (-Pfull-build) on Ubuntu 18.04.3 using
> OpenJDK
> >>> 8u265 and maven 3.6.3.
> >>> - I also built and executed unit tests for zkpython
> >>> - the unit tests passed for the C-client and for python client
> >>> - checkstyle and spotbugs passed
> >>> - apache-rat passed
> >>> - owasp (CVE check) passed
> >>> - fatjar built (-Pfatjar)
> >>> - I executed a quick rolling-upgrade test from 3.5.9 and from 3.6.2.
> >>> (using
> >>> https://github.com/symat/zk-rolling-upgrade-test)
> >>>
> >>> for some reason the java unit tests failed for me.
> >>>
> >>> On mac (jdk 1.8.212 and maven 3.6.3), I got all the unit tests executed
> >>> successfully, but then the maven job still failed for hbase-server test
> >>> with error message (with -DforkCount=4 and even with -DforkCount=1)
> like:
> >>> -------------
> >>> [ERROR] ExecutionException There was an error in the forked process
> >>> [ERROR] unable to create new native thread
> >>> [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException:
> >>> ExecutionException There was an error in the forked process
> >>> [ERROR] unable to create new native thread
> >>> [ERROR] at
> >>>
> >>>
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:510)
> >>> -------------
> >>>
> >>>
> >>> Then I tried on a dockerized environment (ubuntu 18.4, OpenJDK 8u265
> and
> >>> maven 3.6.3) and I got other kinds of strange maven errors:
> >>> -------------------
> >>> [ERROR] Caused by:
> >>> org.apache.maven.surefire.booter.SurefireBooterForkException: The
> forked
> >>> VM
> >>> terminated without properly saying goodbye. VM crash or System.exit
> >>> called?
> >>> [ERROR] Command was /bin/sh -c cd
> >>> /tmp/zk/apache-zookeeper-3.7.0/zookeeper-server &&
> >>> /home/symat/.sdkman/candidates/java/8.0.265-open/jre/bin/java -Xmx512m
> >>> -Dtest.junit.threads=8 -Dzookeeper.junit.threadid=3
> >>>
> >>>
> -javaagent:/home/symat/.m2/repository/org/jmockit/jmockit/1.48/jmockit-1.48.jar
> >>> -jar
> >>>
> >>>
> /tmp/zk/apache-zookeeper-3.7.0/zookeeper-server/target/surefire/surefirebooter8828313385463488429.jar
> >>> /tmp/zk/apache-zookeeper-3.7.0/zookeeper-server/target/surefire
> >>> 2021-01-25T11-54-03_621-jvmRun3 surefire4024538135165099286tmp
> >>> surefire_37800399112966511000tmp
> >>> [ERROR] Process Exit Code: 0
> >>> [ERROR]         at
> >>>
> >>>
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:669)
> >>> [ERROR]         at
> >>>
> >>>
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.access$600(ForkStarter.java:115)
> >>> [ERROR]         at
> >>>
> >>>
> org.apache.maven.plugin.surefire.booterclient.ForkStarter$2.call(ForkStarter.java:444)
> >>> [ERROR]         at
> >>>
> >>>
> org.apache.maven.plugin.surefire.booterclient.ForkStarter$2.call(ForkStarter.java:420)
> >>> [ERROR]         at
> >>> java.util.concurrent.FutureTask.run(FutureTask.java:266)
> >>> [ERROR]         at
> >>>
> >>>
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> >>> [ERROR]         at
> >>>
> >>>
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> >>> [ERROR]         at java.lang.Thread.run(Thread.java:748)
> >>> [ERROR]
> >>> --------------------------------------
> >>>
> >>>
> >>> These issues might be very well specific to my local (mac or docker on
> >>> mac)
> >>> environments. This is why I didn't vote with -1
> >>> Can someone else run the java unit tests successfully locally?
> >>>
> >>> I also tried to check if the CI was green for the last PR on 3.7.0 (
> >>> https://github.com/apache/zookeeper/pull/1586/checks), but it looks
> the
> >>> CI
> >>> haven't even started to execute the tests, due to errors in the
> "install C
> >>> dependencies" step.
> >>>
> >>> Regards,
> >>> Mate
> >>>
> >>> On Sun, Jan 24, 2021 at 11:39 PM Patrick Hunt <ph...@apache.org>
> wrote:
> >>>
> >>> > +1. xsum/sig verified. rat ran clean. built and dependency checks are
> >>> fine.
> >>> > Tried running some manual clusters and it was successful.
> >>> >
> >>> > Regards,
> >>> >
> >>> > Patrick
> >>> >
> >>> >
> >>> > On Sun, Jan 24, 2021 at 12:11 PM Damien Diederen <
> ddiederen@apache.org>
> >>> > wrote:
> >>> >
> >>> > >
> >>> > > Dear all,
> >>> > >
> >>> > > This is a second release candidate for ZooKeeper 3.7.0.  Compared
> to
> >>> > > RC0, it fixes a tarball generation issue, includes a description of
> >>> the
> >>> > > 'whoami' CLI command, and incorporates a contribution to
> ZooInspector.
> >>> > >
> >>> > > ZooKeeper 3.7.0 introduces a number of new features, notably:
> >>> > >
> >>> > >   * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
> >>> > >
> >>> > >   * Quota enforcement (ZOOKEEPER-3301);
> >>> > >
> >>> > >   * Host name canonicalization in quorum SASL authentication
> >>> > > (ZOOKEEPER-4030);
> >>> > >
> >>> > >   * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
> >>> > >
> >>> > >   * A choice of mandatory authentication scheme(s)
> (ZOOKEEPER-3561);
> >>> > >
> >>> > >   * A "whoami" API and CLI command (ZOOKEEPER-3969);
> >>> > >
> >>> > >   * The possibility of disabling digest authentication
> >>> (ZOOKEEPER-3979);
> >>> > >
> >>> > >   * Multiple SASL "superUsers" (ZOOKEEPER-3959);
> >>> > >
> >>> > >   * Fast-tracking of throttled requests (ZOOKEEPER-3683);
> >>> > >
> >>> > >   * Additional security metrics (ZOOKEEPER-3978);
> >>> > >
> >>> > >   * SASL support in the C and Perl clients (ZOOKEEPER-1112,
> >>> > > ZOOKEEPER-3714);
> >>> > >
> >>> > >   * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
> >>> > >
> >>> > >   * Notes on how to benchmark ZooKeeper with the YCSB tool
> >>> > > (ZOOKEEPER-3264).
> >>> > >
> >>> > > The release notes are available here:
> >>> > >
> >>> > >
> >>> > >
> >>> >
> >>>
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/website/releasenotes.html
> >>> > >
> >>> > >
> >>> >
> >>>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346617
> >>> > >
> >>> > > *** Please download, test and vote by January 31st 2020, 23:59
> UTC+0.
> >>> ***
> >>> > >
> >>> > > Source files:
> >>> > >
> >>> > >
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/
> >>> > >
> >>> > > Maven staging repo:
> >>> > >
> >>> > >
> >>> > >
> >>> >
> >>>
> https://repository.apache.org/content/repositories/orgapachezookeeper-1066/
> >>> > >
> >>> > > The release candidate tag in git to be voted upon: release-3.7.0-1
> >>> > >
> >>> > >   https://github.com/apache/zookeeper/tree/release-3.7.0-1
> >>> > >
> >>> > > ZooKeeper's KEYS file containing PGP keys we use to sign the
> release:
> >>> > >
> >>> > >   https://www.apache.org/dist/zookeeper/KEYS
> >>> > >
> >>> > > The staging version of the website is:
> >>> > >
> >>> > >
> >>> > >
> >>> >
> >>>
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/website/
> >>> > >
> >>> > > Should we release this candidate?
> >>> > >
> >>> > > Damien Diederen
> >>> > >
> >>> >
> >>>
> >>
>

Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 1

Posted by Damien Diederen <dd...@apache.org>.
Greetings, all,

I have seen your reports, and am planning to dig into them ASAP.

As Máté remarked, I have found tests with -Dsurefire-forkcount > 1 to be
quite unreliable as of late.  This is something I had been planning to
look into—but perhaps not at the same time as preparing this release :)

FWIW, branch-3.7.0 "passed" on Jenkins:

  https://ci-hadoop.apache.org/view/ZooKeeper/job/zookeeper-multi-branch-build/

That was just luck, however; one can see that branch-3.7 has failed
despite holding the same contents.

Best, -D



Norbert Kalmar <nk...@cloudera.com.INVALID> writes:
> Sorry, the linked test is just an assertion error, no exception there.
> I had another test failure which had an error thrown. I will investigate
> further, as this might be some macOD address issue/collission yet again:
>
> [ERROR] Tests run: 10, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 26.229 s <<< FAILURE! - in org.apache.zookeeper.server.quorum.CnxManagerTest
> [ERROR] testCnxManagerListenerThreadConfigurableRetry  Time elapsed: 0.178
> s  <<< ERROR!
> java.net.BindException: Address already in use
> at sun.nio.ch.Net.bind0(Native Method)
> at
> org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:662)
> at
> org.apache.zookeeper.server.ServerCnxnFactory.configure(ServerCnxnFactory.java:109)
> at
> org.apache.zookeeper.server.ServerCnxnFactory.createFactory(ServerCnxnFactory.java:191)
> at
> org.apache.zookeeper.server.ServerCnxnFactory.createFactory(ServerCnxnFactory.java:186)
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.<init>(QuorumPeer.java:1253)
> at
> org.apache.zookeeper.server.quorum.CnxManagerTest.testCnxManagerListenerThreadConfigurableRetry(CnxManagerTest.java:309)
>
>
>
> On Mon, Jan 25, 2021 at 5:20 PM Norbert Kalmar <nk...@cloudera.com> wrote:
>
>> -1 (non-binding!)
>>
>> - built the source, run locally, gave a few basic commands
>> - run tests on macOS 10.13.6, openjdk 1.8.0_242 - issues found, see below
>> - checked files in tarball
>> - checked signatures
>>
>> I had the same problem as Máté. unit tests did not pass on MacOS. Nothing
>> has changed in my environment since I did the 3.5.9 release, and it had no
>> issue back then.
>>
>> I gave a -1 because this error doesn't only occur to me.
>>
>> The test that failed:
>>
>> [ERROR] Tests run: 7, Failures: 1, Errors: 0, Skipped: 1, Time elapsed:
>> 62.332 s <<< FAILURE! - in
>> org.apache.zookeeper.server.util.RequestPathMetricsCollectorTest
>>
>> [ERROR] testMultiThreadPerf  Time elapsed: 4.816 s  <<< FAILURE!
>>
>> org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
>>
>> at
>> org.apache.zookeeper.server.util.RequestPathMetricsCollectorTest.testMultiThreadPerf(RequestPathMetricsCollectorTest.java:448)
>>
>>
>>
>> - Norbert
>>
>>
>>
>> On Mon, Jan 25, 2021 at 1:39 PM Szalay-Bekő Máté <
>> szalay.beko.mate@gmail.com> wrote:
>>
>>> +0 (and not even binding :) )
>>>
>>> - I built the source code (-Pfull-build) on Ubuntu 18.04.3 using OpenJDK
>>> 8u265 and maven 3.6.3.
>>> - I also built and executed unit tests for zkpython
>>> - the unit tests passed for the C-client and for python client
>>> - checkstyle and spotbugs passed
>>> - apache-rat passed
>>> - owasp (CVE check) passed
>>> - fatjar built (-Pfatjar)
>>> - I executed a quick rolling-upgrade test from 3.5.9 and from 3.6.2.
>>> (using
>>> https://github.com/symat/zk-rolling-upgrade-test)
>>>
>>> for some reason the java unit tests failed for me.
>>>
>>> On mac (jdk 1.8.212 and maven 3.6.3), I got all the unit tests executed
>>> successfully, but then the maven job still failed for hbase-server test
>>> with error message (with -DforkCount=4 and even with -DforkCount=1) like:
>>> -------------
>>> [ERROR] ExecutionException There was an error in the forked process
>>> [ERROR] unable to create new native thread
>>> [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException:
>>> ExecutionException There was an error in the forked process
>>> [ERROR] unable to create new native thread
>>> [ERROR] at
>>>
>>> org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:510)
>>> -------------
>>>
>>>
>>> Then I tried on a dockerized environment (ubuntu 18.4, OpenJDK 8u265 and
>>> maven 3.6.3) and I got other kinds of strange maven errors:
>>> -------------------
>>> [ERROR] Caused by:
>>> org.apache.maven.surefire.booter.SurefireBooterForkException: The forked
>>> VM
>>> terminated without properly saying goodbye. VM crash or System.exit
>>> called?
>>> [ERROR] Command was /bin/sh -c cd
>>> /tmp/zk/apache-zookeeper-3.7.0/zookeeper-server &&
>>> /home/symat/.sdkman/candidates/java/8.0.265-open/jre/bin/java -Xmx512m
>>> -Dtest.junit.threads=8 -Dzookeeper.junit.threadid=3
>>>
>>> -javaagent:/home/symat/.m2/repository/org/jmockit/jmockit/1.48/jmockit-1.48.jar
>>> -jar
>>>
>>> /tmp/zk/apache-zookeeper-3.7.0/zookeeper-server/target/surefire/surefirebooter8828313385463488429.jar
>>> /tmp/zk/apache-zookeeper-3.7.0/zookeeper-server/target/surefire
>>> 2021-01-25T11-54-03_621-jvmRun3 surefire4024538135165099286tmp
>>> surefire_37800399112966511000tmp
>>> [ERROR] Process Exit Code: 0
>>> [ERROR]         at
>>>
>>> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:669)
>>> [ERROR]         at
>>>
>>> org.apache.maven.plugin.surefire.booterclient.ForkStarter.access$600(ForkStarter.java:115)
>>> [ERROR]         at
>>>
>>> org.apache.maven.plugin.surefire.booterclient.ForkStarter$2.call(ForkStarter.java:444)
>>> [ERROR]         at
>>>
>>> org.apache.maven.plugin.surefire.booterclient.ForkStarter$2.call(ForkStarter.java:420)
>>> [ERROR]         at
>>> java.util.concurrent.FutureTask.run(FutureTask.java:266)
>>> [ERROR]         at
>>>
>>> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>>> [ERROR]         at
>>>
>>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>>> [ERROR]         at java.lang.Thread.run(Thread.java:748)
>>> [ERROR]
>>> --------------------------------------
>>>
>>>
>>> These issues might be very well specific to my local (mac or docker on
>>> mac)
>>> environments. This is why I didn't vote with -1
>>> Can someone else run the java unit tests successfully locally?
>>>
>>> I also tried to check if the CI was green for the last PR on 3.7.0 (
>>> https://github.com/apache/zookeeper/pull/1586/checks), but it looks the
>>> CI
>>> haven't even started to execute the tests, due to errors in the "install C
>>> dependencies" step.
>>>
>>> Regards,
>>> Mate
>>>
>>> On Sun, Jan 24, 2021 at 11:39 PM Patrick Hunt <ph...@apache.org> wrote:
>>>
>>> > +1. xsum/sig verified. rat ran clean. built and dependency checks are
>>> fine.
>>> > Tried running some manual clusters and it was successful.
>>> >
>>> > Regards,
>>> >
>>> > Patrick
>>> >
>>> >
>>> > On Sun, Jan 24, 2021 at 12:11 PM Damien Diederen <dd...@apache.org>
>>> > wrote:
>>> >
>>> > >
>>> > > Dear all,
>>> > >
>>> > > This is a second release candidate for ZooKeeper 3.7.0.  Compared to
>>> > > RC0, it fixes a tarball generation issue, includes a description of
>>> the
>>> > > 'whoami' CLI command, and incorporates a contribution to ZooInspector.
>>> > >
>>> > > ZooKeeper 3.7.0 introduces a number of new features, notably:
>>> > >
>>> > >   * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
>>> > >
>>> > >   * Quota enforcement (ZOOKEEPER-3301);
>>> > >
>>> > >   * Host name canonicalization in quorum SASL authentication
>>> > > (ZOOKEEPER-4030);
>>> > >
>>> > >   * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
>>> > >
>>> > >   * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);
>>> > >
>>> > >   * A "whoami" API and CLI command (ZOOKEEPER-3969);
>>> > >
>>> > >   * The possibility of disabling digest authentication
>>> (ZOOKEEPER-3979);
>>> > >
>>> > >   * Multiple SASL "superUsers" (ZOOKEEPER-3959);
>>> > >
>>> > >   * Fast-tracking of throttled requests (ZOOKEEPER-3683);
>>> > >
>>> > >   * Additional security metrics (ZOOKEEPER-3978);
>>> > >
>>> > >   * SASL support in the C and Perl clients (ZOOKEEPER-1112,
>>> > > ZOOKEEPER-3714);
>>> > >
>>> > >   * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
>>> > >
>>> > >   * Notes on how to benchmark ZooKeeper with the YCSB tool
>>> > > (ZOOKEEPER-3264).
>>> > >
>>> > > The release notes are available here:
>>> > >
>>> > >
>>> > >
>>> >
>>> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/website/releasenotes.html
>>> > >
>>> > >
>>> >
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346617
>>> > >
>>> > > *** Please download, test and vote by January 31st 2020, 23:59 UTC+0.
>>> ***
>>> > >
>>> > > Source files:
>>> > >
>>> > >   https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/
>>> > >
>>> > > Maven staging repo:
>>> > >
>>> > >
>>> > >
>>> >
>>> https://repository.apache.org/content/repositories/orgapachezookeeper-1066/
>>> > >
>>> > > The release candidate tag in git to be voted upon: release-3.7.0-1
>>> > >
>>> > >   https://github.com/apache/zookeeper/tree/release-3.7.0-1
>>> > >
>>> > > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
>>> > >
>>> > >   https://www.apache.org/dist/zookeeper/KEYS
>>> > >
>>> > > The staging version of the website is:
>>> > >
>>> > >
>>> > >
>>> >
>>> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/website/
>>> > >
>>> > > Should we release this candidate?
>>> > >
>>> > > Damien Diederen
>>> > >
>>> >
>>>
>>

Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 1

Posted by Norbert Kalmar <nk...@cloudera.com.INVALID>.
Please disregard my last email, I had ZooKeeper running in the background,
killing it solved that test, the fork issue is not caused by that.

On Mon, Jan 25, 2021 at 5:26 PM Norbert Kalmar <nk...@cloudera.com> wrote:

> Sorry, the linked test is just an assertion error, no exception there.
> I had another test failure which had an error thrown. I will investigate
> further, as this might be some macOD address issue/collission yet again:
>
> [ERROR] Tests run: 10, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 26.229 s <<< FAILURE! - in org.apache.zookeeper.server.quorum.CnxManagerTest
> [ERROR] testCnxManagerListenerThreadConfigurableRetry  Time elapsed: 0.178
> s  <<< ERROR!
> java.net.BindException: Address already in use
> at sun.nio.ch.Net.bind0(Native Method)
> at
> org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:662)
> at
> org.apache.zookeeper.server.ServerCnxnFactory.configure(ServerCnxnFactory.java:109)
> at
> org.apache.zookeeper.server.ServerCnxnFactory.createFactory(ServerCnxnFactory.java:191)
> at
> org.apache.zookeeper.server.ServerCnxnFactory.createFactory(ServerCnxnFactory.java:186)
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.<init>(QuorumPeer.java:1253)
> at
> org.apache.zookeeper.server.quorum.CnxManagerTest.testCnxManagerListenerThreadConfigurableRetry(CnxManagerTest.java:309)
>
>
>
> On Mon, Jan 25, 2021 at 5:20 PM Norbert Kalmar <nk...@cloudera.com>
> wrote:
>
>> -1 (non-binding!)
>>
>> - built the source, run locally, gave a few basic commands
>> - run tests on macOS 10.13.6, openjdk 1.8.0_242 - issues found, see below
>> - checked files in tarball
>> - checked signatures
>>
>> I had the same problem as Máté. unit tests did not pass on MacOS. Nothing
>> has changed in my environment since I did the 3.5.9 release, and it had no
>> issue back then.
>>
>> I gave a -1 because this error doesn't only occur to me.
>>
>> The test that failed:
>>
>> [ERROR] Tests run: 7, Failures: 1, Errors: 0, Skipped: 1, Time elapsed:
>> 62.332 s <<< FAILURE! - in
>> org.apache.zookeeper.server.util.RequestPathMetricsCollectorTest
>>
>> [ERROR] testMultiThreadPerf  Time elapsed: 4.816 s  <<< FAILURE!
>>
>> org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
>>
>> at
>> org.apache.zookeeper.server.util.RequestPathMetricsCollectorTest.testMultiThreadPerf(RequestPathMetricsCollectorTest.java:448)
>>
>>
>>
>> - Norbert
>>
>>
>>
>> On Mon, Jan 25, 2021 at 1:39 PM Szalay-Bekő Máté <
>> szalay.beko.mate@gmail.com> wrote:
>>
>>> +0 (and not even binding :) )
>>>
>>> - I built the source code (-Pfull-build) on Ubuntu 18.04.3 using OpenJDK
>>> 8u265 and maven 3.6.3.
>>> - I also built and executed unit tests for zkpython
>>> - the unit tests passed for the C-client and for python client
>>> - checkstyle and spotbugs passed
>>> - apache-rat passed
>>> - owasp (CVE check) passed
>>> - fatjar built (-Pfatjar)
>>> - I executed a quick rolling-upgrade test from 3.5.9 and from 3.6.2.
>>> (using
>>> https://github.com/symat/zk-rolling-upgrade-test)
>>>
>>> for some reason the java unit tests failed for me.
>>>
>>> On mac (jdk 1.8.212 and maven 3.6.3), I got all the unit tests executed
>>> successfully, but then the maven job still failed for hbase-server test
>>> with error message (with -DforkCount=4 and even with -DforkCount=1) like:
>>> -------------
>>> [ERROR] ExecutionException There was an error in the forked process
>>> [ERROR] unable to create new native thread
>>> [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException:
>>> ExecutionException There was an error in the forked process
>>> [ERROR] unable to create new native thread
>>> [ERROR] at
>>>
>>> org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:510)
>>> -------------
>>>
>>>
>>> Then I tried on a dockerized environment (ubuntu 18.4, OpenJDK 8u265 and
>>> maven 3.6.3) and I got other kinds of strange maven errors:
>>> -------------------
>>> [ERROR] Caused by:
>>> org.apache.maven.surefire.booter.SurefireBooterForkException: The forked
>>> VM
>>> terminated without properly saying goodbye. VM crash or System.exit
>>> called?
>>> [ERROR] Command was /bin/sh -c cd
>>> /tmp/zk/apache-zookeeper-3.7.0/zookeeper-server &&
>>> /home/symat/.sdkman/candidates/java/8.0.265-open/jre/bin/java -Xmx512m
>>> -Dtest.junit.threads=8 -Dzookeeper.junit.threadid=3
>>>
>>> -javaagent:/home/symat/.m2/repository/org/jmockit/jmockit/1.48/jmockit-1.48.jar
>>> -jar
>>>
>>> /tmp/zk/apache-zookeeper-3.7.0/zookeeper-server/target/surefire/surefirebooter8828313385463488429.jar
>>> /tmp/zk/apache-zookeeper-3.7.0/zookeeper-server/target/surefire
>>> 2021-01-25T11-54-03_621-jvmRun3 surefire4024538135165099286tmp
>>> surefire_37800399112966511000tmp
>>> [ERROR] Process Exit Code: 0
>>> [ERROR]         at
>>>
>>> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:669)
>>> [ERROR]         at
>>>
>>> org.apache.maven.plugin.surefire.booterclient.ForkStarter.access$600(ForkStarter.java:115)
>>> [ERROR]         at
>>>
>>> org.apache.maven.plugin.surefire.booterclient.ForkStarter$2.call(ForkStarter.java:444)
>>> [ERROR]         at
>>>
>>> org.apache.maven.plugin.surefire.booterclient.ForkStarter$2.call(ForkStarter.java:420)
>>> [ERROR]         at
>>> java.util.concurrent.FutureTask.run(FutureTask.java:266)
>>> [ERROR]         at
>>>
>>> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>>> [ERROR]         at
>>>
>>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>>> [ERROR]         at java.lang.Thread.run(Thread.java:748)
>>> [ERROR]
>>> --------------------------------------
>>>
>>>
>>> These issues might be very well specific to my local (mac or docker on
>>> mac)
>>> environments. This is why I didn't vote with -1
>>> Can someone else run the java unit tests successfully locally?
>>>
>>> I also tried to check if the CI was green for the last PR on 3.7.0 (
>>> https://github.com/apache/zookeeper/pull/1586/checks), but it looks the
>>> CI
>>> haven't even started to execute the tests, due to errors in the "install
>>> C
>>> dependencies" step.
>>>
>>> Regards,
>>> Mate
>>>
>>> On Sun, Jan 24, 2021 at 11:39 PM Patrick Hunt <ph...@apache.org> wrote:
>>>
>>> > +1. xsum/sig verified. rat ran clean. built and dependency checks are
>>> fine.
>>> > Tried running some manual clusters and it was successful.
>>> >
>>> > Regards,
>>> >
>>> > Patrick
>>> >
>>> >
>>> > On Sun, Jan 24, 2021 at 12:11 PM Damien Diederen <ddiederen@apache.org
>>> >
>>> > wrote:
>>> >
>>> > >
>>> > > Dear all,
>>> > >
>>> > > This is a second release candidate for ZooKeeper 3.7.0.  Compared to
>>> > > RC0, it fixes a tarball generation issue, includes a description of
>>> the
>>> > > 'whoami' CLI command, and incorporates a contribution to
>>> ZooInspector.
>>> > >
>>> > > ZooKeeper 3.7.0 introduces a number of new features, notably:
>>> > >
>>> > >   * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
>>> > >
>>> > >   * Quota enforcement (ZOOKEEPER-3301);
>>> > >
>>> > >   * Host name canonicalization in quorum SASL authentication
>>> > > (ZOOKEEPER-4030);
>>> > >
>>> > >   * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
>>> > >
>>> > >   * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);
>>> > >
>>> > >   * A "whoami" API and CLI command (ZOOKEEPER-3969);
>>> > >
>>> > >   * The possibility of disabling digest authentication
>>> (ZOOKEEPER-3979);
>>> > >
>>> > >   * Multiple SASL "superUsers" (ZOOKEEPER-3959);
>>> > >
>>> > >   * Fast-tracking of throttled requests (ZOOKEEPER-3683);
>>> > >
>>> > >   * Additional security metrics (ZOOKEEPER-3978);
>>> > >
>>> > >   * SASL support in the C and Perl clients (ZOOKEEPER-1112,
>>> > > ZOOKEEPER-3714);
>>> > >
>>> > >   * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
>>> > >
>>> > >   * Notes on how to benchmark ZooKeeper with the YCSB tool
>>> > > (ZOOKEEPER-3264).
>>> > >
>>> > > The release notes are available here:
>>> > >
>>> > >
>>> > >
>>> >
>>> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/website/releasenotes.html
>>> > >
>>> > >
>>> >
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346617
>>> > >
>>> > > *** Please download, test and vote by January 31st 2020, 23:59
>>> UTC+0. ***
>>> > >
>>> > > Source files:
>>> > >
>>> > >   https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/
>>> > >
>>> > > Maven staging repo:
>>> > >
>>> > >
>>> > >
>>> >
>>> https://repository.apache.org/content/repositories/orgapachezookeeper-1066/
>>> > >
>>> > > The release candidate tag in git to be voted upon: release-3.7.0-1
>>> > >
>>> > >   https://github.com/apache/zookeeper/tree/release-3.7.0-1
>>> > >
>>> > > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
>>> > >
>>> > >   https://www.apache.org/dist/zookeeper/KEYS
>>> > >
>>> > > The staging version of the website is:
>>> > >
>>> > >
>>> > >
>>> >
>>> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/website/
>>> > >
>>> > > Should we release this candidate?
>>> > >
>>> > > Damien Diederen
>>> > >
>>> >
>>>
>>

Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 1

Posted by Norbert Kalmar <nk...@cloudera.com.INVALID>.
Sorry, the linked test is just an assertion error, no exception there.
I had another test failure which had an error thrown. I will investigate
further, as this might be some macOD address issue/collission yet again:

[ERROR] Tests run: 10, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
26.229 s <<< FAILURE! - in org.apache.zookeeper.server.quorum.CnxManagerTest
[ERROR] testCnxManagerListenerThreadConfigurableRetry  Time elapsed: 0.178
s  <<< ERROR!
java.net.BindException: Address already in use
at sun.nio.ch.Net.bind0(Native Method)
at
org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:662)
at
org.apache.zookeeper.server.ServerCnxnFactory.configure(ServerCnxnFactory.java:109)
at
org.apache.zookeeper.server.ServerCnxnFactory.createFactory(ServerCnxnFactory.java:191)
at
org.apache.zookeeper.server.ServerCnxnFactory.createFactory(ServerCnxnFactory.java:186)
at
org.apache.zookeeper.server.quorum.QuorumPeer.<init>(QuorumPeer.java:1253)
at
org.apache.zookeeper.server.quorum.CnxManagerTest.testCnxManagerListenerThreadConfigurableRetry(CnxManagerTest.java:309)



On Mon, Jan 25, 2021 at 5:20 PM Norbert Kalmar <nk...@cloudera.com> wrote:

> -1 (non-binding!)
>
> - built the source, run locally, gave a few basic commands
> - run tests on macOS 10.13.6, openjdk 1.8.0_242 - issues found, see below
> - checked files in tarball
> - checked signatures
>
> I had the same problem as Máté. unit tests did not pass on MacOS. Nothing
> has changed in my environment since I did the 3.5.9 release, and it had no
> issue back then.
>
> I gave a -1 because this error doesn't only occur to me.
>
> The test that failed:
>
> [ERROR] Tests run: 7, Failures: 1, Errors: 0, Skipped: 1, Time elapsed:
> 62.332 s <<< FAILURE! - in
> org.apache.zookeeper.server.util.RequestPathMetricsCollectorTest
>
> [ERROR] testMultiThreadPerf  Time elapsed: 4.816 s  <<< FAILURE!
>
> org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
>
> at
> org.apache.zookeeper.server.util.RequestPathMetricsCollectorTest.testMultiThreadPerf(RequestPathMetricsCollectorTest.java:448)
>
>
>
> - Norbert
>
>
>
> On Mon, Jan 25, 2021 at 1:39 PM Szalay-Bekő Máté <
> szalay.beko.mate@gmail.com> wrote:
>
>> +0 (and not even binding :) )
>>
>> - I built the source code (-Pfull-build) on Ubuntu 18.04.3 using OpenJDK
>> 8u265 and maven 3.6.3.
>> - I also built and executed unit tests for zkpython
>> - the unit tests passed for the C-client and for python client
>> - checkstyle and spotbugs passed
>> - apache-rat passed
>> - owasp (CVE check) passed
>> - fatjar built (-Pfatjar)
>> - I executed a quick rolling-upgrade test from 3.5.9 and from 3.6.2.
>> (using
>> https://github.com/symat/zk-rolling-upgrade-test)
>>
>> for some reason the java unit tests failed for me.
>>
>> On mac (jdk 1.8.212 and maven 3.6.3), I got all the unit tests executed
>> successfully, but then the maven job still failed for hbase-server test
>> with error message (with -DforkCount=4 and even with -DforkCount=1) like:
>> -------------
>> [ERROR] ExecutionException There was an error in the forked process
>> [ERROR] unable to create new native thread
>> [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException:
>> ExecutionException There was an error in the forked process
>> [ERROR] unable to create new native thread
>> [ERROR] at
>>
>> org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:510)
>> -------------
>>
>>
>> Then I tried on a dockerized environment (ubuntu 18.4, OpenJDK 8u265 and
>> maven 3.6.3) and I got other kinds of strange maven errors:
>> -------------------
>> [ERROR] Caused by:
>> org.apache.maven.surefire.booter.SurefireBooterForkException: The forked
>> VM
>> terminated without properly saying goodbye. VM crash or System.exit
>> called?
>> [ERROR] Command was /bin/sh -c cd
>> /tmp/zk/apache-zookeeper-3.7.0/zookeeper-server &&
>> /home/symat/.sdkman/candidates/java/8.0.265-open/jre/bin/java -Xmx512m
>> -Dtest.junit.threads=8 -Dzookeeper.junit.threadid=3
>>
>> -javaagent:/home/symat/.m2/repository/org/jmockit/jmockit/1.48/jmockit-1.48.jar
>> -jar
>>
>> /tmp/zk/apache-zookeeper-3.7.0/zookeeper-server/target/surefire/surefirebooter8828313385463488429.jar
>> /tmp/zk/apache-zookeeper-3.7.0/zookeeper-server/target/surefire
>> 2021-01-25T11-54-03_621-jvmRun3 surefire4024538135165099286tmp
>> surefire_37800399112966511000tmp
>> [ERROR] Process Exit Code: 0
>> [ERROR]         at
>>
>> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:669)
>> [ERROR]         at
>>
>> org.apache.maven.plugin.surefire.booterclient.ForkStarter.access$600(ForkStarter.java:115)
>> [ERROR]         at
>>
>> org.apache.maven.plugin.surefire.booterclient.ForkStarter$2.call(ForkStarter.java:444)
>> [ERROR]         at
>>
>> org.apache.maven.plugin.surefire.booterclient.ForkStarter$2.call(ForkStarter.java:420)
>> [ERROR]         at
>> java.util.concurrent.FutureTask.run(FutureTask.java:266)
>> [ERROR]         at
>>
>> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>> [ERROR]         at
>>
>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>> [ERROR]         at java.lang.Thread.run(Thread.java:748)
>> [ERROR]
>> --------------------------------------
>>
>>
>> These issues might be very well specific to my local (mac or docker on
>> mac)
>> environments. This is why I didn't vote with -1
>> Can someone else run the java unit tests successfully locally?
>>
>> I also tried to check if the CI was green for the last PR on 3.7.0 (
>> https://github.com/apache/zookeeper/pull/1586/checks), but it looks the
>> CI
>> haven't even started to execute the tests, due to errors in the "install C
>> dependencies" step.
>>
>> Regards,
>> Mate
>>
>> On Sun, Jan 24, 2021 at 11:39 PM Patrick Hunt <ph...@apache.org> wrote:
>>
>> > +1. xsum/sig verified. rat ran clean. built and dependency checks are
>> fine.
>> > Tried running some manual clusters and it was successful.
>> >
>> > Regards,
>> >
>> > Patrick
>> >
>> >
>> > On Sun, Jan 24, 2021 at 12:11 PM Damien Diederen <dd...@apache.org>
>> > wrote:
>> >
>> > >
>> > > Dear all,
>> > >
>> > > This is a second release candidate for ZooKeeper 3.7.0.  Compared to
>> > > RC0, it fixes a tarball generation issue, includes a description of
>> the
>> > > 'whoami' CLI command, and incorporates a contribution to ZooInspector.
>> > >
>> > > ZooKeeper 3.7.0 introduces a number of new features, notably:
>> > >
>> > >   * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
>> > >
>> > >   * Quota enforcement (ZOOKEEPER-3301);
>> > >
>> > >   * Host name canonicalization in quorum SASL authentication
>> > > (ZOOKEEPER-4030);
>> > >
>> > >   * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
>> > >
>> > >   * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);
>> > >
>> > >   * A "whoami" API and CLI command (ZOOKEEPER-3969);
>> > >
>> > >   * The possibility of disabling digest authentication
>> (ZOOKEEPER-3979);
>> > >
>> > >   * Multiple SASL "superUsers" (ZOOKEEPER-3959);
>> > >
>> > >   * Fast-tracking of throttled requests (ZOOKEEPER-3683);
>> > >
>> > >   * Additional security metrics (ZOOKEEPER-3978);
>> > >
>> > >   * SASL support in the C and Perl clients (ZOOKEEPER-1112,
>> > > ZOOKEEPER-3714);
>> > >
>> > >   * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
>> > >
>> > >   * Notes on how to benchmark ZooKeeper with the YCSB tool
>> > > (ZOOKEEPER-3264).
>> > >
>> > > The release notes are available here:
>> > >
>> > >
>> > >
>> >
>> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/website/releasenotes.html
>> > >
>> > >
>> >
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346617
>> > >
>> > > *** Please download, test and vote by January 31st 2020, 23:59 UTC+0.
>> ***
>> > >
>> > > Source files:
>> > >
>> > >   https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/
>> > >
>> > > Maven staging repo:
>> > >
>> > >
>> > >
>> >
>> https://repository.apache.org/content/repositories/orgapachezookeeper-1066/
>> > >
>> > > The release candidate tag in git to be voted upon: release-3.7.0-1
>> > >
>> > >   https://github.com/apache/zookeeper/tree/release-3.7.0-1
>> > >
>> > > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
>> > >
>> > >   https://www.apache.org/dist/zookeeper/KEYS
>> > >
>> > > The staging version of the website is:
>> > >
>> > >
>> > >
>> >
>> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/website/
>> > >
>> > > Should we release this candidate?
>> > >
>> > > Damien Diederen
>> > >
>> >
>>
>

Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 1

Posted by Norbert Kalmar <nk...@cloudera.com.INVALID>.
-1 (non-binding!)

- built the source, run locally, gave a few basic commands
- run tests on macOS 10.13.6, openjdk 1.8.0_242 - issues found, see below
- checked files in tarball
- checked signatures

I had the same problem as Máté. unit tests did not pass on MacOS. Nothing
has changed in my environment since I did the 3.5.9 release, and it had no
issue back then.

I gave a -1 because this error doesn't only occur to me.

The test that failed:

[ERROR] Tests run: 7, Failures: 1, Errors: 0, Skipped: 1, Time elapsed:
62.332 s <<< FAILURE! - in
org.apache.zookeeper.server.util.RequestPathMetricsCollectorTest

[ERROR] testMultiThreadPerf  Time elapsed: 4.816 s  <<< FAILURE!

org.opentest4j.AssertionFailedError: expected: <true> but was: <false>

at
org.apache.zookeeper.server.util.RequestPathMetricsCollectorTest.testMultiThreadPerf(RequestPathMetricsCollectorTest.java:448)



- Norbert



On Mon, Jan 25, 2021 at 1:39 PM Szalay-Bekő Máté <sz...@gmail.com>
wrote:

> +0 (and not even binding :) )
>
> - I built the source code (-Pfull-build) on Ubuntu 18.04.3 using OpenJDK
> 8u265 and maven 3.6.3.
> - I also built and executed unit tests for zkpython
> - the unit tests passed for the C-client and for python client
> - checkstyle and spotbugs passed
> - apache-rat passed
> - owasp (CVE check) passed
> - fatjar built (-Pfatjar)
> - I executed a quick rolling-upgrade test from 3.5.9 and from 3.6.2. (using
> https://github.com/symat/zk-rolling-upgrade-test)
>
> for some reason the java unit tests failed for me.
>
> On mac (jdk 1.8.212 and maven 3.6.3), I got all the unit tests executed
> successfully, but then the maven job still failed for hbase-server test
> with error message (with -DforkCount=4 and even with -DforkCount=1) like:
> -------------
> [ERROR] ExecutionException There was an error in the forked process
> [ERROR] unable to create new native thread
> [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException:
> ExecutionException There was an error in the forked process
> [ERROR] unable to create new native thread
> [ERROR] at
>
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:510)
> -------------
>
>
> Then I tried on a dockerized environment (ubuntu 18.4, OpenJDK 8u265 and
> maven 3.6.3) and I got other kinds of strange maven errors:
> -------------------
> [ERROR] Caused by:
> org.apache.maven.surefire.booter.SurefireBooterForkException: The forked VM
> terminated without properly saying goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd
> /tmp/zk/apache-zookeeper-3.7.0/zookeeper-server &&
> /home/symat/.sdkman/candidates/java/8.0.265-open/jre/bin/java -Xmx512m
> -Dtest.junit.threads=8 -Dzookeeper.junit.threadid=3
>
> -javaagent:/home/symat/.m2/repository/org/jmockit/jmockit/1.48/jmockit-1.48.jar
> -jar
>
> /tmp/zk/apache-zookeeper-3.7.0/zookeeper-server/target/surefire/surefirebooter8828313385463488429.jar
> /tmp/zk/apache-zookeeper-3.7.0/zookeeper-server/target/surefire
> 2021-01-25T11-54-03_621-jvmRun3 surefire4024538135165099286tmp
> surefire_37800399112966511000tmp
> [ERROR] Process Exit Code: 0
> [ERROR]         at
>
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:669)
> [ERROR]         at
>
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.access$600(ForkStarter.java:115)
> [ERROR]         at
>
> org.apache.maven.plugin.surefire.booterclient.ForkStarter$2.call(ForkStarter.java:444)
> [ERROR]         at
>
> org.apache.maven.plugin.surefire.booterclient.ForkStarter$2.call(ForkStarter.java:420)
> [ERROR]         at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> [ERROR]         at
>
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> [ERROR]         at
>
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [ERROR]         at java.lang.Thread.run(Thread.java:748)
> [ERROR]
> --------------------------------------
>
>
> These issues might be very well specific to my local (mac or docker on mac)
> environments. This is why I didn't vote with -1
> Can someone else run the java unit tests successfully locally?
>
> I also tried to check if the CI was green for the last PR on 3.7.0 (
> https://github.com/apache/zookeeper/pull/1586/checks), but it looks the CI
> haven't even started to execute the tests, due to errors in the "install C
> dependencies" step.
>
> Regards,
> Mate
>
> On Sun, Jan 24, 2021 at 11:39 PM Patrick Hunt <ph...@apache.org> wrote:
>
> > +1. xsum/sig verified. rat ran clean. built and dependency checks are
> fine.
> > Tried running some manual clusters and it was successful.
> >
> > Regards,
> >
> > Patrick
> >
> >
> > On Sun, Jan 24, 2021 at 12:11 PM Damien Diederen <dd...@apache.org>
> > wrote:
> >
> > >
> > > Dear all,
> > >
> > > This is a second release candidate for ZooKeeper 3.7.0.  Compared to
> > > RC0, it fixes a tarball generation issue, includes a description of the
> > > 'whoami' CLI command, and incorporates a contribution to ZooInspector.
> > >
> > > ZooKeeper 3.7.0 introduces a number of new features, notably:
> > >
> > >   * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
> > >
> > >   * Quota enforcement (ZOOKEEPER-3301);
> > >
> > >   * Host name canonicalization in quorum SASL authentication
> > > (ZOOKEEPER-4030);
> > >
> > >   * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
> > >
> > >   * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);
> > >
> > >   * A "whoami" API and CLI command (ZOOKEEPER-3969);
> > >
> > >   * The possibility of disabling digest authentication
> (ZOOKEEPER-3979);
> > >
> > >   * Multiple SASL "superUsers" (ZOOKEEPER-3959);
> > >
> > >   * Fast-tracking of throttled requests (ZOOKEEPER-3683);
> > >
> > >   * Additional security metrics (ZOOKEEPER-3978);
> > >
> > >   * SASL support in the C and Perl clients (ZOOKEEPER-1112,
> > > ZOOKEEPER-3714);
> > >
> > >   * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
> > >
> > >   * Notes on how to benchmark ZooKeeper with the YCSB tool
> > > (ZOOKEEPER-3264).
> > >
> > > The release notes are available here:
> > >
> > >
> > >
> >
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/website/releasenotes.html
> > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346617
> > >
> > > *** Please download, test and vote by January 31st 2020, 23:59 UTC+0.
> ***
> > >
> > > Source files:
> > >
> > >   https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/
> > >
> > > Maven staging repo:
> > >
> > >
> > >
> >
> https://repository.apache.org/content/repositories/orgapachezookeeper-1066/
> > >
> > > The release candidate tag in git to be voted upon: release-3.7.0-1
> > >
> > >   https://github.com/apache/zookeeper/tree/release-3.7.0-1
> > >
> > > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> > >
> > >   https://www.apache.org/dist/zookeeper/KEYS
> > >
> > > The staging version of the website is:
> > >
> > >
> > >
> >
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/website/
> > >
> > > Should we release this candidate?
> > >
> > > Damien Diederen
> > >
> >
>

Re: Test failures on 3.7.0 RC1

Posted by Szalay-Bekő Máté <sz...@gmail.com>.
> It seems forkCount is overriden by the surefire-forkcount property.
> This seems to do what you expect:
>
>    mvn test -Dsurefire.rerunFailingTestsCount=3 -fae -Pfull-build
-Dsurefire-forkcount=1

indeed... this seems to be the case on all active branches. my mistake :)

Thanks!
Mate

On Thu, Jan 28, 2021 at 9:38 PM Damien Diederen <dd...@apache.org>
wrote:

>
> Hi Máté, all,
>
> I managed to fight my way though some Apple ID insanity to get a Mac
> running with Catalina, Java, Maven and a C compiler.  This part of the
> puzzle was particularly fun:
>
>     https://dd.crosstwine.com/tmp/apple-id.png
>
> Anyway.
>
> > So I prefer to execute the java unit tests using the following command
> when
> > checking RCs:
> >
> > mvn test -Dsurefire.rerunFailingTestsCount=3 -fae -Pfull-build
> -DforkCount=1
>
> This command does not work, at least on Catalina—where it forks eight
> runners:
>
>     % pstree 7846
>     -+= 07846 administrator /Library/Java/JavaVir.../adoptopenjdk-8...
>      |-+- 09342 administrator /bin/sh -c cd /Users/...
>      | \--- 09343 administrator /Library/Java/JavaVir.../adoptopenjdk-8...
>      |-+- 09640 administrator /bin/sh -c cd /Users/...
>      | \--- 09641 administrator /Library/Java/JavaVir.../adoptopenjdk-8...
>      |-+- 09797 administrator /bin/sh -c cd /Users/...
>      | \--- 09798 administrator /Library/Java/JavaVir.../adoptopenjdk-8...
>      |-+- 09893 administrator /bin/sh -c cd /Users/...
>      | \--- 09898 administrator /Library/Java/JavaVir.../adoptopenjdk-8...
>      |-+- 09912 administrator /bin/sh -c cd /Users/...
>      | \--- 09913 administrator /Library/Java/JavaVir.../adoptopenjdk-8...
>      |-+- 09942 administrator /bin/sh -c cd /Users/...
>      | \--- 09944 administrator /Library/Java/JavaVir.../adoptopenjdk-8...
>      |-+- 09955 administrator /bin/sh -c cd /Users/...
>      | \--- 09956 administrator /Library/Java/JavaVir.../adoptopenjdk-8...
>      \-+- 09960 administrator /bin/sh -c cd /Users/...
>        \--- 09961 administrator /Library/Java/JavaVir.../adoptopenjdk-8...
>
> It seems forkCount is overriden by the surefire-forkcount property.
> This seems to do what you expect:
>
>     mvn test -Dsurefire.rerunFailingTestsCount=3 -fae -Pfull-build
> -Dsurefire-forkcount=1
>
> But independently of that, I can reproduce the issue—even with a "real"
> sequential run.  It does not always result in the stack trace you saw,
> but often hangs with "funny" errors such as:
>
>     [WARNING] Corrupted STDOUT by directly writing to native stream in
> forked JVM 1. See FAQ web page and the dump file
> /Users/administrator/zookeeper/zookeeper-server/target/surefire-reports/2021-01-28T17-56-26_094-jvmRun1.dumpstream
>
>     # Created at 2021-01-28T18:37:51.381
>     Corrupted STDOUT by directly writing to native stream in forked JVM 1.
> Stream '[59.370s][warning][os,thread] Failed to start thread -
> pthread_create failed (EAGAIN) for attributes: stacksize: 1024k, guardsize:
> 4k, detached.'.
>
> I'm planning to have a closer look soon.
>
> Cu, -D
>
> P.-S. — Enrico: I am also able to reproduce the C compilation issues you
> reported.
>
>
> --8<---------------original message------------->8---
>
> Szalay-Bekő Máté <sz...@gmail.com> writes:
> >  this is not specific to 3.7, but in general:
> > from time to time I see different tests failing intermittently. I assume
> > this can be caused by other tests running in parallel. (because
> re-running
> > those tests alone usually makes them succeed)
> > So I prefer to execute the java unit tests using the following command
> when
> > checking RCs:
> >
> > mvn test -Dsurefire.rerunFailingTestsCount=3 -fae -Pfull-build
> -DforkCount=1
> >
> > As far as I remember, by default the fork count is set to 8 in maven, and
> > the CI is using (or was using before the migration) -DforkCount=4.
> >
> >
> > Regards,
> > Mate
> >
> > On Mon, Jan 25, 2021 at 1:51 PM Flavio Junqueira <fp...@apache.org> wrote:
> >
> >> I don't want to mess up with the vote thread, so I'm responding to this
> >> separately. I have been trying to build locally too unsuccessfully. I've
> >> been trying on an Ubuntu VM, Java 8 (build 1.8.0_181-b13), Maven 3.6.0.
> The
> >> set of tests failing varies from build to build, if it makes sense, I
> can
> >> try to collect all test failures I have seen and post.
> >>
> >> -Flavio
> >>
> >> > On 25 Jan 2021, at 13:38, Szalay-Bekő Máté <
> szalay.beko.mate@gmail.com>
> >> wrote:
> >> >
> >> > +0 (and not even binding :) )
> >> >
> >> > - I built the source code (-Pfull-build) on Ubuntu 18.04.3 using
> OpenJDK
> >> > 8u265 and maven 3.6.3.
> >> > - I also built and executed unit tests for zkpython
> >> > - the unit tests passed for the C-client and for python client
> >> > - checkstyle and spotbugs passed
> >> > - apache-rat passed
> >> > - owasp (CVE check) passed
> >> > - fatjar built (-Pfatjar)
> >> > - I executed a quick rolling-upgrade test from 3.5.9 and from 3.6.2.
> >> (using
> >> > https://github.com/symat/zk-rolling-upgrade-test)
> >> >
> >> > for some reason the java unit tests failed for me.
> >> >
> >> > On mac (jdk 1.8.212 and maven 3.6.3), I got all the unit tests
> executed
> >> > successfully, but then the maven job still failed for hbase-server
> test
> >> > with error message (with -DforkCount=4 and even with -DforkCount=1)
> like:
> >> > -------------
> >> > [ERROR] ExecutionException There was an error in the forked process
> >> > [ERROR] unable to create new native thread
> >> > [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException:
> >> > ExecutionException There was an error in the forked process
> >> > [ERROR] unable to create new native thread
> >> > [ERROR] at
> >> >
> >>
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:510)
> >> > -------------
> >> >
> >> >
> >> > Then I tried on a dockerized environment (ubuntu 18.4, OpenJDK 8u265
> and
> >> > maven 3.6.3) and I got other kinds of strange maven errors:
> >> > -------------------
> >> > [ERROR] Caused by:
> >> > org.apache.maven.surefire.booter.SurefireBooterForkException: The
> forked
> >> VM
> >> > terminated without properly saying goodbye. VM crash or System.exit
> >> called?
> >> > [ERROR] Command was /bin/sh -c cd
> >> > /tmp/zk/apache-zookeeper-3.7.0/zookeeper-server &&
> >> > /home/symat/.sdkman/candidates/java/8.0.265-open/jre/bin/java -Xmx512m
> >> > -Dtest.junit.threads=8 -Dzookeeper.junit.threadid=3
> >> >
> >>
> -javaagent:/home/symat/.m2/repository/org/jmockit/jmockit/1.48/jmockit-1.48.jar
> >> > -jar
> >> >
> >>
> /tmp/zk/apache-zookeeper-3.7.0/zookeeper-server/target/surefire/surefirebooter8828313385463488429.jar
> >> > /tmp/zk/apache-zookeeper-3.7.0/zookeeper-server/target/surefire
> >> > 2021-01-25T11-54-03_621-jvmRun3 surefire4024538135165099286tmp
> >> > surefire_37800399112966511000tmp
> >> > [ERROR] Process Exit Code: 0
> >> > [ERROR]         at
> >> >
> >>
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:669)
> >> > [ERROR]         at
> >> >
> >>
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.access$600(ForkStarter.java:115)
> >> > [ERROR]         at
> >> >
> >>
> org.apache.maven.plugin.surefire.booterclient.ForkStarter$2.call(ForkStarter.java:444)
> >> > [ERROR]         at
> >> >
> >>
> org.apache.maven.plugin.surefire.booterclient.ForkStarter$2.call(ForkStarter.java:420)
> >> > [ERROR]         at
> >> java.util.concurrent.FutureTask.run(FutureTask.java:266)
> >> > [ERROR]         at
> >> >
> >>
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> >> > [ERROR]         at
> >> >
> >>
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> >> > [ERROR]         at java.lang.Thread.run(Thread.java:748)
> >> > [ERROR]
> >> > --------------------------------------
> >> >
> >> >
> >> > These issues might be very well specific to my local (mac or docker on
> >> mac)
> >> > environments. This is why I didn't vote with -1
> >> > Can someone else run the java unit tests successfully locally?
> >> >
> >> > I also tried to check if the CI was green for the last PR on 3.7.0 (
> >> > https://github.com/apache/zookeeper/pull/1586/checks), but it looks
> the
> >> CI
> >> > haven't even started to execute the tests, due to errors in the
> "install
> >> C
> >> > dependencies" step.
> >> >
> >> > Regards,
> >> > Mate
> >> >
> >> > On Sun, Jan 24, 2021 at 11:39 PM Patrick Hunt <ph...@apache.org>
> wrote:
> >> >
> >> >> +1. xsum/sig verified. rat ran clean. built and dependency checks are
> >> fine.
> >> >> Tried running some manual clusters and it was successful.
> >> >>
> >> >> Regards,
> >> >>
> >> >> Patrick
> >> >>
> >> >>
> >> >> On Sun, Jan 24, 2021 at 12:11 PM Damien Diederen <
> ddiederen@apache.org>
> >> >> wrote:
> >> >>
> >> >>>
> >> >>> Dear all,
> >> >>>
> >> >>> This is a second release candidate for ZooKeeper 3.7.0.  Compared to
> >> >>> RC0, it fixes a tarball generation issue, includes a description of
> the
> >> >>> 'whoami' CLI command, and incorporates a contribution to
> ZooInspector.
> >> >>>
> >> >>> ZooKeeper 3.7.0 introduces a number of new features, notably:
> >> >>>
> >> >>>  * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
> >> >>>
> >> >>>  * Quota enforcement (ZOOKEEPER-3301);
> >> >>>
> >> >>>  * Host name canonicalization in quorum SASL authentication
> >> >>> (ZOOKEEPER-4030);
> >> >>>
> >> >>>  * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
> >> >>>
> >> >>>  * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);
> >> >>>
> >> >>>  * A "whoami" API and CLI command (ZOOKEEPER-3969);
> >> >>>
> >> >>>  * The possibility of disabling digest authentication
> (ZOOKEEPER-3979);
> >> >>>
> >> >>>  * Multiple SASL "superUsers" (ZOOKEEPER-3959);
> >> >>>
> >> >>>  * Fast-tracking of throttled requests (ZOOKEEPER-3683);
> >> >>>
> >> >>>  * Additional security metrics (ZOOKEEPER-3978);
> >> >>>
> >> >>>  * SASL support in the C and Perl clients (ZOOKEEPER-1112,
> >> >>> ZOOKEEPER-3714);
> >> >>>
> >> >>>  * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
> >> >>>
> >> >>>  * Notes on how to benchmark ZooKeeper with the YCSB tool
> >> >>> (ZOOKEEPER-3264).
> >> >>>
> >> >>> The release notes are available here:
> >> >>>
> >> >>>
> >> >>>
> >> >>
> >>
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/website/releasenotes.html
> >> >>>
> >> >>>
> >> >>
> >>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346617
> >> >>>
> >> >>> *** Please download, test and vote by January 31st 2020, 23:59
> UTC+0.
> >> ***
> >> >>>
> >> >>> Source files:
> >> >>>
> >> >>>  https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/
> >> >>>
> >> >>> Maven staging repo:
> >> >>>
> >> >>>
> >> >>>
> >> >>
> >>
> https://repository.apache.org/content/repositories/orgapachezookeeper-1066/
> >> >>>
> >> >>> The release candidate tag in git to be voted upon: release-3.7.0-1
> >> >>>
> >> >>>  https://github.com/apache/zookeeper/tree/release-3.7.0-1
> >> >>>
> >> >>> ZooKeeper's KEYS file containing PGP keys we use to sign the
> release:
> >> >>>
> >> >>>  https://www.apache.org/dist/zookeeper/KEYS
> >> >>>
> >> >>> The staging version of the website is:
> >> >>>
> >> >>>
> >> >>>
> >> >>
> >>
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/website/
> >> >>>
> >> >>> Should we release this candidate?
> >> >>>
> >> >>> Damien Diederen
> >> >>>
> >> >>
> >>
> >>
>

Re: Test failures on 3.7.0 RC1

Posted by Damien Diederen <dd...@apache.org>.
Hi Máté, all,

I managed to fight my way though some Apple ID insanity to get a Mac
running with Catalina, Java, Maven and a C compiler.  This part of the
puzzle was particularly fun:

    https://dd.crosstwine.com/tmp/apple-id.png

Anyway.

> So I prefer to execute the java unit tests using the following command when
> checking RCs:
>
> mvn test -Dsurefire.rerunFailingTestsCount=3 -fae -Pfull-build -DforkCount=1

This command does not work, at least on Catalina—where it forks eight
runners:

    % pstree 7846
    -+= 07846 administrator /Library/Java/JavaVir.../adoptopenjdk-8...
     |-+- 09342 administrator /bin/sh -c cd /Users/...
     | \--- 09343 administrator /Library/Java/JavaVir.../adoptopenjdk-8...
     |-+- 09640 administrator /bin/sh -c cd /Users/...
     | \--- 09641 administrator /Library/Java/JavaVir.../adoptopenjdk-8...
     |-+- 09797 administrator /bin/sh -c cd /Users/...
     | \--- 09798 administrator /Library/Java/JavaVir.../adoptopenjdk-8...
     |-+- 09893 administrator /bin/sh -c cd /Users/...
     | \--- 09898 administrator /Library/Java/JavaVir.../adoptopenjdk-8...
     |-+- 09912 administrator /bin/sh -c cd /Users/...
     | \--- 09913 administrator /Library/Java/JavaVir.../adoptopenjdk-8...
     |-+- 09942 administrator /bin/sh -c cd /Users/...
     | \--- 09944 administrator /Library/Java/JavaVir.../adoptopenjdk-8...
     |-+- 09955 administrator /bin/sh -c cd /Users/...
     | \--- 09956 administrator /Library/Java/JavaVir.../adoptopenjdk-8...
     \-+- 09960 administrator /bin/sh -c cd /Users/...
       \--- 09961 administrator /Library/Java/JavaVir.../adoptopenjdk-8...

It seems forkCount is overriden by the surefire-forkcount property.
This seems to do what you expect:

    mvn test -Dsurefire.rerunFailingTestsCount=3 -fae -Pfull-build -Dsurefire-forkcount=1

But independently of that, I can reproduce the issue—even with a "real"
sequential run.  It does not always result in the stack trace you saw,
but often hangs with "funny" errors such as:

    [WARNING] Corrupted STDOUT by directly writing to native stream in forked JVM 1. See FAQ web page and the dump file /Users/administrator/zookeeper/zookeeper-server/target/surefire-reports/2021-01-28T17-56-26_094-jvmRun1.dumpstream

    # Created at 2021-01-28T18:37:51.381
    Corrupted STDOUT by directly writing to native stream in forked JVM 1. Stream '[59.370s][warning][os,thread] Failed to start thread - pthread_create failed (EAGAIN) for attributes: stacksize: 1024k, guardsize: 4k, detached.'.

I'm planning to have a closer look soon.

Cu, -D

P.-S. — Enrico: I am also able to reproduce the C compilation issues you
reported.


--8<---------------original message------------->8---

Szalay-Bekő Máté <sz...@gmail.com> writes:
>  this is not specific to 3.7, but in general:
> from time to time I see different tests failing intermittently. I assume
> this can be caused by other tests running in parallel. (because re-running
> those tests alone usually makes them succeed)
> So I prefer to execute the java unit tests using the following command when
> checking RCs:
>
> mvn test -Dsurefire.rerunFailingTestsCount=3 -fae -Pfull-build -DforkCount=1
>
> As far as I remember, by default the fork count is set to 8 in maven, and
> the CI is using (or was using before the migration) -DforkCount=4.
>
>
> Regards,
> Mate
>
> On Mon, Jan 25, 2021 at 1:51 PM Flavio Junqueira <fp...@apache.org> wrote:
>
>> I don't want to mess up with the vote thread, so I'm responding to this
>> separately. I have been trying to build locally too unsuccessfully. I've
>> been trying on an Ubuntu VM, Java 8 (build 1.8.0_181-b13), Maven 3.6.0. The
>> set of tests failing varies from build to build, if it makes sense, I can
>> try to collect all test failures I have seen and post.
>>
>> -Flavio
>>
>> > On 25 Jan 2021, at 13:38, Szalay-Bekő Máté <sz...@gmail.com>
>> wrote:
>> >
>> > +0 (and not even binding :) )
>> >
>> > - I built the source code (-Pfull-build) on Ubuntu 18.04.3 using OpenJDK
>> > 8u265 and maven 3.6.3.
>> > - I also built and executed unit tests for zkpython
>> > - the unit tests passed for the C-client and for python client
>> > - checkstyle and spotbugs passed
>> > - apache-rat passed
>> > - owasp (CVE check) passed
>> > - fatjar built (-Pfatjar)
>> > - I executed a quick rolling-upgrade test from 3.5.9 and from 3.6.2.
>> (using
>> > https://github.com/symat/zk-rolling-upgrade-test)
>> >
>> > for some reason the java unit tests failed for me.
>> >
>> > On mac (jdk 1.8.212 and maven 3.6.3), I got all the unit tests executed
>> > successfully, but then the maven job still failed for hbase-server test
>> > with error message (with -DforkCount=4 and even with -DforkCount=1) like:
>> > -------------
>> > [ERROR] ExecutionException There was an error in the forked process
>> > [ERROR] unable to create new native thread
>> > [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException:
>> > ExecutionException There was an error in the forked process
>> > [ERROR] unable to create new native thread
>> > [ERROR] at
>> >
>> org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:510)
>> > -------------
>> >
>> >
>> > Then I tried on a dockerized environment (ubuntu 18.4, OpenJDK 8u265 and
>> > maven 3.6.3) and I got other kinds of strange maven errors:
>> > -------------------
>> > [ERROR] Caused by:
>> > org.apache.maven.surefire.booter.SurefireBooterForkException: The forked
>> VM
>> > terminated without properly saying goodbye. VM crash or System.exit
>> called?
>> > [ERROR] Command was /bin/sh -c cd
>> > /tmp/zk/apache-zookeeper-3.7.0/zookeeper-server &&
>> > /home/symat/.sdkman/candidates/java/8.0.265-open/jre/bin/java -Xmx512m
>> > -Dtest.junit.threads=8 -Dzookeeper.junit.threadid=3
>> >
>> -javaagent:/home/symat/.m2/repository/org/jmockit/jmockit/1.48/jmockit-1.48.jar
>> > -jar
>> >
>> /tmp/zk/apache-zookeeper-3.7.0/zookeeper-server/target/surefire/surefirebooter8828313385463488429.jar
>> > /tmp/zk/apache-zookeeper-3.7.0/zookeeper-server/target/surefire
>> > 2021-01-25T11-54-03_621-jvmRun3 surefire4024538135165099286tmp
>> > surefire_37800399112966511000tmp
>> > [ERROR] Process Exit Code: 0
>> > [ERROR]         at
>> >
>> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:669)
>> > [ERROR]         at
>> >
>> org.apache.maven.plugin.surefire.booterclient.ForkStarter.access$600(ForkStarter.java:115)
>> > [ERROR]         at
>> >
>> org.apache.maven.plugin.surefire.booterclient.ForkStarter$2.call(ForkStarter.java:444)
>> > [ERROR]         at
>> >
>> org.apache.maven.plugin.surefire.booterclient.ForkStarter$2.call(ForkStarter.java:420)
>> > [ERROR]         at
>> java.util.concurrent.FutureTask.run(FutureTask.java:266)
>> > [ERROR]         at
>> >
>> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>> > [ERROR]         at
>> >
>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>> > [ERROR]         at java.lang.Thread.run(Thread.java:748)
>> > [ERROR]
>> > --------------------------------------
>> >
>> >
>> > These issues might be very well specific to my local (mac or docker on
>> mac)
>> > environments. This is why I didn't vote with -1
>> > Can someone else run the java unit tests successfully locally?
>> >
>> > I also tried to check if the CI was green for the last PR on 3.7.0 (
>> > https://github.com/apache/zookeeper/pull/1586/checks), but it looks the
>> CI
>> > haven't even started to execute the tests, due to errors in the "install
>> C
>> > dependencies" step.
>> >
>> > Regards,
>> > Mate
>> >
>> > On Sun, Jan 24, 2021 at 11:39 PM Patrick Hunt <ph...@apache.org> wrote:
>> >
>> >> +1. xsum/sig verified. rat ran clean. built and dependency checks are
>> fine.
>> >> Tried running some manual clusters and it was successful.
>> >>
>> >> Regards,
>> >>
>> >> Patrick
>> >>
>> >>
>> >> On Sun, Jan 24, 2021 at 12:11 PM Damien Diederen <dd...@apache.org>
>> >> wrote:
>> >>
>> >>>
>> >>> Dear all,
>> >>>
>> >>> This is a second release candidate for ZooKeeper 3.7.0.  Compared to
>> >>> RC0, it fixes a tarball generation issue, includes a description of the
>> >>> 'whoami' CLI command, and incorporates a contribution to ZooInspector.
>> >>>
>> >>> ZooKeeper 3.7.0 introduces a number of new features, notably:
>> >>>
>> >>>  * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
>> >>>
>> >>>  * Quota enforcement (ZOOKEEPER-3301);
>> >>>
>> >>>  * Host name canonicalization in quorum SASL authentication
>> >>> (ZOOKEEPER-4030);
>> >>>
>> >>>  * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
>> >>>
>> >>>  * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);
>> >>>
>> >>>  * A "whoami" API and CLI command (ZOOKEEPER-3969);
>> >>>
>> >>>  * The possibility of disabling digest authentication (ZOOKEEPER-3979);
>> >>>
>> >>>  * Multiple SASL "superUsers" (ZOOKEEPER-3959);
>> >>>
>> >>>  * Fast-tracking of throttled requests (ZOOKEEPER-3683);
>> >>>
>> >>>  * Additional security metrics (ZOOKEEPER-3978);
>> >>>
>> >>>  * SASL support in the C and Perl clients (ZOOKEEPER-1112,
>> >>> ZOOKEEPER-3714);
>> >>>
>> >>>  * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
>> >>>
>> >>>  * Notes on how to benchmark ZooKeeper with the YCSB tool
>> >>> (ZOOKEEPER-3264).
>> >>>
>> >>> The release notes are available here:
>> >>>
>> >>>
>> >>>
>> >>
>> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/website/releasenotes.html
>> >>>
>> >>>
>> >>
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346617
>> >>>
>> >>> *** Please download, test and vote by January 31st 2020, 23:59 UTC+0.
>> ***
>> >>>
>> >>> Source files:
>> >>>
>> >>>  https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/
>> >>>
>> >>> Maven staging repo:
>> >>>
>> >>>
>> >>>
>> >>
>> https://repository.apache.org/content/repositories/orgapachezookeeper-1066/
>> >>>
>> >>> The release candidate tag in git to be voted upon: release-3.7.0-1
>> >>>
>> >>>  https://github.com/apache/zookeeper/tree/release-3.7.0-1
>> >>>
>> >>> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
>> >>>
>> >>>  https://www.apache.org/dist/zookeeper/KEYS
>> >>>
>> >>> The staging version of the website is:
>> >>>
>> >>>
>> >>>
>> >>
>> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/website/
>> >>>
>> >>> Should we release this candidate?
>> >>>
>> >>> Damien Diederen
>> >>>
>> >>
>>
>>

Re: Test failures on 3.7.0 RC1 (was: Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 1)

Posted by Szalay-Bekő Máté <sz...@gmail.com>.
 this is not specific to 3.7, but in general:
from time to time I see different tests failing intermittently. I assume
this can be caused by other tests running in parallel. (because re-running
those tests alone usually makes them succeed)
So I prefer to execute the java unit tests using the following command when
checking RCs:

mvn test -Dsurefire.rerunFailingTestsCount=3 -fae -Pfull-build -DforkCount=1

As far as I remember, by default the fork count is set to 8 in maven, and
the CI is using (or was using before the migration) -DforkCount=4.


Regards,
Mate

On Mon, Jan 25, 2021 at 1:51 PM Flavio Junqueira <fp...@apache.org> wrote:

> I don't want to mess up with the vote thread, so I'm responding to this
> separately. I have been trying to build locally too unsuccessfully. I've
> been trying on an Ubuntu VM, Java 8 (build 1.8.0_181-b13), Maven 3.6.0. The
> set of tests failing varies from build to build, if it makes sense, I can
> try to collect all test failures I have seen and post.
>
> -Flavio
>
> > On 25 Jan 2021, at 13:38, Szalay-Bekő Máté <sz...@gmail.com>
> wrote:
> >
> > +0 (and not even binding :) )
> >
> > - I built the source code (-Pfull-build) on Ubuntu 18.04.3 using OpenJDK
> > 8u265 and maven 3.6.3.
> > - I also built and executed unit tests for zkpython
> > - the unit tests passed for the C-client and for python client
> > - checkstyle and spotbugs passed
> > - apache-rat passed
> > - owasp (CVE check) passed
> > - fatjar built (-Pfatjar)
> > - I executed a quick rolling-upgrade test from 3.5.9 and from 3.6.2.
> (using
> > https://github.com/symat/zk-rolling-upgrade-test)
> >
> > for some reason the java unit tests failed for me.
> >
> > On mac (jdk 1.8.212 and maven 3.6.3), I got all the unit tests executed
> > successfully, but then the maven job still failed for hbase-server test
> > with error message (with -DforkCount=4 and even with -DforkCount=1) like:
> > -------------
> > [ERROR] ExecutionException There was an error in the forked process
> > [ERROR] unable to create new native thread
> > [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException:
> > ExecutionException There was an error in the forked process
> > [ERROR] unable to create new native thread
> > [ERROR] at
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:510)
> > -------------
> >
> >
> > Then I tried on a dockerized environment (ubuntu 18.4, OpenJDK 8u265 and
> > maven 3.6.3) and I got other kinds of strange maven errors:
> > -------------------
> > [ERROR] Caused by:
> > org.apache.maven.surefire.booter.SurefireBooterForkException: The forked
> VM
> > terminated without properly saying goodbye. VM crash or System.exit
> called?
> > [ERROR] Command was /bin/sh -c cd
> > /tmp/zk/apache-zookeeper-3.7.0/zookeeper-server &&
> > /home/symat/.sdkman/candidates/java/8.0.265-open/jre/bin/java -Xmx512m
> > -Dtest.junit.threads=8 -Dzookeeper.junit.threadid=3
> >
> -javaagent:/home/symat/.m2/repository/org/jmockit/jmockit/1.48/jmockit-1.48.jar
> > -jar
> >
> /tmp/zk/apache-zookeeper-3.7.0/zookeeper-server/target/surefire/surefirebooter8828313385463488429.jar
> > /tmp/zk/apache-zookeeper-3.7.0/zookeeper-server/target/surefire
> > 2021-01-25T11-54-03_621-jvmRun3 surefire4024538135165099286tmp
> > surefire_37800399112966511000tmp
> > [ERROR] Process Exit Code: 0
> > [ERROR]         at
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:669)
> > [ERROR]         at
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.access$600(ForkStarter.java:115)
> > [ERROR]         at
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter$2.call(ForkStarter.java:444)
> > [ERROR]         at
> >
> org.apache.maven.plugin.surefire.booterclient.ForkStarter$2.call(ForkStarter.java:420)
> > [ERROR]         at
> java.util.concurrent.FutureTask.run(FutureTask.java:266)
> > [ERROR]         at
> >
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> > [ERROR]         at
> >
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> > [ERROR]         at java.lang.Thread.run(Thread.java:748)
> > [ERROR]
> > --------------------------------------
> >
> >
> > These issues might be very well specific to my local (mac or docker on
> mac)
> > environments. This is why I didn't vote with -1
> > Can someone else run the java unit tests successfully locally?
> >
> > I also tried to check if the CI was green for the last PR on 3.7.0 (
> > https://github.com/apache/zookeeper/pull/1586/checks), but it looks the
> CI
> > haven't even started to execute the tests, due to errors in the "install
> C
> > dependencies" step.
> >
> > Regards,
> > Mate
> >
> > On Sun, Jan 24, 2021 at 11:39 PM Patrick Hunt <ph...@apache.org> wrote:
> >
> >> +1. xsum/sig verified. rat ran clean. built and dependency checks are
> fine.
> >> Tried running some manual clusters and it was successful.
> >>
> >> Regards,
> >>
> >> Patrick
> >>
> >>
> >> On Sun, Jan 24, 2021 at 12:11 PM Damien Diederen <dd...@apache.org>
> >> wrote:
> >>
> >>>
> >>> Dear all,
> >>>
> >>> This is a second release candidate for ZooKeeper 3.7.0.  Compared to
> >>> RC0, it fixes a tarball generation issue, includes a description of the
> >>> 'whoami' CLI command, and incorporates a contribution to ZooInspector.
> >>>
> >>> ZooKeeper 3.7.0 introduces a number of new features, notably:
> >>>
> >>>  * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
> >>>
> >>>  * Quota enforcement (ZOOKEEPER-3301);
> >>>
> >>>  * Host name canonicalization in quorum SASL authentication
> >>> (ZOOKEEPER-4030);
> >>>
> >>>  * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
> >>>
> >>>  * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);
> >>>
> >>>  * A "whoami" API and CLI command (ZOOKEEPER-3969);
> >>>
> >>>  * The possibility of disabling digest authentication (ZOOKEEPER-3979);
> >>>
> >>>  * Multiple SASL "superUsers" (ZOOKEEPER-3959);
> >>>
> >>>  * Fast-tracking of throttled requests (ZOOKEEPER-3683);
> >>>
> >>>  * Additional security metrics (ZOOKEEPER-3978);
> >>>
> >>>  * SASL support in the C and Perl clients (ZOOKEEPER-1112,
> >>> ZOOKEEPER-3714);
> >>>
> >>>  * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
> >>>
> >>>  * Notes on how to benchmark ZooKeeper with the YCSB tool
> >>> (ZOOKEEPER-3264).
> >>>
> >>> The release notes are available here:
> >>>
> >>>
> >>>
> >>
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/website/releasenotes.html
> >>>
> >>>
> >>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346617
> >>>
> >>> *** Please download, test and vote by January 31st 2020, 23:59 UTC+0.
> ***
> >>>
> >>> Source files:
> >>>
> >>>  https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/
> >>>
> >>> Maven staging repo:
> >>>
> >>>
> >>>
> >>
> https://repository.apache.org/content/repositories/orgapachezookeeper-1066/
> >>>
> >>> The release candidate tag in git to be voted upon: release-3.7.0-1
> >>>
> >>>  https://github.com/apache/zookeeper/tree/release-3.7.0-1
> >>>
> >>> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> >>>
> >>>  https://www.apache.org/dist/zookeeper/KEYS
> >>>
> >>> The staging version of the website is:
> >>>
> >>>
> >>>
> >>
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/website/
> >>>
> >>> Should we release this candidate?
> >>>
> >>> Damien Diederen
> >>>
> >>
>
>

Test failures on 3.7.0 RC1 (was: Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 1)

Posted by Flavio Junqueira <fp...@apache.org>.
I don't want to mess up with the vote thread, so I'm responding to this separately. I have been trying to build locally too unsuccessfully. I've been trying on an Ubuntu VM, Java 8 (build 1.8.0_181-b13), Maven 3.6.0. The set of tests failing varies from build to build, if it makes sense, I can try to collect all test failures I have seen and post.

-Flavio

> On 25 Jan 2021, at 13:38, Szalay-Bekő Máté <sz...@gmail.com> wrote:
> 
> +0 (and not even binding :) )
> 
> - I built the source code (-Pfull-build) on Ubuntu 18.04.3 using OpenJDK
> 8u265 and maven 3.6.3.
> - I also built and executed unit tests for zkpython
> - the unit tests passed for the C-client and for python client
> - checkstyle and spotbugs passed
> - apache-rat passed
> - owasp (CVE check) passed
> - fatjar built (-Pfatjar)
> - I executed a quick rolling-upgrade test from 3.5.9 and from 3.6.2. (using
> https://github.com/symat/zk-rolling-upgrade-test)
> 
> for some reason the java unit tests failed for me.
> 
> On mac (jdk 1.8.212 and maven 3.6.3), I got all the unit tests executed
> successfully, but then the maven job still failed for hbase-server test
> with error message (with -DforkCount=4 and even with -DforkCount=1) like:
> -------------
> [ERROR] ExecutionException There was an error in the forked process
> [ERROR] unable to create new native thread
> [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException:
> ExecutionException There was an error in the forked process
> [ERROR] unable to create new native thread
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:510)
> -------------
> 
> 
> Then I tried on a dockerized environment (ubuntu 18.4, OpenJDK 8u265 and
> maven 3.6.3) and I got other kinds of strange maven errors:
> -------------------
> [ERROR] Caused by:
> org.apache.maven.surefire.booter.SurefireBooterForkException: The forked VM
> terminated without properly saying goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd
> /tmp/zk/apache-zookeeper-3.7.0/zookeeper-server &&
> /home/symat/.sdkman/candidates/java/8.0.265-open/jre/bin/java -Xmx512m
> -Dtest.junit.threads=8 -Dzookeeper.junit.threadid=3
> -javaagent:/home/symat/.m2/repository/org/jmockit/jmockit/1.48/jmockit-1.48.jar
> -jar
> /tmp/zk/apache-zookeeper-3.7.0/zookeeper-server/target/surefire/surefirebooter8828313385463488429.jar
> /tmp/zk/apache-zookeeper-3.7.0/zookeeper-server/target/surefire
> 2021-01-25T11-54-03_621-jvmRun3 surefire4024538135165099286tmp
> surefire_37800399112966511000tmp
> [ERROR] Process Exit Code: 0
> [ERROR]         at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:669)
> [ERROR]         at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.access$600(ForkStarter.java:115)
> [ERROR]         at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter$2.call(ForkStarter.java:444)
> [ERROR]         at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter$2.call(ForkStarter.java:420)
> [ERROR]         at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> [ERROR]         at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> [ERROR]         at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [ERROR]         at java.lang.Thread.run(Thread.java:748)
> [ERROR]
> --------------------------------------
> 
> 
> These issues might be very well specific to my local (mac or docker on mac)
> environments. This is why I didn't vote with -1
> Can someone else run the java unit tests successfully locally?
> 
> I also tried to check if the CI was green for the last PR on 3.7.0 (
> https://github.com/apache/zookeeper/pull/1586/checks), but it looks the CI
> haven't even started to execute the tests, due to errors in the "install C
> dependencies" step.
> 
> Regards,
> Mate
> 
> On Sun, Jan 24, 2021 at 11:39 PM Patrick Hunt <ph...@apache.org> wrote:
> 
>> +1. xsum/sig verified. rat ran clean. built and dependency checks are fine.
>> Tried running some manual clusters and it was successful.
>> 
>> Regards,
>> 
>> Patrick
>> 
>> 
>> On Sun, Jan 24, 2021 at 12:11 PM Damien Diederen <dd...@apache.org>
>> wrote:
>> 
>>> 
>>> Dear all,
>>> 
>>> This is a second release candidate for ZooKeeper 3.7.0.  Compared to
>>> RC0, it fixes a tarball generation issue, includes a description of the
>>> 'whoami' CLI command, and incorporates a contribution to ZooInspector.
>>> 
>>> ZooKeeper 3.7.0 introduces a number of new features, notably:
>>> 
>>>  * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
>>> 
>>>  * Quota enforcement (ZOOKEEPER-3301);
>>> 
>>>  * Host name canonicalization in quorum SASL authentication
>>> (ZOOKEEPER-4030);
>>> 
>>>  * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
>>> 
>>>  * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);
>>> 
>>>  * A "whoami" API and CLI command (ZOOKEEPER-3969);
>>> 
>>>  * The possibility of disabling digest authentication (ZOOKEEPER-3979);
>>> 
>>>  * Multiple SASL "superUsers" (ZOOKEEPER-3959);
>>> 
>>>  * Fast-tracking of throttled requests (ZOOKEEPER-3683);
>>> 
>>>  * Additional security metrics (ZOOKEEPER-3978);
>>> 
>>>  * SASL support in the C and Perl clients (ZOOKEEPER-1112,
>>> ZOOKEEPER-3714);
>>> 
>>>  * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
>>> 
>>>  * Notes on how to benchmark ZooKeeper with the YCSB tool
>>> (ZOOKEEPER-3264).
>>> 
>>> The release notes are available here:
>>> 
>>> 
>>> 
>> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/website/releasenotes.html
>>> 
>>> 
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346617
>>> 
>>> *** Please download, test and vote by January 31st 2020, 23:59 UTC+0. ***
>>> 
>>> Source files:
>>> 
>>>  https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/
>>> 
>>> Maven staging repo:
>>> 
>>> 
>>> 
>> https://repository.apache.org/content/repositories/orgapachezookeeper-1066/
>>> 
>>> The release candidate tag in git to be voted upon: release-3.7.0-1
>>> 
>>>  https://github.com/apache/zookeeper/tree/release-3.7.0-1
>>> 
>>> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
>>> 
>>>  https://www.apache.org/dist/zookeeper/KEYS
>>> 
>>> The staging version of the website is:
>>> 
>>> 
>>> 
>> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/website/
>>> 
>>> Should we release this candidate?
>>> 
>>> Damien Diederen
>>> 
>> 


Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 1

Posted by Szalay-Bekő Máté <sz...@gmail.com>.
+0 (and not even binding :) )

- I built the source code (-Pfull-build) on Ubuntu 18.04.3 using OpenJDK
8u265 and maven 3.6.3.
- I also built and executed unit tests for zkpython
- the unit tests passed for the C-client and for python client
- checkstyle and spotbugs passed
- apache-rat passed
- owasp (CVE check) passed
- fatjar built (-Pfatjar)
- I executed a quick rolling-upgrade test from 3.5.9 and from 3.6.2. (using
https://github.com/symat/zk-rolling-upgrade-test)

for some reason the java unit tests failed for me.

On mac (jdk 1.8.212 and maven 3.6.3), I got all the unit tests executed
successfully, but then the maven job still failed for hbase-server test
with error message (with -DforkCount=4 and even with -DforkCount=1) like:
-------------
[ERROR] ExecutionException There was an error in the forked process
[ERROR] unable to create new native thread
[ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException:
ExecutionException There was an error in the forked process
[ERROR] unable to create new native thread
[ERROR] at
org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:510)
-------------


Then I tried on a dockerized environment (ubuntu 18.4, OpenJDK 8u265 and
maven 3.6.3) and I got other kinds of strange maven errors:
-------------------
[ERROR] Caused by:
org.apache.maven.surefire.booter.SurefireBooterForkException: The forked VM
terminated without properly saying goodbye. VM crash or System.exit called?
[ERROR] Command was /bin/sh -c cd
/tmp/zk/apache-zookeeper-3.7.0/zookeeper-server &&
/home/symat/.sdkman/candidates/java/8.0.265-open/jre/bin/java -Xmx512m
-Dtest.junit.threads=8 -Dzookeeper.junit.threadid=3
-javaagent:/home/symat/.m2/repository/org/jmockit/jmockit/1.48/jmockit-1.48.jar
-jar
/tmp/zk/apache-zookeeper-3.7.0/zookeeper-server/target/surefire/surefirebooter8828313385463488429.jar
/tmp/zk/apache-zookeeper-3.7.0/zookeeper-server/target/surefire
2021-01-25T11-54-03_621-jvmRun3 surefire4024538135165099286tmp
surefire_37800399112966511000tmp
[ERROR] Process Exit Code: 0
[ERROR]         at
org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:669)
[ERROR]         at
org.apache.maven.plugin.surefire.booterclient.ForkStarter.access$600(ForkStarter.java:115)
[ERROR]         at
org.apache.maven.plugin.surefire.booterclient.ForkStarter$2.call(ForkStarter.java:444)
[ERROR]         at
org.apache.maven.plugin.surefire.booterclient.ForkStarter$2.call(ForkStarter.java:420)
[ERROR]         at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[ERROR]         at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[ERROR]         at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[ERROR]         at java.lang.Thread.run(Thread.java:748)
[ERROR]
--------------------------------------


These issues might be very well specific to my local (mac or docker on mac)
environments. This is why I didn't vote with -1
Can someone else run the java unit tests successfully locally?

I also tried to check if the CI was green for the last PR on 3.7.0 (
https://github.com/apache/zookeeper/pull/1586/checks), but it looks the CI
haven't even started to execute the tests, due to errors in the "install C
dependencies" step.

Regards,
Mate

On Sun, Jan 24, 2021 at 11:39 PM Patrick Hunt <ph...@apache.org> wrote:

> +1. xsum/sig verified. rat ran clean. built and dependency checks are fine.
> Tried running some manual clusters and it was successful.
>
> Regards,
>
> Patrick
>
>
> On Sun, Jan 24, 2021 at 12:11 PM Damien Diederen <dd...@apache.org>
> wrote:
>
> >
> > Dear all,
> >
> > This is a second release candidate for ZooKeeper 3.7.0.  Compared to
> > RC0, it fixes a tarball generation issue, includes a description of the
> > 'whoami' CLI command, and incorporates a contribution to ZooInspector.
> >
> > ZooKeeper 3.7.0 introduces a number of new features, notably:
> >
> >   * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
> >
> >   * Quota enforcement (ZOOKEEPER-3301);
> >
> >   * Host name canonicalization in quorum SASL authentication
> > (ZOOKEEPER-4030);
> >
> >   * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
> >
> >   * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);
> >
> >   * A "whoami" API and CLI command (ZOOKEEPER-3969);
> >
> >   * The possibility of disabling digest authentication (ZOOKEEPER-3979);
> >
> >   * Multiple SASL "superUsers" (ZOOKEEPER-3959);
> >
> >   * Fast-tracking of throttled requests (ZOOKEEPER-3683);
> >
> >   * Additional security metrics (ZOOKEEPER-3978);
> >
> >   * SASL support in the C and Perl clients (ZOOKEEPER-1112,
> > ZOOKEEPER-3714);
> >
> >   * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
> >
> >   * Notes on how to benchmark ZooKeeper with the YCSB tool
> > (ZOOKEEPER-3264).
> >
> > The release notes are available here:
> >
> >
> >
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/website/releasenotes.html
> >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346617
> >
> > *** Please download, test and vote by January 31st 2020, 23:59 UTC+0. ***
> >
> > Source files:
> >
> >   https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/
> >
> > Maven staging repo:
> >
> >
> >
> https://repository.apache.org/content/repositories/orgapachezookeeper-1066/
> >
> > The release candidate tag in git to be voted upon: release-3.7.0-1
> >
> >   https://github.com/apache/zookeeper/tree/release-3.7.0-1
> >
> > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> >
> >   https://www.apache.org/dist/zookeeper/KEYS
> >
> > The staging version of the website is:
> >
> >
> >
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/website/
> >
> > Should we release this candidate?
> >
> > Damien Diederen
> >
>

Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 1

Posted by Patrick Hunt <ph...@apache.org>.
+1. xsum/sig verified. rat ran clean. built and dependency checks are fine.
Tried running some manual clusters and it was successful.

Regards,

Patrick


On Sun, Jan 24, 2021 at 12:11 PM Damien Diederen <dd...@apache.org>
wrote:

>
> Dear all,
>
> This is a second release candidate for ZooKeeper 3.7.0.  Compared to
> RC0, it fixes a tarball generation issue, includes a description of the
> 'whoami' CLI command, and incorporates a contribution to ZooInspector.
>
> ZooKeeper 3.7.0 introduces a number of new features, notably:
>
>   * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
>
>   * Quota enforcement (ZOOKEEPER-3301);
>
>   * Host name canonicalization in quorum SASL authentication
> (ZOOKEEPER-4030);
>
>   * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
>
>   * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);
>
>   * A "whoami" API and CLI command (ZOOKEEPER-3969);
>
>   * The possibility of disabling digest authentication (ZOOKEEPER-3979);
>
>   * Multiple SASL "superUsers" (ZOOKEEPER-3959);
>
>   * Fast-tracking of throttled requests (ZOOKEEPER-3683);
>
>   * Additional security metrics (ZOOKEEPER-3978);
>
>   * SASL support in the C and Perl clients (ZOOKEEPER-1112,
> ZOOKEEPER-3714);
>
>   * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
>
>   * Notes on how to benchmark ZooKeeper with the YCSB tool
> (ZOOKEEPER-3264).
>
> The release notes are available here:
>
>
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/website/releasenotes.html
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346617
>
> *** Please download, test and vote by January 31st 2020, 23:59 UTC+0. ***
>
> Source files:
>
>   https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/
>
> Maven staging repo:
>
>
> https://repository.apache.org/content/repositories/orgapachezookeeper-1066/
>
> The release candidate tag in git to be voted upon: release-3.7.0-1
>
>   https://github.com/apache/zookeeper/tree/release-3.7.0-1
>
> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
>
>   https://www.apache.org/dist/zookeeper/KEYS
>
> The staging version of the website is:
>
>
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/website/
>
> Should we release this candidate?
>
> Damien Diederen
>

[CANCELLED] [VOTE] Apache ZooKeeper release 3.7.0 candidate 1

Posted by Damien Diederen <dd...@apache.org>.
Greetings, all,

Unsurprisingly, I am canceling this vote and second release candidate
given the severity of the trouble brewing in Macland.

Let's see if we can get the tree in a better shape.  (I am able to
reproduce, and am planning to look into it—but contributions are
certainly welcome!)

Best, -D



Damien Diederen <dd...@apache.org> writes:
> Dear all,
>
> This is a second release candidate for ZooKeeper 3.7.0.  Compared to
> RC0, it fixes a tarball generation issue, includes a description of the
> 'whoami' CLI command, and incorporates a contribution to ZooInspector.
>
> ZooKeeper 3.7.0 introduces a number of new features, notably:
>
>   * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
>   
>   * Quota enforcement (ZOOKEEPER-3301);
>   
>   * Host name canonicalization in quorum SASL authentication (ZOOKEEPER-4030);
>
>   * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
>
>   * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);
>
>   * A "whoami" API and CLI command (ZOOKEEPER-3969);
>
>   * The possibility of disabling digest authentication (ZOOKEEPER-3979);
>   
>   * Multiple SASL "superUsers" (ZOOKEEPER-3959);
>   
>   * Fast-tracking of throttled requests (ZOOKEEPER-3683);
>     
>   * Additional security metrics (ZOOKEEPER-3978);
>
>   * SASL support in the C and Perl clients (ZOOKEEPER-1112, ZOOKEEPER-3714);
>
>   * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
>
>   * Notes on how to benchmark ZooKeeper with the YCSB tool (ZOOKEEPER-3264).
>
> The release notes are available here:
>   
>   https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/website/releasenotes.html
>   https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346617
>
> *** Please download, test and vote by January 31st 2020, 23:59 UTC+0. ***
>
> Source files:
>
>   https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/
>
> Maven staging repo:
>
>   https://repository.apache.org/content/repositories/orgapachezookeeper-1066/
>
> The release candidate tag in git to be voted upon: release-3.7.0-1
>
>   https://github.com/apache/zookeeper/tree/release-3.7.0-1
>
> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
>
>   https://www.apache.org/dist/zookeeper/KEYS
>
> The staging version of the website is:
>
>   https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/website/
>
> Should we release this candidate?
>
> Damien Diederen

Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 2

Posted by Rakesh Radhakrishnan <ra...@apache.org>.
+1 (binding)


- built ZooKeeper jar from source

- setup 3 node ZK cluster and tested a few cases(HDFS-HA failover and java
zkClient ops), exec basic CLI commands, checked jmx beans and all looks
fine to me.

- verified sig/xsum.


Thanks Damien and others who have worked on making this release happen!


Rakesh

On Wed, Mar 17, 2021 at 4:36 PM Damien Diederen <dd...@apache.org>
wrote:

>
> Greetings, all!
>
> After a long delay, here is a third release candidate for ZooKeeper 3.7.0.
>
> Compared to RC1, it contains... quite a few changes.  It notably fixes
> the quota feature for multi transactions, repairs the test suite on
> macOS (Catalina), makes a few tests less flaky, and avoids a CVE.
>
> The complete set of changes can be obtained with the Git range
> expression 'release-3.7.0-1..release-3.7.0-2', or on GitHub at:
>
>
> https://github.com/apache/zookeeper/compare/release-3.7.0-1...release-3.7.0-2
>
> I cannot say that I find the state of the test suite satisfactory, but
> the failures which are often observed are due to timing and/or TCP/IP
> port assignment issues, and repeated runs are "sufficient" to clear
> them.
>
> I was hoping to contribute more on that front, but have been unable so
> far, and don't want to keep the 3.7 branch hostage—so here is a timid
> RC2.
>
>
> ZooKeeper 3.7.0 introduces a number of new features, notably:
>
>   * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
>
>   * Quota enforcement (ZOOKEEPER-3301);
>
>   * Host name canonicalization in quorum SASL authentication
> (ZOOKEEPER-4030);
>
>   * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
>
>   * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);
>
>   * A "whoami" API and CLI command (ZOOKEEPER-3969);
>
>   * The possibility of disabling digest authentication (ZOOKEEPER-3979);
>
>   * Multiple SASL "superUsers" (ZOOKEEPER-3959);
>
>   * Fast-tracking of throttled requests (ZOOKEEPER-3683);
>
>   * Additional security metrics (ZOOKEEPER-3978);
>
>   * SASL support in the C and Perl clients (ZOOKEEPER-1112,
> ZOOKEEPER-3714);
>
>   * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
>
>   * Notes on how to benchmark ZooKeeper with the YCSB tool
> (ZOOKEEPER-3264).
>
>
> The release notes are available here:
>
>
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/website/releasenotes.html
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346617
>
> *** Please download, test and vote by March 21st 2021, 23:59 UTC+0. ***
>
> Source files:
>
>   https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/
>
> Maven staging repo:
>
>
> https://repository.apache.org/content/repositories/orgapachezookeeper-1067/
>
> The release candidate tag in git to be voted upon: release-3.7.0-2
>
>   https://github.com/apache/zookeeper/tree/release-3.7.0-2
>
> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
>
>   https://www.apache.org/dist/zookeeper/KEYS
>
> The staging version of the website is:
>
>
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/website/
>
>
> Should we release this candidate?
>
>
> Damien Diederen
>

Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 2

Posted by Damien Diederen <dd...@apache.org>.
Hi Ted,

Thank you for the confirmation.  NFS 'rm -rf's often stumble on such
dotfiles, indeed.  It would be intesting to investigate which files are
being kept open, and why—but I'm not going to consider this a blocker
for 3.7.0.  (And yes, it would be interesting to see how that FUSE-based
FS would handle that same issue.)

Your report (rightly) stated "That doesn't look good," but did not
contain an explicit -1.  Given the situation and analysis, I am
consequently not going to count it as a "disapproving vote."

Thank you,
Damien Diederen



Ted Dunning <te...@gmail.com> writes:
> Damien,
>
> Great analysis. I am running on an NFS mount.
>
> I can move to native disk, but I may try switching to a FUSE mount. The
> issue is likely that the directory is being deleted while there is an open
> file. When that happens, NFS converts that file into a file whose name
> starts with "." which can cause rmdir to subsequently fail. We have fixed
> that problem on the FUSE mounted version of the file system.
>
>
>
> On Thu, Mar 25, 2021 at 1:55 AM Damien Diederen <dd...@apache.org>
> wrote:
>
>>
>> Hi Ted, all,
>>
>> Thank you for testing.  You reported:
>>
>> >> I had these test failures. That doesn't look good.
>> […]
>> >
>> > Repeated tests. Similar, but not identical failures.
>> […]
>>
>> I agree that it doesn't look good, but am also unsurprised.  This is
>> precisely why I included this text in my call for vote:
>>
>> >>> I cannot say that I find the state of the test suite satisfactory, but
>> >>> the failures which are often observed are due to timing and/or TCP/IP
>> >>> port assignment issues, and repeated runs are "sufficient" to clear
>> >>> them.
>> >>>
>> >>> I was hoping to contribute more on that front, but have been unable so
>> >>> far, and don't want to keep the 3.7 branch hostage—so here is a timid
>> >>> RC2.
>>
>>
>> We currently have a number of tests which are very flaky unless they are
>> being run on hardware which is both powerful and dedicated.
>>
>> This happens for a number of reasons, including hardcoded deadlines and
>> TCP/IP port allocation races.
>>
>> There has been some work on fixing this, notably by Justin Ling Mao and
>> Mohammad Arshad.  I have also contributed, and intend to do more—but the
>> past weeks have conspired against it.  This is a slope we have to climb,
>> and I'm afraid it will take some time.
>>
>> My understanding is that test suites failures were not supposed to delay
>> 3.7.0 as long as they were 1/ sporadic and 2/ understood.  It is very
>> unfortunate that the extent of the problem was not discovered before the
>> 3.7 fork point, as it has kept us in limbo for a while!
>>
>>
>> Note that an additional factor is that 'pom.xml' contains the following:
>>
>>     <surefire-forkcount>8</surefire-forkcount>
>>
>> which isn't very good as a default given the current situation.  In
>> fact, both CI suites override it, the Jenkins one with:
>>
>>     -Dsurefire-forkcount=4
>>
>> and GitHub CI with:
>>
>>     -Dsurefire-forkcount=1 -Dsurefire.rerunFailingTestsCount=5
>>
>>
>> >> [*ERROR*] *  RequestThrottlerTest.testRequestThrottler:198 expected: <1>
>> >> but was: <0>*
>>
>> This test is a known offender, and is on my list of items to investigate.
>>
>> I highly suspect the 5s timeout is the culprit; it should probably be
>> bumped up by some margin (and STALL_TIME be correspondingly adjusted):
>>
>>     // make sure the server received all 5 requests
>>     submitted.await(5, TimeUnit.SECONDS);
>>     Map<String, Object> metrics = MetricsUtils.currentServerMetrics();
>>
>>     // but only two requests can get into the pipeline because of the
>> throttler
>>     assertEquals(2L, (long) metrics.get("prep_processor_request_queued"));
>>     assertEquals(1L, (long) metrics.get("request_throttle_wait_count"));
>>
>>
>> https://github.com/apache/zookeeper/blob/release-3.7.0-2/zookeeper-server/src/test/java/org/apache/zookeeper/server/RequestThrottlerTest.java#L192-L198
>>
>>
>> >> [*ERROR*] *
>> LoadFromLogTest>ClientBase.tearDown:590->ClientBase.recursiveDelete:625
>> file
>> '/mapr/c0/user/tdunning/zookeeper-release-3.7.0-2/zookeeper-server/target/surefire/test3407191642699245455.junit.dir/version-2'
>> deletion failed*
>> […]
>> >> [*ERROR*] *  TxnLogToolkitTest.tearDown:62 » IO Unable to delete
>> >> directory /mapr/c0/user/td...*
>>
>> This looks a bit more worrisome; I have never seen that failure.
>>
>> The path '/mapr/c0/...', however, hints at a "nonstandard" filesystem.
>>
>> I would expect the current test suite to trip on weird corner cases on
>> networked filesystems such as NFS, let alone something more exotic.  Can
>> you confirm that the above is not a "vanilla" filesystem?  If so, that
>> would explain the failure.
>>
>> (Not saying that aspect of the test suite should not be improved.)
>>
>>
>> If you are willing to go through the ordeal once more, I would suggest:
>>
>>   * Limiting/disabling the test suite concurrency, which is currently
>>     known to be problematic.  Perhaps with the following:
>>
>>         -Dsurefire-forkcount=1 -Dsurefire.rerunFailingTestsCount=5
>>
>>   * Running it on top of a POSIX/local filesystem;
>>
>>
>> What do you think?
>>
>> Cheers, -D
>>
>>
>>
>> Ted Dunning <te...@gmail.com> writes:
>> > Repeated tests. Similar, but not identical failures.
>> >
>> >
>> >
>> > On Wed, Mar 24, 2021 at 4:09 PM Ted Dunning <te...@gmail.com>
>> wrote:
>> >
>> >>
>> >> I had these test failures. That doesn't look good.
>> >>
>> >> I haven't been keeping track, however, and am not sure that they are
>> >> problems:
>> >>
>> >> [*ERROR*] *Failures: *
>> >>
>> >> [*ERROR*] *  RequestThrottlerTest.testRequestThrottler:198 expected: <1>
>> >> but was: <0>*
>> >>
>> >> [*ERROR*] *
>> >> LoadFromLogTest>ClientBase.tearDown:590->ClientBase.recursiveDelete:625
>> >> file
>> >>
>> '/mapr/c0/user/tdunning/zookeeper-release-3.7.0-2/zookeeper-server/target/surefire/test3407191642699245455.junit.dir/version-2'
>> >> deletion failed*
>> >>
>> >> [*ERROR*] *Errors: *
>> >>
>> >> [*ERROR*] *  TxnLogToolkitTest.tearDown:62 » IO Unable to delete
>> >> directory /mapr/c0/user/td...*
>> >>
>> >> [*ERROR*] *  TxnLogToolkitTest.tearDown:62 » IO Unable to delete
>> >> directory /mapr/c0/user/td...*
>> >>
>> >> [*ERROR*] *  TxnLogToolkitTest.tearDown:62 » IO Unable to delete
>> >> directory /mapr/c0/user/td...*
>> >>
>> >> [*ERROR*] *  TxnLogToolkitTest.tearDown:62 » IO Unable to delete
>> >> directory /mapr/c0/user/td...*
>> >>
>> >> [*INFO*]
>> >>
>> >> [*ERROR*] *Tests run: 2907, Failures: 2, Errors: 4, Skipped: 4*
>> >>
>> >>
>> >> Software info:
>> >>
>> >> Downloaded 3.7.0-2 from github in tar.gz form
>> >>
>> >> Platform info:
>> >>
>> >> Linux nodeb 5.4.0-65-generic #73~18.04.1-Ubuntu SMP Tue Jan 19 09:02:24
>> >> UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
>> >>
>> >>
>> >> 32GB RAM, modest number of cores
>> >>
>> >>
>> >>
>> >>
>> >> On Wed, Mar 24, 2021 at 3:10 PM Ted Dunning <te...@gmail.com>
>> wrote:
>> >>
>> >>>
>> >>> I am starting tests now.
>> >>>
>> >>> I had an issue (self-inflicted) when I tried to run two tests at the
>> same
>> >>> time.
>> >>>
>> >>>
>> >>>
>> >>> On Wed, Mar 24, 2021 at 1:22 PM Damien Diederen <dd...@apache.org>
>> >>> wrote:
>> >>>
>> >>>>
>> >>>> Dear all,
>> >>>>
>> >>>> Thank you for the reviews and testing.
>> >>>>
>> >>>> Glad that we have not met yet another snag so far!
>> >>>>
>> >>>> I have counted 5 approving votes, 2 of which are binding.  (The mail
>> >>>> archives seem to agree.)  As per the process, I am waiting for a 3rd
>> >>>> binding vote before starting the release process.
>> >>>>
>> >>>> Feel free to prod your PMC friends ;)
>> >>>>
>> >>>> Cheers, -D
>> >>>>
>> >>>>
>> >>>>
>> >>>> Enrico Olivelli <eo...@gmail.com> writes:
>> >>>> > +1 (binding)
>> >>>> > - Build and run tests on Ubuntu (Java and C client) on jdk8
>> >>>> > - verified rat,signatures,sha512sum,checkstyle and spotbugs (on
>> JDK8)
>> >>>> > - This time (for the first time!) I was able to build the C client
>> on
>> >>>> > MacOs (BigSur) !
>> >>>> > - verified the list of License files in the binary tarball
>> >>>> >
>> >>>> > great work Damien
>> >>>> >
>> >>>> > Enrico
>> >>>> >
>> >>>> > Il giorno lun 22 mar 2021 alle ore 12:37 Mohammad arshad
>> >>>> > <mo...@huawei.com> ha scritto:
>> >>>> >>
>> >>>> >> +1 (non-binding)
>> >>>> >>
>> >>>> >> Verified signature and checksum of release artifacts, all are ok
>> >>>> >> Run Junit test cases with jdk1.8.0_232, total 2951 test cases, 4
>> >>>> >> skipped, rest all passed
>> >>>> >> Built tarball from source code, installed 3 node cluster and
>> >>>> >> verified basic functionalities from API, executed few cli
>> >>>> >> commands. No issues observed
>> >>>> >> Connected HBase, HDFS and Yarn clusters (all using zk 3.5.6) to zk
>> >>>> >> 3.7.0 cluster, no issues observed.
>> >>>> >>
>> >>>> >> Thanks & Regards
>> >>>> >> Arshad
>> >>>> >> -----Original Message-----
>> >>>> >> From: Patrick Hunt [mailto:phunt@apache.org]
>> >>>> >> Sent: Saturday, March 20, 2021 5:17 AM
>> >>>> >> To: DevZooKeeper <de...@zookeeper.apache.org>
>> >>>> >> Subject: Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 2
>> >>>> >>
>> >>>> >> +1 xsum/sig validate. rat ran clean and I was able to compile
>> (dep/cve
>> >>>> >> check passed) and manual verification of a few different cluster
>> >>>> >> sizes was successful.
>> >>>> >>
>> >>>> >> Regards,
>> >>>> >>
>> >>>> >> Patrick
>> >>>> >>
>> >>>> >>
>> >>>> >> On Wed, Mar 17, 2021 at 4:06 AM Damien Diederen <
>> ddiederen@apache.org
>> >>>> >
>> >>>> >> wrote:
>> >>>> >>
>> >>>> >> >
>> >>>> >> > Greetings, all!
>> >>>> >> >
>> >>>> >> > After a long delay, here is a third release candidate for
>> ZooKeeper
>> >>>> 3.7.0.
>> >>>> >> >
>> >>>> >> > Compared to RC1, it contains... quite a few changes.  It notably
>> >>>> fixes
>> >>>> >> > the quota feature for multi transactions, repairs the test suite
>> on
>> >>>> >> > macOS (Catalina), makes a few tests less flaky, and avoids a CVE.
>> >>>> >> >
>> >>>> >> > The complete set of changes can be obtained with the Git range
>> >>>> >> > expression 'release-3.7.0-1..release-3.7.0-2', or on GitHub at:
>> >>>> >> >
>> >>>> >> >
>> >>>> >> >
>> >>>>
>> https://github.com/apache/zookeeper/compare/release-3.7.0-1...release-
>> >>>> >> > 3.7.0-2
>> >>>> >> >
>> >>>> >> > I cannot say that I find the state of the test suite
>> satisfactory,
>> >>>> but
>> >>>> >> > the failures which are often observed are due to timing and/or
>> >>>> TCP/IP
>> >>>> >> > port assignment issues, and repeated runs are "sufficient" to
>> clear
>> >>>> >> > them.
>> >>>> >> >
>> >>>> >> > I was hoping to contribute more on that front, but have been
>> unable
>> >>>> so
>> >>>> >> > far, and don't want to keep the 3.7 branch hostage—so here is a
>> >>>> timid
>> >>>> >> > RC2.
>> >>>> >> >
>> >>>> >> >
>> >>>> >> > ZooKeeper 3.7.0 introduces a number of new features, notably:
>> >>>> >> >
>> >>>> >> >   * An API to start a ZooKeeper server from Java
>> (ZOOKEEPER-3874);
>> >>>> >> >
>> >>>> >> >   * Quota enforcement (ZOOKEEPER-3301);
>> >>>> >> >
>> >>>> >> >   * Host name canonicalization in quorum SASL authentication
>> >>>> >> > (ZOOKEEPER-4030);
>> >>>> >> >
>> >>>> >> >   * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
>> >>>> >> >
>> >>>> >> >   * A choice of mandatory authentication scheme(s)
>> (ZOOKEEPER-3561);
>> >>>> >> >
>> >>>> >> >   * A "whoami" API and CLI command (ZOOKEEPER-3969);
>> >>>> >> >
>> >>>> >> >   * The possibility of disabling digest authentication
>> >>>> >> > (ZOOKEEPER-3979);
>> >>>> >> >
>> >>>> >> >   * Multiple SASL "superUsers" (ZOOKEEPER-3959);
>> >>>> >> >
>> >>>> >> >   * Fast-tracking of throttled requests (ZOOKEEPER-3683);
>> >>>> >> >
>> >>>> >> >   * Additional security metrics (ZOOKEEPER-3978);
>> >>>> >> >
>> >>>> >> >   * SASL support in the C and Perl clients (ZOOKEEPER-1112,
>> >>>> >> > ZOOKEEPER-3714);
>> >>>> >> >
>> >>>> >> >   * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
>> >>>> >> >
>> >>>> >> >   * Notes on how to benchmark ZooKeeper with the YCSB tool
>> >>>> >> > (ZOOKEEPER-3264).
>> >>>> >> >
>> >>>> >> >
>> >>>> >> > The release notes are available here:
>> >>>> >> >
>> >>>> >> >
>> >>>> >> >
>> >>>>
>> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/websi
>> >>>> >> > te/releasenotes.html
>> >>>> >> >
>> >>>> >> >
>> >>>>
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310
>> >>>> >> > 801&version=12346617
>> >>>> >> >
>> >>>> >> > *** Please download, test and vote by March 21st 2021, 23:59
>> UTC+0.
>> >>>> >> > ***
>> >>>> >> >
>> >>>> >> > Source files:
>> >>>> >> >
>> >>>> >> >
>> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/
>> >>>> >> >
>> >>>> >> > Maven staging repo:
>> >>>> >> >
>> >>>> >> >
>> >>>> >> >
>> >>>>
>> https://repository.apache.org/content/repositories/orgapachezookeeper-
>> >>>> >> > 1067/
>> >>>> >> >
>> >>>> >> > The release candidate tag in git to be voted upon:
>> release-3.7.0-2
>> >>>> >> >
>> >>>> >> >   https://github.com/apache/zookeeper/tree/release-3.7.0-2
>> >>>> >> >
>> >>>> >> > ZooKeeper's KEYS file containing PGP keys we use to sign the
>> >>>> release:
>> >>>> >> >
>> >>>> >> >   https://www.apache.org/dist/zookeeper/KEYS
>> >>>> >> >
>> >>>> >> > The staging version of the website is:
>> >>>> >> >
>> >>>> >> >
>> >>>> >> >
>> >>>>
>> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/websi
>> >>>> >> > te/
>> >>>> >> >
>> >>>> >> >
>> >>>> >> > Should we release this candidate?
>> >>>> >> >
>> >>>> >> >
>> >>>> >> > Damien Diederen
>> >>>> >> >
>> >>>>
>> >>>
>>

Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 2

Posted by Ted Dunning <te...@gmail.com>.
Damien,

Great analysis. I am running on an NFS mount.

I can move to native disk, but I may try switching to a FUSE mount. The
issue is likely that the directory is being deleted while there is an open
file. When that happens, NFS converts that file into a file whose name
starts with "." which can cause rmdir to subsequently fail. We have fixed
that problem on the FUSE mounted version of the file system.



On Thu, Mar 25, 2021 at 1:55 AM Damien Diederen <dd...@apache.org>
wrote:

>
> Hi Ted, all,
>
> Thank you for testing.  You reported:
>
> >> I had these test failures. That doesn't look good.
> […]
> >
> > Repeated tests. Similar, but not identical failures.
> […]
>
> I agree that it doesn't look good, but am also unsurprised.  This is
> precisely why I included this text in my call for vote:
>
> >>> I cannot say that I find the state of the test suite satisfactory, but
> >>> the failures which are often observed are due to timing and/or TCP/IP
> >>> port assignment issues, and repeated runs are "sufficient" to clear
> >>> them.
> >>>
> >>> I was hoping to contribute more on that front, but have been unable so
> >>> far, and don't want to keep the 3.7 branch hostage—so here is a timid
> >>> RC2.
>
>
> We currently have a number of tests which are very flaky unless they are
> being run on hardware which is both powerful and dedicated.
>
> This happens for a number of reasons, including hardcoded deadlines and
> TCP/IP port allocation races.
>
> There has been some work on fixing this, notably by Justin Ling Mao and
> Mohammad Arshad.  I have also contributed, and intend to do more—but the
> past weeks have conspired against it.  This is a slope we have to climb,
> and I'm afraid it will take some time.
>
> My understanding is that test suites failures were not supposed to delay
> 3.7.0 as long as they were 1/ sporadic and 2/ understood.  It is very
> unfortunate that the extent of the problem was not discovered before the
> 3.7 fork point, as it has kept us in limbo for a while!
>
>
> Note that an additional factor is that 'pom.xml' contains the following:
>
>     <surefire-forkcount>8</surefire-forkcount>
>
> which isn't very good as a default given the current situation.  In
> fact, both CI suites override it, the Jenkins one with:
>
>     -Dsurefire-forkcount=4
>
> and GitHub CI with:
>
>     -Dsurefire-forkcount=1 -Dsurefire.rerunFailingTestsCount=5
>
>
> >> [*ERROR*] *  RequestThrottlerTest.testRequestThrottler:198 expected: <1>
> >> but was: <0>*
>
> This test is a known offender, and is on my list of items to investigate.
>
> I highly suspect the 5s timeout is the culprit; it should probably be
> bumped up by some margin (and STALL_TIME be correspondingly adjusted):
>
>     // make sure the server received all 5 requests
>     submitted.await(5, TimeUnit.SECONDS);
>     Map<String, Object> metrics = MetricsUtils.currentServerMetrics();
>
>     // but only two requests can get into the pipeline because of the
> throttler
>     assertEquals(2L, (long) metrics.get("prep_processor_request_queued"));
>     assertEquals(1L, (long) metrics.get("request_throttle_wait_count"));
>
>
> https://github.com/apache/zookeeper/blob/release-3.7.0-2/zookeeper-server/src/test/java/org/apache/zookeeper/server/RequestThrottlerTest.java#L192-L198
>
>
> >> [*ERROR*] *
> LoadFromLogTest>ClientBase.tearDown:590->ClientBase.recursiveDelete:625
> file
> '/mapr/c0/user/tdunning/zookeeper-release-3.7.0-2/zookeeper-server/target/surefire/test3407191642699245455.junit.dir/version-2'
> deletion failed*
> […]
> >> [*ERROR*] *  TxnLogToolkitTest.tearDown:62 » IO Unable to delete
> >> directory /mapr/c0/user/td...*
>
> This looks a bit more worrisome; I have never seen that failure.
>
> The path '/mapr/c0/...', however, hints at a "nonstandard" filesystem.
>
> I would expect the current test suite to trip on weird corner cases on
> networked filesystems such as NFS, let alone something more exotic.  Can
> you confirm that the above is not a "vanilla" filesystem?  If so, that
> would explain the failure.
>
> (Not saying that aspect of the test suite should not be improved.)
>
>
> If you are willing to go through the ordeal once more, I would suggest:
>
>   * Limiting/disabling the test suite concurrency, which is currently
>     known to be problematic.  Perhaps with the following:
>
>         -Dsurefire-forkcount=1 -Dsurefire.rerunFailingTestsCount=5
>
>   * Running it on top of a POSIX/local filesystem;
>
>
> What do you think?
>
> Cheers, -D
>
>
>
> Ted Dunning <te...@gmail.com> writes:
> > Repeated tests. Similar, but not identical failures.
> >
> >
> >
> > On Wed, Mar 24, 2021 at 4:09 PM Ted Dunning <te...@gmail.com>
> wrote:
> >
> >>
> >> I had these test failures. That doesn't look good.
> >>
> >> I haven't been keeping track, however, and am not sure that they are
> >> problems:
> >>
> >> [*ERROR*] *Failures: *
> >>
> >> [*ERROR*] *  RequestThrottlerTest.testRequestThrottler:198 expected: <1>
> >> but was: <0>*
> >>
> >> [*ERROR*] *
> >> LoadFromLogTest>ClientBase.tearDown:590->ClientBase.recursiveDelete:625
> >> file
> >>
> '/mapr/c0/user/tdunning/zookeeper-release-3.7.0-2/zookeeper-server/target/surefire/test3407191642699245455.junit.dir/version-2'
> >> deletion failed*
> >>
> >> [*ERROR*] *Errors: *
> >>
> >> [*ERROR*] *  TxnLogToolkitTest.tearDown:62 » IO Unable to delete
> >> directory /mapr/c0/user/td...*
> >>
> >> [*ERROR*] *  TxnLogToolkitTest.tearDown:62 » IO Unable to delete
> >> directory /mapr/c0/user/td...*
> >>
> >> [*ERROR*] *  TxnLogToolkitTest.tearDown:62 » IO Unable to delete
> >> directory /mapr/c0/user/td...*
> >>
> >> [*ERROR*] *  TxnLogToolkitTest.tearDown:62 » IO Unable to delete
> >> directory /mapr/c0/user/td...*
> >>
> >> [*INFO*]
> >>
> >> [*ERROR*] *Tests run: 2907, Failures: 2, Errors: 4, Skipped: 4*
> >>
> >>
> >> Software info:
> >>
> >> Downloaded 3.7.0-2 from github in tar.gz form
> >>
> >> Platform info:
> >>
> >> Linux nodeb 5.4.0-65-generic #73~18.04.1-Ubuntu SMP Tue Jan 19 09:02:24
> >> UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
> >>
> >>
> >> 32GB RAM, modest number of cores
> >>
> >>
> >>
> >>
> >> On Wed, Mar 24, 2021 at 3:10 PM Ted Dunning <te...@gmail.com>
> wrote:
> >>
> >>>
> >>> I am starting tests now.
> >>>
> >>> I had an issue (self-inflicted) when I tried to run two tests at the
> same
> >>> time.
> >>>
> >>>
> >>>
> >>> On Wed, Mar 24, 2021 at 1:22 PM Damien Diederen <dd...@apache.org>
> >>> wrote:
> >>>
> >>>>
> >>>> Dear all,
> >>>>
> >>>> Thank you for the reviews and testing.
> >>>>
> >>>> Glad that we have not met yet another snag so far!
> >>>>
> >>>> I have counted 5 approving votes, 2 of which are binding.  (The mail
> >>>> archives seem to agree.)  As per the process, I am waiting for a 3rd
> >>>> binding vote before starting the release process.
> >>>>
> >>>> Feel free to prod your PMC friends ;)
> >>>>
> >>>> Cheers, -D
> >>>>
> >>>>
> >>>>
> >>>> Enrico Olivelli <eo...@gmail.com> writes:
> >>>> > +1 (binding)
> >>>> > - Build and run tests on Ubuntu (Java and C client) on jdk8
> >>>> > - verified rat,signatures,sha512sum,checkstyle and spotbugs (on
> JDK8)
> >>>> > - This time (for the first time!) I was able to build the C client
> on
> >>>> > MacOs (BigSur) !
> >>>> > - verified the list of License files in the binary tarball
> >>>> >
> >>>> > great work Damien
> >>>> >
> >>>> > Enrico
> >>>> >
> >>>> > Il giorno lun 22 mar 2021 alle ore 12:37 Mohammad arshad
> >>>> > <mo...@huawei.com> ha scritto:
> >>>> >>
> >>>> >> +1 (non-binding)
> >>>> >>
> >>>> >> Verified signature and checksum of release artifacts, all are ok
> >>>> >> Run Junit test cases with jdk1.8.0_232, total 2951 test cases, 4
> >>>> >> skipped, rest all passed
> >>>> >> Built tarball from source code, installed 3 node cluster and
> >>>> >> verified basic functionalities from API, executed few cli
> >>>> >> commands. No issues observed
> >>>> >> Connected HBase, HDFS and Yarn clusters (all using zk 3.5.6) to zk
> >>>> >> 3.7.0 cluster, no issues observed.
> >>>> >>
> >>>> >> Thanks & Regards
> >>>> >> Arshad
> >>>> >> -----Original Message-----
> >>>> >> From: Patrick Hunt [mailto:phunt@apache.org]
> >>>> >> Sent: Saturday, March 20, 2021 5:17 AM
> >>>> >> To: DevZooKeeper <de...@zookeeper.apache.org>
> >>>> >> Subject: Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 2
> >>>> >>
> >>>> >> +1 xsum/sig validate. rat ran clean and I was able to compile
> (dep/cve
> >>>> >> check passed) and manual verification of a few different cluster
> >>>> >> sizes was successful.
> >>>> >>
> >>>> >> Regards,
> >>>> >>
> >>>> >> Patrick
> >>>> >>
> >>>> >>
> >>>> >> On Wed, Mar 17, 2021 at 4:06 AM Damien Diederen <
> ddiederen@apache.org
> >>>> >
> >>>> >> wrote:
> >>>> >>
> >>>> >> >
> >>>> >> > Greetings, all!
> >>>> >> >
> >>>> >> > After a long delay, here is a third release candidate for
> ZooKeeper
> >>>> 3.7.0.
> >>>> >> >
> >>>> >> > Compared to RC1, it contains... quite a few changes.  It notably
> >>>> fixes
> >>>> >> > the quota feature for multi transactions, repairs the test suite
> on
> >>>> >> > macOS (Catalina), makes a few tests less flaky, and avoids a CVE.
> >>>> >> >
> >>>> >> > The complete set of changes can be obtained with the Git range
> >>>> >> > expression 'release-3.7.0-1..release-3.7.0-2', or on GitHub at:
> >>>> >> >
> >>>> >> >
> >>>> >> >
> >>>>
> https://github.com/apache/zookeeper/compare/release-3.7.0-1...release-
> >>>> >> > 3.7.0-2
> >>>> >> >
> >>>> >> > I cannot say that I find the state of the test suite
> satisfactory,
> >>>> but
> >>>> >> > the failures which are often observed are due to timing and/or
> >>>> TCP/IP
> >>>> >> > port assignment issues, and repeated runs are "sufficient" to
> clear
> >>>> >> > them.
> >>>> >> >
> >>>> >> > I was hoping to contribute more on that front, but have been
> unable
> >>>> so
> >>>> >> > far, and don't want to keep the 3.7 branch hostage—so here is a
> >>>> timid
> >>>> >> > RC2.
> >>>> >> >
> >>>> >> >
> >>>> >> > ZooKeeper 3.7.0 introduces a number of new features, notably:
> >>>> >> >
> >>>> >> >   * An API to start a ZooKeeper server from Java
> (ZOOKEEPER-3874);
> >>>> >> >
> >>>> >> >   * Quota enforcement (ZOOKEEPER-3301);
> >>>> >> >
> >>>> >> >   * Host name canonicalization in quorum SASL authentication
> >>>> >> > (ZOOKEEPER-4030);
> >>>> >> >
> >>>> >> >   * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
> >>>> >> >
> >>>> >> >   * A choice of mandatory authentication scheme(s)
> (ZOOKEEPER-3561);
> >>>> >> >
> >>>> >> >   * A "whoami" API and CLI command (ZOOKEEPER-3969);
> >>>> >> >
> >>>> >> >   * The possibility of disabling digest authentication
> >>>> >> > (ZOOKEEPER-3979);
> >>>> >> >
> >>>> >> >   * Multiple SASL "superUsers" (ZOOKEEPER-3959);
> >>>> >> >
> >>>> >> >   * Fast-tracking of throttled requests (ZOOKEEPER-3683);
> >>>> >> >
> >>>> >> >   * Additional security metrics (ZOOKEEPER-3978);
> >>>> >> >
> >>>> >> >   * SASL support in the C and Perl clients (ZOOKEEPER-1112,
> >>>> >> > ZOOKEEPER-3714);
> >>>> >> >
> >>>> >> >   * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
> >>>> >> >
> >>>> >> >   * Notes on how to benchmark ZooKeeper with the YCSB tool
> >>>> >> > (ZOOKEEPER-3264).
> >>>> >> >
> >>>> >> >
> >>>> >> > The release notes are available here:
> >>>> >> >
> >>>> >> >
> >>>> >> >
> >>>>
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/websi
> >>>> >> > te/releasenotes.html
> >>>> >> >
> >>>> >> >
> >>>>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310
> >>>> >> > 801&version=12346617
> >>>> >> >
> >>>> >> > *** Please download, test and vote by March 21st 2021, 23:59
> UTC+0.
> >>>> >> > ***
> >>>> >> >
> >>>> >> > Source files:
> >>>> >> >
> >>>> >> >
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/
> >>>> >> >
> >>>> >> > Maven staging repo:
> >>>> >> >
> >>>> >> >
> >>>> >> >
> >>>>
> https://repository.apache.org/content/repositories/orgapachezookeeper-
> >>>> >> > 1067/
> >>>> >> >
> >>>> >> > The release candidate tag in git to be voted upon:
> release-3.7.0-2
> >>>> >> >
> >>>> >> >   https://github.com/apache/zookeeper/tree/release-3.7.0-2
> >>>> >> >
> >>>> >> > ZooKeeper's KEYS file containing PGP keys we use to sign the
> >>>> release:
> >>>> >> >
> >>>> >> >   https://www.apache.org/dist/zookeeper/KEYS
> >>>> >> >
> >>>> >> > The staging version of the website is:
> >>>> >> >
> >>>> >> >
> >>>> >> >
> >>>>
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/websi
> >>>> >> > te/
> >>>> >> >
> >>>> >> >
> >>>> >> > Should we release this candidate?
> >>>> >> >
> >>>> >> >
> >>>> >> > Damien Diederen
> >>>> >> >
> >>>>
> >>>
>

Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 2

Posted by Damien Diederen <dd...@apache.org>.
Hi Ted, all,

Thank you for testing.  You reported:

>> I had these test failures. That doesn't look good.
[…]
>
> Repeated tests. Similar, but not identical failures.
[…]

I agree that it doesn't look good, but am also unsurprised.  This is
precisely why I included this text in my call for vote:

>>> I cannot say that I find the state of the test suite satisfactory, but
>>> the failures which are often observed are due to timing and/or TCP/IP
>>> port assignment issues, and repeated runs are "sufficient" to clear
>>> them.
>>>
>>> I was hoping to contribute more on that front, but have been unable so
>>> far, and don't want to keep the 3.7 branch hostage—so here is a timid
>>> RC2.


We currently have a number of tests which are very flaky unless they are
being run on hardware which is both powerful and dedicated.

This happens for a number of reasons, including hardcoded deadlines and
TCP/IP port allocation races.

There has been some work on fixing this, notably by Justin Ling Mao and
Mohammad Arshad.  I have also contributed, and intend to do more—but the
past weeks have conspired against it.  This is a slope we have to climb,
and I'm afraid it will take some time.

My understanding is that test suites failures were not supposed to delay
3.7.0 as long as they were 1/ sporadic and 2/ understood.  It is very
unfortunate that the extent of the problem was not discovered before the
3.7 fork point, as it has kept us in limbo for a while!


Note that an additional factor is that 'pom.xml' contains the following:

    <surefire-forkcount>8</surefire-forkcount>

which isn't very good as a default given the current situation.  In
fact, both CI suites override it, the Jenkins one with:

    -Dsurefire-forkcount=4

and GitHub CI with:

    -Dsurefire-forkcount=1 -Dsurefire.rerunFailingTestsCount=5


>> [*ERROR*] *  RequestThrottlerTest.testRequestThrottler:198 expected: <1>
>> but was: <0>*

This test is a known offender, and is on my list of items to investigate.

I highly suspect the 5s timeout is the culprit; it should probably be
bumped up by some margin (and STALL_TIME be correspondingly adjusted):

    // make sure the server received all 5 requests
    submitted.await(5, TimeUnit.SECONDS);
    Map<String, Object> metrics = MetricsUtils.currentServerMetrics();

    // but only two requests can get into the pipeline because of the throttler
    assertEquals(2L, (long) metrics.get("prep_processor_request_queued"));
    assertEquals(1L, (long) metrics.get("request_throttle_wait_count"));

https://github.com/apache/zookeeper/blob/release-3.7.0-2/zookeeper-server/src/test/java/org/apache/zookeeper/server/RequestThrottlerTest.java#L192-L198


>> [*ERROR*] * LoadFromLogTest>ClientBase.tearDown:590->ClientBase.recursiveDelete:625 file '/mapr/c0/user/tdunning/zookeeper-release-3.7.0-2/zookeeper-server/target/surefire/test3407191642699245455.junit.dir/version-2' deletion failed*
[…]
>> [*ERROR*] *  TxnLogToolkitTest.tearDown:62 » IO Unable to delete
>> directory /mapr/c0/user/td...*

This looks a bit more worrisome; I have never seen that failure.

The path '/mapr/c0/...', however, hints at a "nonstandard" filesystem.

I would expect the current test suite to trip on weird corner cases on
networked filesystems such as NFS, let alone something more exotic.  Can
you confirm that the above is not a "vanilla" filesystem?  If so, that
would explain the failure.

(Not saying that aspect of the test suite should not be improved.)


If you are willing to go through the ordeal once more, I would suggest:

  * Limiting/disabling the test suite concurrency, which is currently
    known to be problematic.  Perhaps with the following:

        -Dsurefire-forkcount=1 -Dsurefire.rerunFailingTestsCount=5

  * Running it on top of a POSIX/local filesystem;


What do you think?

Cheers, -D



Ted Dunning <te...@gmail.com> writes:
> Repeated tests. Similar, but not identical failures.
>
>
>
> On Wed, Mar 24, 2021 at 4:09 PM Ted Dunning <te...@gmail.com> wrote:
>
>>
>> I had these test failures. That doesn't look good.
>>
>> I haven't been keeping track, however, and am not sure that they are
>> problems:
>>
>> [*ERROR*] *Failures: *
>>
>> [*ERROR*] *  RequestThrottlerTest.testRequestThrottler:198 expected: <1>
>> but was: <0>*
>>
>> [*ERROR*] *
>> LoadFromLogTest>ClientBase.tearDown:590->ClientBase.recursiveDelete:625
>> file
>> '/mapr/c0/user/tdunning/zookeeper-release-3.7.0-2/zookeeper-server/target/surefire/test3407191642699245455.junit.dir/version-2'
>> deletion failed*
>>
>> [*ERROR*] *Errors: *
>>
>> [*ERROR*] *  TxnLogToolkitTest.tearDown:62 » IO Unable to delete
>> directory /mapr/c0/user/td...*
>>
>> [*ERROR*] *  TxnLogToolkitTest.tearDown:62 » IO Unable to delete
>> directory /mapr/c0/user/td...*
>>
>> [*ERROR*] *  TxnLogToolkitTest.tearDown:62 » IO Unable to delete
>> directory /mapr/c0/user/td...*
>>
>> [*ERROR*] *  TxnLogToolkitTest.tearDown:62 » IO Unable to delete
>> directory /mapr/c0/user/td...*
>>
>> [*INFO*]
>>
>> [*ERROR*] *Tests run: 2907, Failures: 2, Errors: 4, Skipped: 4*
>>
>>
>> Software info:
>>
>> Downloaded 3.7.0-2 from github in tar.gz form
>>
>> Platform info:
>>
>> Linux nodeb 5.4.0-65-generic #73~18.04.1-Ubuntu SMP Tue Jan 19 09:02:24
>> UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
>>
>>
>> 32GB RAM, modest number of cores
>>
>>
>>
>>
>> On Wed, Mar 24, 2021 at 3:10 PM Ted Dunning <te...@gmail.com> wrote:
>>
>>>
>>> I am starting tests now.
>>>
>>> I had an issue (self-inflicted) when I tried to run two tests at the same
>>> time.
>>>
>>>
>>>
>>> On Wed, Mar 24, 2021 at 1:22 PM Damien Diederen <dd...@apache.org>
>>> wrote:
>>>
>>>>
>>>> Dear all,
>>>>
>>>> Thank you for the reviews and testing.
>>>>
>>>> Glad that we have not met yet another snag so far!
>>>>
>>>> I have counted 5 approving votes, 2 of which are binding.  (The mail
>>>> archives seem to agree.)  As per the process, I am waiting for a 3rd
>>>> binding vote before starting the release process.
>>>>
>>>> Feel free to prod your PMC friends ;)
>>>>
>>>> Cheers, -D
>>>>
>>>>
>>>>
>>>> Enrico Olivelli <eo...@gmail.com> writes:
>>>> > +1 (binding)
>>>> > - Build and run tests on Ubuntu (Java and C client) on jdk8
>>>> > - verified rat,signatures,sha512sum,checkstyle and spotbugs (on JDK8)
>>>> > - This time (for the first time!) I was able to build the C client on
>>>> > MacOs (BigSur) !
>>>> > - verified the list of License files in the binary tarball
>>>> >
>>>> > great work Damien
>>>> >
>>>> > Enrico
>>>> >
>>>> > Il giorno lun 22 mar 2021 alle ore 12:37 Mohammad arshad
>>>> > <mo...@huawei.com> ha scritto:
>>>> >>
>>>> >> +1 (non-binding)
>>>> >>
>>>> >> Verified signature and checksum of release artifacts, all are ok
>>>> >> Run Junit test cases with jdk1.8.0_232, total 2951 test cases, 4
>>>> >> skipped, rest all passed
>>>> >> Built tarball from source code, installed 3 node cluster and
>>>> >> verified basic functionalities from API, executed few cli
>>>> >> commands. No issues observed
>>>> >> Connected HBase, HDFS and Yarn clusters (all using zk 3.5.6) to zk
>>>> >> 3.7.0 cluster, no issues observed.
>>>> >>
>>>> >> Thanks & Regards
>>>> >> Arshad
>>>> >> -----Original Message-----
>>>> >> From: Patrick Hunt [mailto:phunt@apache.org]
>>>> >> Sent: Saturday, March 20, 2021 5:17 AM
>>>> >> To: DevZooKeeper <de...@zookeeper.apache.org>
>>>> >> Subject: Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 2
>>>> >>
>>>> >> +1 xsum/sig validate. rat ran clean and I was able to compile (dep/cve
>>>> >> check passed) and manual verification of a few different cluster
>>>> >> sizes was successful.
>>>> >>
>>>> >> Regards,
>>>> >>
>>>> >> Patrick
>>>> >>
>>>> >>
>>>> >> On Wed, Mar 17, 2021 at 4:06 AM Damien Diederen <ddiederen@apache.org
>>>> >
>>>> >> wrote:
>>>> >>
>>>> >> >
>>>> >> > Greetings, all!
>>>> >> >
>>>> >> > After a long delay, here is a third release candidate for ZooKeeper
>>>> 3.7.0.
>>>> >> >
>>>> >> > Compared to RC1, it contains... quite a few changes.  It notably
>>>> fixes
>>>> >> > the quota feature for multi transactions, repairs the test suite on
>>>> >> > macOS (Catalina), makes a few tests less flaky, and avoids a CVE.
>>>> >> >
>>>> >> > The complete set of changes can be obtained with the Git range
>>>> >> > expression 'release-3.7.0-1..release-3.7.0-2', or on GitHub at:
>>>> >> >
>>>> >> >
>>>> >> >
>>>> https://github.com/apache/zookeeper/compare/release-3.7.0-1...release-
>>>> >> > 3.7.0-2
>>>> >> >
>>>> >> > I cannot say that I find the state of the test suite satisfactory,
>>>> but
>>>> >> > the failures which are often observed are due to timing and/or
>>>> TCP/IP
>>>> >> > port assignment issues, and repeated runs are "sufficient" to clear
>>>> >> > them.
>>>> >> >
>>>> >> > I was hoping to contribute more on that front, but have been unable
>>>> so
>>>> >> > far, and don't want to keep the 3.7 branch hostage—so here is a
>>>> timid
>>>> >> > RC2.
>>>> >> >
>>>> >> >
>>>> >> > ZooKeeper 3.7.0 introduces a number of new features, notably:
>>>> >> >
>>>> >> >   * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
>>>> >> >
>>>> >> >   * Quota enforcement (ZOOKEEPER-3301);
>>>> >> >
>>>> >> >   * Host name canonicalization in quorum SASL authentication
>>>> >> > (ZOOKEEPER-4030);
>>>> >> >
>>>> >> >   * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
>>>> >> >
>>>> >> >   * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);
>>>> >> >
>>>> >> >   * A "whoami" API and CLI command (ZOOKEEPER-3969);
>>>> >> >
>>>> >> >   * The possibility of disabling digest authentication
>>>> >> > (ZOOKEEPER-3979);
>>>> >> >
>>>> >> >   * Multiple SASL "superUsers" (ZOOKEEPER-3959);
>>>> >> >
>>>> >> >   * Fast-tracking of throttled requests (ZOOKEEPER-3683);
>>>> >> >
>>>> >> >   * Additional security metrics (ZOOKEEPER-3978);
>>>> >> >
>>>> >> >   * SASL support in the C and Perl clients (ZOOKEEPER-1112,
>>>> >> > ZOOKEEPER-3714);
>>>> >> >
>>>> >> >   * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
>>>> >> >
>>>> >> >   * Notes on how to benchmark ZooKeeper with the YCSB tool
>>>> >> > (ZOOKEEPER-3264).
>>>> >> >
>>>> >> >
>>>> >> > The release notes are available here:
>>>> >> >
>>>> >> >
>>>> >> >
>>>> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/websi
>>>> >> > te/releasenotes.html
>>>> >> >
>>>> >> >
>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310
>>>> >> > 801&version=12346617
>>>> >> >
>>>> >> > *** Please download, test and vote by March 21st 2021, 23:59 UTC+0.
>>>> >> > ***
>>>> >> >
>>>> >> > Source files:
>>>> >> >
>>>> >> >   https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/
>>>> >> >
>>>> >> > Maven staging repo:
>>>> >> >
>>>> >> >
>>>> >> >
>>>> https://repository.apache.org/content/repositories/orgapachezookeeper-
>>>> >> > 1067/
>>>> >> >
>>>> >> > The release candidate tag in git to be voted upon: release-3.7.0-2
>>>> >> >
>>>> >> >   https://github.com/apache/zookeeper/tree/release-3.7.0-2
>>>> >> >
>>>> >> > ZooKeeper's KEYS file containing PGP keys we use to sign the
>>>> release:
>>>> >> >
>>>> >> >   https://www.apache.org/dist/zookeeper/KEYS
>>>> >> >
>>>> >> > The staging version of the website is:
>>>> >> >
>>>> >> >
>>>> >> >
>>>> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/websi
>>>> >> > te/
>>>> >> >
>>>> >> >
>>>> >> > Should we release this candidate?
>>>> >> >
>>>> >> >
>>>> >> > Damien Diederen
>>>> >> >
>>>>
>>>

Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 2

Posted by Ted Dunning <te...@gmail.com>.
Repeated tests. Similar, but not identical failures.



On Wed, Mar 24, 2021 at 4:09 PM Ted Dunning <te...@gmail.com> wrote:

>
> I had these test failures. That doesn't look good.
>
> I haven't been keeping track, however, and am not sure that they are
> problems:
>
> [*ERROR*] *Failures: *
>
> [*ERROR*] *  RequestThrottlerTest.testRequestThrottler:198 expected: <1>
> but was: <0>*
>
> [*ERROR*] *
> LoadFromLogTest>ClientBase.tearDown:590->ClientBase.recursiveDelete:625
> file
> '/mapr/c0/user/tdunning/zookeeper-release-3.7.0-2/zookeeper-server/target/surefire/test3407191642699245455.junit.dir/version-2'
> deletion failed*
>
> [*ERROR*] *Errors: *
>
> [*ERROR*] *  TxnLogToolkitTest.tearDown:62 » IO Unable to delete
> directory /mapr/c0/user/td...*
>
> [*ERROR*] *  TxnLogToolkitTest.tearDown:62 » IO Unable to delete
> directory /mapr/c0/user/td...*
>
> [*ERROR*] *  TxnLogToolkitTest.tearDown:62 » IO Unable to delete
> directory /mapr/c0/user/td...*
>
> [*ERROR*] *  TxnLogToolkitTest.tearDown:62 » IO Unable to delete
> directory /mapr/c0/user/td...*
>
> [*INFO*]
>
> [*ERROR*] *Tests run: 2907, Failures: 2, Errors: 4, Skipped: 4*
>
>
> Software info:
>
> Downloaded 3.7.0-2 from github in tar.gz form
>
> Platform info:
>
> Linux nodeb 5.4.0-65-generic #73~18.04.1-Ubuntu SMP Tue Jan 19 09:02:24
> UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
>
>
> 32GB RAM, modest number of cores
>
>
>
>
> On Wed, Mar 24, 2021 at 3:10 PM Ted Dunning <te...@gmail.com> wrote:
>
>>
>> I am starting tests now.
>>
>> I had an issue (self-inflicted) when I tried to run two tests at the same
>> time.
>>
>>
>>
>> On Wed, Mar 24, 2021 at 1:22 PM Damien Diederen <dd...@apache.org>
>> wrote:
>>
>>>
>>> Dear all,
>>>
>>> Thank you for the reviews and testing.
>>>
>>> Glad that we have not met yet another snag so far!
>>>
>>> I have counted 5 approving votes, 2 of which are binding.  (The mail
>>> archives seem to agree.)  As per the process, I am waiting for a 3rd
>>> binding vote before starting the release process.
>>>
>>> Feel free to prod your PMC friends ;)
>>>
>>> Cheers, -D
>>>
>>>
>>>
>>> Enrico Olivelli <eo...@gmail.com> writes:
>>> > +1 (binding)
>>> > - Build and run tests on Ubuntu (Java and C client) on jdk8
>>> > - verified rat,signatures,sha512sum,checkstyle and spotbugs (on JDK8)
>>> > - This time (for the first time!) I was able to build the C client on
>>> > MacOs (BigSur) !
>>> > - verified the list of License files in the binary tarball
>>> >
>>> > great work Damien
>>> >
>>> > Enrico
>>> >
>>> > Il giorno lun 22 mar 2021 alle ore 12:37 Mohammad arshad
>>> > <mo...@huawei.com> ha scritto:
>>> >>
>>> >> +1 (non-binding)
>>> >>
>>> >> Verified signature and checksum of release artifacts, all are ok
>>> >> Run Junit test cases with jdk1.8.0_232, total 2951 test cases, 4
>>> >> skipped, rest all passed
>>> >> Built tarball from source code, installed 3 node cluster and
>>> >> verified basic functionalities from API, executed few cli
>>> >> commands. No issues observed
>>> >> Connected HBase, HDFS and Yarn clusters (all using zk 3.5.6) to zk
>>> >> 3.7.0 cluster, no issues observed.
>>> >>
>>> >> Thanks & Regards
>>> >> Arshad
>>> >> -----Original Message-----
>>> >> From: Patrick Hunt [mailto:phunt@apache.org]
>>> >> Sent: Saturday, March 20, 2021 5:17 AM
>>> >> To: DevZooKeeper <de...@zookeeper.apache.org>
>>> >> Subject: Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 2
>>> >>
>>> >> +1 xsum/sig validate. rat ran clean and I was able to compile (dep/cve
>>> >> check passed) and manual verification of a few different cluster
>>> >> sizes was successful.
>>> >>
>>> >> Regards,
>>> >>
>>> >> Patrick
>>> >>
>>> >>
>>> >> On Wed, Mar 17, 2021 at 4:06 AM Damien Diederen <ddiederen@apache.org
>>> >
>>> >> wrote:
>>> >>
>>> >> >
>>> >> > Greetings, all!
>>> >> >
>>> >> > After a long delay, here is a third release candidate for ZooKeeper
>>> 3.7.0.
>>> >> >
>>> >> > Compared to RC1, it contains... quite a few changes.  It notably
>>> fixes
>>> >> > the quota feature for multi transactions, repairs the test suite on
>>> >> > macOS (Catalina), makes a few tests less flaky, and avoids a CVE.
>>> >> >
>>> >> > The complete set of changes can be obtained with the Git range
>>> >> > expression 'release-3.7.0-1..release-3.7.0-2', or on GitHub at:
>>> >> >
>>> >> >
>>> >> >
>>> https://github.com/apache/zookeeper/compare/release-3.7.0-1...release-
>>> >> > 3.7.0-2
>>> >> >
>>> >> > I cannot say that I find the state of the test suite satisfactory,
>>> but
>>> >> > the failures which are often observed are due to timing and/or
>>> TCP/IP
>>> >> > port assignment issues, and repeated runs are "sufficient" to clear
>>> >> > them.
>>> >> >
>>> >> > I was hoping to contribute more on that front, but have been unable
>>> so
>>> >> > far, and don't want to keep the 3.7 branch hostage—so here is a
>>> timid
>>> >> > RC2.
>>> >> >
>>> >> >
>>> >> > ZooKeeper 3.7.0 introduces a number of new features, notably:
>>> >> >
>>> >> >   * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
>>> >> >
>>> >> >   * Quota enforcement (ZOOKEEPER-3301);
>>> >> >
>>> >> >   * Host name canonicalization in quorum SASL authentication
>>> >> > (ZOOKEEPER-4030);
>>> >> >
>>> >> >   * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
>>> >> >
>>> >> >   * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);
>>> >> >
>>> >> >   * A "whoami" API and CLI command (ZOOKEEPER-3969);
>>> >> >
>>> >> >   * The possibility of disabling digest authentication
>>> >> > (ZOOKEEPER-3979);
>>> >> >
>>> >> >   * Multiple SASL "superUsers" (ZOOKEEPER-3959);
>>> >> >
>>> >> >   * Fast-tracking of throttled requests (ZOOKEEPER-3683);
>>> >> >
>>> >> >   * Additional security metrics (ZOOKEEPER-3978);
>>> >> >
>>> >> >   * SASL support in the C and Perl clients (ZOOKEEPER-1112,
>>> >> > ZOOKEEPER-3714);
>>> >> >
>>> >> >   * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
>>> >> >
>>> >> >   * Notes on how to benchmark ZooKeeper with the YCSB tool
>>> >> > (ZOOKEEPER-3264).
>>> >> >
>>> >> >
>>> >> > The release notes are available here:
>>> >> >
>>> >> >
>>> >> >
>>> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/websi
>>> >> > te/releasenotes.html
>>> >> >
>>> >> >
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310
>>> >> > 801&version=12346617
>>> >> >
>>> >> > *** Please download, test and vote by March 21st 2021, 23:59 UTC+0.
>>> >> > ***
>>> >> >
>>> >> > Source files:
>>> >> >
>>> >> >   https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/
>>> >> >
>>> >> > Maven staging repo:
>>> >> >
>>> >> >
>>> >> >
>>> https://repository.apache.org/content/repositories/orgapachezookeeper-
>>> >> > 1067/
>>> >> >
>>> >> > The release candidate tag in git to be voted upon: release-3.7.0-2
>>> >> >
>>> >> >   https://github.com/apache/zookeeper/tree/release-3.7.0-2
>>> >> >
>>> >> > ZooKeeper's KEYS file containing PGP keys we use to sign the
>>> release:
>>> >> >
>>> >> >   https://www.apache.org/dist/zookeeper/KEYS
>>> >> >
>>> >> > The staging version of the website is:
>>> >> >
>>> >> >
>>> >> >
>>> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/websi
>>> >> > te/
>>> >> >
>>> >> >
>>> >> > Should we release this candidate?
>>> >> >
>>> >> >
>>> >> > Damien Diederen
>>> >> >
>>>
>>

Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 2

Posted by Ted Dunning <te...@gmail.com>.
I had these test failures. That doesn't look good.

I haven't been keeping track, however, and am not sure that they are
problems:

[*ERROR*] *Failures: *

[*ERROR*] *  RequestThrottlerTest.testRequestThrottler:198 expected: <1>
but was: <0>*

[*ERROR*] *
LoadFromLogTest>ClientBase.tearDown:590->ClientBase.recursiveDelete:625
file
'/mapr/c0/user/tdunning/zookeeper-release-3.7.0-2/zookeeper-server/target/surefire/test3407191642699245455.junit.dir/version-2'
deletion failed*

[*ERROR*] *Errors: *

[*ERROR*] *  TxnLogToolkitTest.tearDown:62 » IO Unable to delete directory
/mapr/c0/user/td...*

[*ERROR*] *  TxnLogToolkitTest.tearDown:62 » IO Unable to delete directory
/mapr/c0/user/td...*

[*ERROR*] *  TxnLogToolkitTest.tearDown:62 » IO Unable to delete directory
/mapr/c0/user/td...*

[*ERROR*] *  TxnLogToolkitTest.tearDown:62 » IO Unable to delete directory
/mapr/c0/user/td...*

[*INFO*]

[*ERROR*] *Tests run: 2907, Failures: 2, Errors: 4, Skipped: 4*


Software info:

Downloaded 3.7.0-2 from github in tar.gz form

Platform info:

Linux nodeb 5.4.0-65-generic #73~18.04.1-Ubuntu SMP Tue Jan 19 09:02:24 UTC
2021 x86_64 x86_64 x86_64 GNU/Linux


32GB RAM, modest number of cores




On Wed, Mar 24, 2021 at 3:10 PM Ted Dunning <te...@gmail.com> wrote:

>
> I am starting tests now.
>
> I had an issue (self-inflicted) when I tried to run two tests at the same
> time.
>
>
>
> On Wed, Mar 24, 2021 at 1:22 PM Damien Diederen <dd...@apache.org>
> wrote:
>
>>
>> Dear all,
>>
>> Thank you for the reviews and testing.
>>
>> Glad that we have not met yet another snag so far!
>>
>> I have counted 5 approving votes, 2 of which are binding.  (The mail
>> archives seem to agree.)  As per the process, I am waiting for a 3rd
>> binding vote before starting the release process.
>>
>> Feel free to prod your PMC friends ;)
>>
>> Cheers, -D
>>
>>
>>
>> Enrico Olivelli <eo...@gmail.com> writes:
>> > +1 (binding)
>> > - Build and run tests on Ubuntu (Java and C client) on jdk8
>> > - verified rat,signatures,sha512sum,checkstyle and spotbugs (on JDK8)
>> > - This time (for the first time!) I was able to build the C client on
>> > MacOs (BigSur) !
>> > - verified the list of License files in the binary tarball
>> >
>> > great work Damien
>> >
>> > Enrico
>> >
>> > Il giorno lun 22 mar 2021 alle ore 12:37 Mohammad arshad
>> > <mo...@huawei.com> ha scritto:
>> >>
>> >> +1 (non-binding)
>> >>
>> >> Verified signature and checksum of release artifacts, all are ok
>> >> Run Junit test cases with jdk1.8.0_232, total 2951 test cases, 4
>> >> skipped, rest all passed
>> >> Built tarball from source code, installed 3 node cluster and
>> >> verified basic functionalities from API, executed few cli
>> >> commands. No issues observed
>> >> Connected HBase, HDFS and Yarn clusters (all using zk 3.5.6) to zk
>> >> 3.7.0 cluster, no issues observed.
>> >>
>> >> Thanks & Regards
>> >> Arshad
>> >> -----Original Message-----
>> >> From: Patrick Hunt [mailto:phunt@apache.org]
>> >> Sent: Saturday, March 20, 2021 5:17 AM
>> >> To: DevZooKeeper <de...@zookeeper.apache.org>
>> >> Subject: Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 2
>> >>
>> >> +1 xsum/sig validate. rat ran clean and I was able to compile (dep/cve
>> >> check passed) and manual verification of a few different cluster
>> >> sizes was successful.
>> >>
>> >> Regards,
>> >>
>> >> Patrick
>> >>
>> >>
>> >> On Wed, Mar 17, 2021 at 4:06 AM Damien Diederen <dd...@apache.org>
>> >> wrote:
>> >>
>> >> >
>> >> > Greetings, all!
>> >> >
>> >> > After a long delay, here is a third release candidate for ZooKeeper
>> 3.7.0.
>> >> >
>> >> > Compared to RC1, it contains... quite a few changes.  It notably
>> fixes
>> >> > the quota feature for multi transactions, repairs the test suite on
>> >> > macOS (Catalina), makes a few tests less flaky, and avoids a CVE.
>> >> >
>> >> > The complete set of changes can be obtained with the Git range
>> >> > expression 'release-3.7.0-1..release-3.7.0-2', or on GitHub at:
>> >> >
>> >> >
>> >> >
>> https://github.com/apache/zookeeper/compare/release-3.7.0-1...release-
>> >> > 3.7.0-2
>> >> >
>> >> > I cannot say that I find the state of the test suite satisfactory,
>> but
>> >> > the failures which are often observed are due to timing and/or TCP/IP
>> >> > port assignment issues, and repeated runs are "sufficient" to clear
>> >> > them.
>> >> >
>> >> > I was hoping to contribute more on that front, but have been unable
>> so
>> >> > far, and don't want to keep the 3.7 branch hostage—so here is a timid
>> >> > RC2.
>> >> >
>> >> >
>> >> > ZooKeeper 3.7.0 introduces a number of new features, notably:
>> >> >
>> >> >   * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
>> >> >
>> >> >   * Quota enforcement (ZOOKEEPER-3301);
>> >> >
>> >> >   * Host name canonicalization in quorum SASL authentication
>> >> > (ZOOKEEPER-4030);
>> >> >
>> >> >   * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
>> >> >
>> >> >   * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);
>> >> >
>> >> >   * A "whoami" API and CLI command (ZOOKEEPER-3969);
>> >> >
>> >> >   * The possibility of disabling digest authentication
>> >> > (ZOOKEEPER-3979);
>> >> >
>> >> >   * Multiple SASL "superUsers" (ZOOKEEPER-3959);
>> >> >
>> >> >   * Fast-tracking of throttled requests (ZOOKEEPER-3683);
>> >> >
>> >> >   * Additional security metrics (ZOOKEEPER-3978);
>> >> >
>> >> >   * SASL support in the C and Perl clients (ZOOKEEPER-1112,
>> >> > ZOOKEEPER-3714);
>> >> >
>> >> >   * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
>> >> >
>> >> >   * Notes on how to benchmark ZooKeeper with the YCSB tool
>> >> > (ZOOKEEPER-3264).
>> >> >
>> >> >
>> >> > The release notes are available here:
>> >> >
>> >> >
>> >> >
>> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/websi
>> >> > te/releasenotes.html
>> >> >
>> >> >
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310
>> >> > 801&version=12346617
>> >> >
>> >> > *** Please download, test and vote by March 21st 2021, 23:59 UTC+0.
>> >> > ***
>> >> >
>> >> > Source files:
>> >> >
>> >> >   https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/
>> >> >
>> >> > Maven staging repo:
>> >> >
>> >> >
>> >> >
>> https://repository.apache.org/content/repositories/orgapachezookeeper-
>> >> > 1067/
>> >> >
>> >> > The release candidate tag in git to be voted upon: release-3.7.0-2
>> >> >
>> >> >   https://github.com/apache/zookeeper/tree/release-3.7.0-2
>> >> >
>> >> > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
>> >> >
>> >> >   https://www.apache.org/dist/zookeeper/KEYS
>> >> >
>> >> > The staging version of the website is:
>> >> >
>> >> >
>> >> >
>> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/websi
>> >> > te/
>> >> >
>> >> >
>> >> > Should we release this candidate?
>> >> >
>> >> >
>> >> > Damien Diederen
>> >> >
>>
>

Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 2

Posted by Ted Dunning <te...@gmail.com>.
I am starting tests now.

I had an issue (self-inflicted) when I tried to run two tests at the same
time.



On Wed, Mar 24, 2021 at 1:22 PM Damien Diederen <dd...@apache.org>
wrote:

>
> Dear all,
>
> Thank you for the reviews and testing.
>
> Glad that we have not met yet another snag so far!
>
> I have counted 5 approving votes, 2 of which are binding.  (The mail
> archives seem to agree.)  As per the process, I am waiting for a 3rd
> binding vote before starting the release process.
>
> Feel free to prod your PMC friends ;)
>
> Cheers, -D
>
>
>
> Enrico Olivelli <eo...@gmail.com> writes:
> > +1 (binding)
> > - Build and run tests on Ubuntu (Java and C client) on jdk8
> > - verified rat,signatures,sha512sum,checkstyle and spotbugs (on JDK8)
> > - This time (for the first time!) I was able to build the C client on
> > MacOs (BigSur) !
> > - verified the list of License files in the binary tarball
> >
> > great work Damien
> >
> > Enrico
> >
> > Il giorno lun 22 mar 2021 alle ore 12:37 Mohammad arshad
> > <mo...@huawei.com> ha scritto:
> >>
> >> +1 (non-binding)
> >>
> >> Verified signature and checksum of release artifacts, all are ok
> >> Run Junit test cases with jdk1.8.0_232, total 2951 test cases, 4
> >> skipped, rest all passed
> >> Built tarball from source code, installed 3 node cluster and
> >> verified basic functionalities from API, executed few cli
> >> commands. No issues observed
> >> Connected HBase, HDFS and Yarn clusters (all using zk 3.5.6) to zk
> >> 3.7.0 cluster, no issues observed.
> >>
> >> Thanks & Regards
> >> Arshad
> >> -----Original Message-----
> >> From: Patrick Hunt [mailto:phunt@apache.org]
> >> Sent: Saturday, March 20, 2021 5:17 AM
> >> To: DevZooKeeper <de...@zookeeper.apache.org>
> >> Subject: Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 2
> >>
> >> +1 xsum/sig validate. rat ran clean and I was able to compile (dep/cve
> >> check passed) and manual verification of a few different cluster
> >> sizes was successful.
> >>
> >> Regards,
> >>
> >> Patrick
> >>
> >>
> >> On Wed, Mar 17, 2021 at 4:06 AM Damien Diederen <dd...@apache.org>
> >> wrote:
> >>
> >> >
> >> > Greetings, all!
> >> >
> >> > After a long delay, here is a third release candidate for ZooKeeper
> 3.7.0.
> >> >
> >> > Compared to RC1, it contains... quite a few changes.  It notably fixes
> >> > the quota feature for multi transactions, repairs the test suite on
> >> > macOS (Catalina), makes a few tests less flaky, and avoids a CVE.
> >> >
> >> > The complete set of changes can be obtained with the Git range
> >> > expression 'release-3.7.0-1..release-3.7.0-2', or on GitHub at:
> >> >
> >> >
> >> >
> https://github.com/apache/zookeeper/compare/release-3.7.0-1...release-
> >> > 3.7.0-2
> >> >
> >> > I cannot say that I find the state of the test suite satisfactory, but
> >> > the failures which are often observed are due to timing and/or TCP/IP
> >> > port assignment issues, and repeated runs are "sufficient" to clear
> >> > them.
> >> >
> >> > I was hoping to contribute more on that front, but have been unable so
> >> > far, and don't want to keep the 3.7 branch hostage—so here is a timid
> >> > RC2.
> >> >
> >> >
> >> > ZooKeeper 3.7.0 introduces a number of new features, notably:
> >> >
> >> >   * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
> >> >
> >> >   * Quota enforcement (ZOOKEEPER-3301);
> >> >
> >> >   * Host name canonicalization in quorum SASL authentication
> >> > (ZOOKEEPER-4030);
> >> >
> >> >   * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
> >> >
> >> >   * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);
> >> >
> >> >   * A "whoami" API and CLI command (ZOOKEEPER-3969);
> >> >
> >> >   * The possibility of disabling digest authentication
> >> > (ZOOKEEPER-3979);
> >> >
> >> >   * Multiple SASL "superUsers" (ZOOKEEPER-3959);
> >> >
> >> >   * Fast-tracking of throttled requests (ZOOKEEPER-3683);
> >> >
> >> >   * Additional security metrics (ZOOKEEPER-3978);
> >> >
> >> >   * SASL support in the C and Perl clients (ZOOKEEPER-1112,
> >> > ZOOKEEPER-3714);
> >> >
> >> >   * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
> >> >
> >> >   * Notes on how to benchmark ZooKeeper with the YCSB tool
> >> > (ZOOKEEPER-3264).
> >> >
> >> >
> >> > The release notes are available here:
> >> >
> >> >
> >> >
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/websi
> >> > te/releasenotes.html
> >> >
> >> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310
> >> > 801&version=12346617
> >> >
> >> > *** Please download, test and vote by March 21st 2021, 23:59 UTC+0.
> >> > ***
> >> >
> >> > Source files:
> >> >
> >> >   https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/
> >> >
> >> > Maven staging repo:
> >> >
> >> >
> >> >
> https://repository.apache.org/content/repositories/orgapachezookeeper-
> >> > 1067/
> >> >
> >> > The release candidate tag in git to be voted upon: release-3.7.0-2
> >> >
> >> >   https://github.com/apache/zookeeper/tree/release-3.7.0-2
> >> >
> >> > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> >> >
> >> >   https://www.apache.org/dist/zookeeper/KEYS
> >> >
> >> > The staging version of the website is:
> >> >
> >> >
> >> >
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/websi
> >> > te/
> >> >
> >> >
> >> > Should we release this candidate?
> >> >
> >> >
> >> > Damien Diederen
> >> >
>

Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 2

Posted by Damien Diederen <dd...@apache.org>.
Dear all,

Thank you for the reviews and testing.

Glad that we have not met yet another snag so far!

I have counted 5 approving votes, 2 of which are binding.  (The mail
archives seem to agree.)  As per the process, I am waiting for a 3rd
binding vote before starting the release process.

Feel free to prod your PMC friends ;)

Cheers, -D



Enrico Olivelli <eo...@gmail.com> writes:
> +1 (binding)
> - Build and run tests on Ubuntu (Java and C client) on jdk8
> - verified rat,signatures,sha512sum,checkstyle and spotbugs (on JDK8)
> - This time (for the first time!) I was able to build the C client on
> MacOs (BigSur) !
> - verified the list of License files in the binary tarball
>
> great work Damien
>
> Enrico
>
> Il giorno lun 22 mar 2021 alle ore 12:37 Mohammad arshad
> <mo...@huawei.com> ha scritto:
>>
>> +1 (non-binding)
>>
>> Verified signature and checksum of release artifacts, all are ok
>> Run Junit test cases with jdk1.8.0_232, total 2951 test cases, 4
>> skipped, rest all passed
>> Built tarball from source code, installed 3 node cluster and
>> verified basic functionalities from API, executed few cli
>> commands. No issues observed
>> Connected HBase, HDFS and Yarn clusters (all using zk 3.5.6) to zk
>> 3.7.0 cluster, no issues observed.
>>
>> Thanks & Regards
>> Arshad
>> -----Original Message-----
>> From: Patrick Hunt [mailto:phunt@apache.org]
>> Sent: Saturday, March 20, 2021 5:17 AM
>> To: DevZooKeeper <de...@zookeeper.apache.org>
>> Subject: Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 2
>>
>> +1 xsum/sig validate. rat ran clean and I was able to compile (dep/cve
>> check passed) and manual verification of a few different cluster
>> sizes was successful.
>>
>> Regards,
>>
>> Patrick
>>
>>
>> On Wed, Mar 17, 2021 at 4:06 AM Damien Diederen <dd...@apache.org>
>> wrote:
>>
>> >
>> > Greetings, all!
>> >
>> > After a long delay, here is a third release candidate for ZooKeeper 3.7.0.
>> >
>> > Compared to RC1, it contains... quite a few changes.  It notably fixes
>> > the quota feature for multi transactions, repairs the test suite on
>> > macOS (Catalina), makes a few tests less flaky, and avoids a CVE.
>> >
>> > The complete set of changes can be obtained with the Git range
>> > expression 'release-3.7.0-1..release-3.7.0-2', or on GitHub at:
>> >
>> >
>> > https://github.com/apache/zookeeper/compare/release-3.7.0-1...release-
>> > 3.7.0-2
>> >
>> > I cannot say that I find the state of the test suite satisfactory, but
>> > the failures which are often observed are due to timing and/or TCP/IP
>> > port assignment issues, and repeated runs are "sufficient" to clear
>> > them.
>> >
>> > I was hoping to contribute more on that front, but have been unable so
>> > far, and don't want to keep the 3.7 branch hostage—so here is a timid
>> > RC2.
>> >
>> >
>> > ZooKeeper 3.7.0 introduces a number of new features, notably:
>> >
>> >   * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
>> >
>> >   * Quota enforcement (ZOOKEEPER-3301);
>> >
>> >   * Host name canonicalization in quorum SASL authentication
>> > (ZOOKEEPER-4030);
>> >
>> >   * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
>> >
>> >   * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);
>> >
>> >   * A "whoami" API and CLI command (ZOOKEEPER-3969);
>> >
>> >   * The possibility of disabling digest authentication
>> > (ZOOKEEPER-3979);
>> >
>> >   * Multiple SASL "superUsers" (ZOOKEEPER-3959);
>> >
>> >   * Fast-tracking of throttled requests (ZOOKEEPER-3683);
>> >
>> >   * Additional security metrics (ZOOKEEPER-3978);
>> >
>> >   * SASL support in the C and Perl clients (ZOOKEEPER-1112,
>> > ZOOKEEPER-3714);
>> >
>> >   * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
>> >
>> >   * Notes on how to benchmark ZooKeeper with the YCSB tool
>> > (ZOOKEEPER-3264).
>> >
>> >
>> > The release notes are available here:
>> >
>> >
>> > https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/websi
>> > te/releasenotes.html
>> >
>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310
>> > 801&version=12346617
>> >
>> > *** Please download, test and vote by March 21st 2021, 23:59 UTC+0.
>> > ***
>> >
>> > Source files:
>> >
>> >   https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/
>> >
>> > Maven staging repo:
>> >
>> >
>> > https://repository.apache.org/content/repositories/orgapachezookeeper-
>> > 1067/
>> >
>> > The release candidate tag in git to be voted upon: release-3.7.0-2
>> >
>> >   https://github.com/apache/zookeeper/tree/release-3.7.0-2
>> >
>> > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
>> >
>> >   https://www.apache.org/dist/zookeeper/KEYS
>> >
>> > The staging version of the website is:
>> >
>> >
>> > https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/websi
>> > te/
>> >
>> >
>> > Should we release this candidate?
>> >
>> >
>> > Damien Diederen
>> >

Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 2

Posted by Enrico Olivelli <eo...@gmail.com>.
+1 (binding)
- Build and run tests on Ubuntu (Java and C client) on jdk8
- verified rat,signatures,sha512sum,checkstyle and spotbugs (on JDK8)
- This time (for the first time!) I was able to build the C client on
MacOs (BigSur) !
- verified the list of License files in the binary tarball

great work Damien

Enrico

Il giorno lun 22 mar 2021 alle ore 12:37 Mohammad arshad
<mo...@huawei.com> ha scritto:
>
> +1 (non-binding)
>
> Verified signature and checksum of release artifacts, all are ok
> Run Junit test cases with jdk1.8.0_232, total 2951 test cases, 4 skipped, rest all passed
> Built tarball from source code, installed 3 node cluster and verified basic functionalities from API, executed few cli commands. No issues observed
> Connected HBase, HDFS and Yarn clusters (all using zk 3.5.6) to zk 3.7.0 cluster, no issues observed.
>
> Thanks & Regards
> Arshad
> -----Original Message-----
> From: Patrick Hunt [mailto:phunt@apache.org]
> Sent: Saturday, March 20, 2021 5:17 AM
> To: DevZooKeeper <de...@zookeeper.apache.org>
> Subject: Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 2
>
> +1 xsum/sig validate. rat ran clean and I was able to compile (dep/cve
> check passed) and manual verification of a few different cluster sizes was successful.
>
> Regards,
>
> Patrick
>
>
> On Wed, Mar 17, 2021 at 4:06 AM Damien Diederen <dd...@apache.org>
> wrote:
>
> >
> > Greetings, all!
> >
> > After a long delay, here is a third release candidate for ZooKeeper 3.7.0.
> >
> > Compared to RC1, it contains... quite a few changes.  It notably fixes
> > the quota feature for multi transactions, repairs the test suite on
> > macOS (Catalina), makes a few tests less flaky, and avoids a CVE.
> >
> > The complete set of changes can be obtained with the Git range
> > expression 'release-3.7.0-1..release-3.7.0-2', or on GitHub at:
> >
> >
> > https://github.com/apache/zookeeper/compare/release-3.7.0-1...release-
> > 3.7.0-2
> >
> > I cannot say that I find the state of the test suite satisfactory, but
> > the failures which are often observed are due to timing and/or TCP/IP
> > port assignment issues, and repeated runs are "sufficient" to clear
> > them.
> >
> > I was hoping to contribute more on that front, but have been unable so
> > far, and don't want to keep the 3.7 branch hostage—so here is a timid
> > RC2.
> >
> >
> > ZooKeeper 3.7.0 introduces a number of new features, notably:
> >
> >   * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
> >
> >   * Quota enforcement (ZOOKEEPER-3301);
> >
> >   * Host name canonicalization in quorum SASL authentication
> > (ZOOKEEPER-4030);
> >
> >   * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
> >
> >   * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);
> >
> >   * A "whoami" API and CLI command (ZOOKEEPER-3969);
> >
> >   * The possibility of disabling digest authentication
> > (ZOOKEEPER-3979);
> >
> >   * Multiple SASL "superUsers" (ZOOKEEPER-3959);
> >
> >   * Fast-tracking of throttled requests (ZOOKEEPER-3683);
> >
> >   * Additional security metrics (ZOOKEEPER-3978);
> >
> >   * SASL support in the C and Perl clients (ZOOKEEPER-1112,
> > ZOOKEEPER-3714);
> >
> >   * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
> >
> >   * Notes on how to benchmark ZooKeeper with the YCSB tool
> > (ZOOKEEPER-3264).
> >
> >
> > The release notes are available here:
> >
> >
> > https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/websi
> > te/releasenotes.html
> >
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310
> > 801&version=12346617
> >
> > *** Please download, test and vote by March 21st 2021, 23:59 UTC+0.
> > ***
> >
> > Source files:
> >
> >   https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/
> >
> > Maven staging repo:
> >
> >
> > https://repository.apache.org/content/repositories/orgapachezookeeper-
> > 1067/
> >
> > The release candidate tag in git to be voted upon: release-3.7.0-2
> >
> >   https://github.com/apache/zookeeper/tree/release-3.7.0-2
> >
> > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> >
> >   https://www.apache.org/dist/zookeeper/KEYS
> >
> > The staging version of the website is:
> >
> >
> > https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/websi
> > te/
> >
> >
> > Should we release this candidate?
> >
> >
> > Damien Diederen
> >

RE: [VOTE] Apache ZooKeeper release 3.7.0 candidate 2

Posted by Mohammad arshad <mo...@huawei.com>.
+1 (non-binding)

Verified signature and checksum of release artifacts, all are ok 
Run Junit test cases with jdk1.8.0_232, total 2951 test cases, 4 skipped, rest all passed
Built tarball from source code, installed 3 node cluster and verified basic functionalities from API, executed few cli commands. No issues observed
Connected HBase, HDFS and Yarn clusters (all using zk 3.5.6) to zk 3.7.0 cluster, no issues observed.

Thanks & Regards
Arshad
-----Original Message-----
From: Patrick Hunt [mailto:phunt@apache.org] 
Sent: Saturday, March 20, 2021 5:17 AM
To: DevZooKeeper <de...@zookeeper.apache.org>
Subject: Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 2

+1 xsum/sig validate. rat ran clean and I was able to compile (dep/cve
check passed) and manual verification of a few different cluster sizes was successful.

Regards,

Patrick


On Wed, Mar 17, 2021 at 4:06 AM Damien Diederen <dd...@apache.org>
wrote:

>
> Greetings, all!
>
> After a long delay, here is a third release candidate for ZooKeeper 3.7.0.
>
> Compared to RC1, it contains... quite a few changes.  It notably fixes 
> the quota feature for multi transactions, repairs the test suite on 
> macOS (Catalina), makes a few tests less flaky, and avoids a CVE.
>
> The complete set of changes can be obtained with the Git range 
> expression 'release-3.7.0-1..release-3.7.0-2', or on GitHub at:
>
>
> https://github.com/apache/zookeeper/compare/release-3.7.0-1...release-
> 3.7.0-2
>
> I cannot say that I find the state of the test suite satisfactory, but 
> the failures which are often observed are due to timing and/or TCP/IP 
> port assignment issues, and repeated runs are "sufficient" to clear 
> them.
>
> I was hoping to contribute more on that front, but have been unable so 
> far, and don't want to keep the 3.7 branch hostage—so here is a timid 
> RC2.
>
>
> ZooKeeper 3.7.0 introduces a number of new features, notably:
>
>   * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
>
>   * Quota enforcement (ZOOKEEPER-3301);
>
>   * Host name canonicalization in quorum SASL authentication 
> (ZOOKEEPER-4030);
>
>   * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
>
>   * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);
>
>   * A "whoami" API and CLI command (ZOOKEEPER-3969);
>
>   * The possibility of disabling digest authentication 
> (ZOOKEEPER-3979);
>
>   * Multiple SASL "superUsers" (ZOOKEEPER-3959);
>
>   * Fast-tracking of throttled requests (ZOOKEEPER-3683);
>
>   * Additional security metrics (ZOOKEEPER-3978);
>
>   * SASL support in the C and Perl clients (ZOOKEEPER-1112, 
> ZOOKEEPER-3714);
>
>   * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
>
>   * Notes on how to benchmark ZooKeeper with the YCSB tool 
> (ZOOKEEPER-3264).
>
>
> The release notes are available here:
>
>
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/websi
> te/releasenotes.html
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310
> 801&version=12346617
>
> *** Please download, test and vote by March 21st 2021, 23:59 UTC+0. 
> ***
>
> Source files:
>
>   https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/
>
> Maven staging repo:
>
>
> https://repository.apache.org/content/repositories/orgapachezookeeper-
> 1067/
>
> The release candidate tag in git to be voted upon: release-3.7.0-2
>
>   https://github.com/apache/zookeeper/tree/release-3.7.0-2
>
> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
>
>   https://www.apache.org/dist/zookeeper/KEYS
>
> The staging version of the website is:
>
>
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/websi
> te/
>
>
> Should we release this candidate?
>
>
> Damien Diederen
>

Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 2

Posted by Patrick Hunt <ph...@apache.org>.
+1 xsum/sig validate. rat ran clean and I was able to compile (dep/cve
check passed) and manual verification of a few different cluster sizes was
successful.

Regards,

Patrick


On Wed, Mar 17, 2021 at 4:06 AM Damien Diederen <dd...@apache.org>
wrote:

>
> Greetings, all!
>
> After a long delay, here is a third release candidate for ZooKeeper 3.7.0.
>
> Compared to RC1, it contains... quite a few changes.  It notably fixes
> the quota feature for multi transactions, repairs the test suite on
> macOS (Catalina), makes a few tests less flaky, and avoids a CVE.
>
> The complete set of changes can be obtained with the Git range
> expression 'release-3.7.0-1..release-3.7.0-2', or on GitHub at:
>
>
> https://github.com/apache/zookeeper/compare/release-3.7.0-1...release-3.7.0-2
>
> I cannot say that I find the state of the test suite satisfactory, but
> the failures which are often observed are due to timing and/or TCP/IP
> port assignment issues, and repeated runs are "sufficient" to clear
> them.
>
> I was hoping to contribute more on that front, but have been unable so
> far, and don't want to keep the 3.7 branch hostage—so here is a timid
> RC2.
>
>
> ZooKeeper 3.7.0 introduces a number of new features, notably:
>
>   * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
>
>   * Quota enforcement (ZOOKEEPER-3301);
>
>   * Host name canonicalization in quorum SASL authentication
> (ZOOKEEPER-4030);
>
>   * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
>
>   * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);
>
>   * A "whoami" API and CLI command (ZOOKEEPER-3969);
>
>   * The possibility of disabling digest authentication (ZOOKEEPER-3979);
>
>   * Multiple SASL "superUsers" (ZOOKEEPER-3959);
>
>   * Fast-tracking of throttled requests (ZOOKEEPER-3683);
>
>   * Additional security metrics (ZOOKEEPER-3978);
>
>   * SASL support in the C and Perl clients (ZOOKEEPER-1112,
> ZOOKEEPER-3714);
>
>   * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
>
>   * Notes on how to benchmark ZooKeeper with the YCSB tool
> (ZOOKEEPER-3264).
>
>
> The release notes are available here:
>
>
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/website/releasenotes.html
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346617
>
> *** Please download, test and vote by March 21st 2021, 23:59 UTC+0. ***
>
> Source files:
>
>   https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/
>
> Maven staging repo:
>
>
> https://repository.apache.org/content/repositories/orgapachezookeeper-1067/
>
> The release candidate tag in git to be voted upon: release-3.7.0-2
>
>   https://github.com/apache/zookeeper/tree/release-3.7.0-2
>
> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
>
>   https://www.apache.org/dist/zookeeper/KEYS
>
> The staging version of the website is:
>
>
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/website/
>
>
> Should we release this candidate?
>
>
> Damien Diederen
>

Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 2

Posted by Norbert Kalmar <nk...@cloudera.com.INVALID>.
+1 (non-binding)

- Built source (including running tests)
- Run and tested with basic commands from built source and also from bin
tarball
- Checked files included in tarballs

Minor side note: I had 2 failed tests on MacOS (ReadOnlyModeTest
and RequestPathMetricsCollectorTest), after re-running them they passed.

Thanks Damien, great work with the release!

- Norbert



On Fri, Mar 19, 2021 at 12:06 PM Szalay-Bekő Máté <
szalay.beko.mate@gmail.com> wrote:

> +1 (non-binding)
>
> Congrats Damien, nice job!
> And also the tests got definitely much more stable!
> (I had a single test that failed on my dockerized
> linux: RequestPathMetricsCollectorTest - but this one was successfully
> executed on my mac host, so possible it is only related to my docker
> environment)
>
> - I built the source code (-Pfull-build) on Ubuntu 18.04.3 using OpenJDK
> 11.0.10 and maven 3.6.0.
> - all the unit tests passed (both Java and C-client).
> - I also built and executed unit tests for zkpython
> - checkstyle and spotbugs passed
> - apache-rat passed
> - owasp (CVE check) passed
> - fatjar built
> - I also executed some quick rolling-upgrade tests from 3.5.9 to 3.7.0 and
> also from 3.6.2 to 3.7.0 (using
> https://github.com/symat/zk-rolling-upgrade-test)
>
> One minor website related issue: the tab on the top of the website page (
>
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/website/index.html
> )
> still says "ZooKeeper 3.6 Documentation"
>
> Kind regards,
> Mate
>
> On Wed, Mar 17, 2021 at 12:06 PM Damien Diederen <dd...@apache.org>
> wrote:
>
> >
> > Greetings, all!
> >
> > After a long delay, here is a third release candidate for ZooKeeper
> 3.7.0.
> >
> > Compared to RC1, it contains... quite a few changes.  It notably fixes
> > the quota feature for multi transactions, repairs the test suite on
> > macOS (Catalina), makes a few tests less flaky, and avoids a CVE.
> >
> > The complete set of changes can be obtained with the Git range
> > expression 'release-3.7.0-1..release-3.7.0-2', or on GitHub at:
> >
> >
> >
> https://github.com/apache/zookeeper/compare/release-3.7.0-1...release-3.7.0-2
> >
> > I cannot say that I find the state of the test suite satisfactory, but
> > the failures which are often observed are due to timing and/or TCP/IP
> > port assignment issues, and repeated runs are "sufficient" to clear
> > them.
> >
> > I was hoping to contribute more on that front, but have been unable so
> > far, and don't want to keep the 3.7 branch hostage—so here is a timid
> > RC2.
> >
> >
> > ZooKeeper 3.7.0 introduces a number of new features, notably:
> >
> >   * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
> >
> >   * Quota enforcement (ZOOKEEPER-3301);
> >
> >   * Host name canonicalization in quorum SASL authentication
> > (ZOOKEEPER-4030);
> >
> >   * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
> >
> >   * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);
> >
> >   * A "whoami" API and CLI command (ZOOKEEPER-3969);
> >
> >   * The possibility of disabling digest authentication (ZOOKEEPER-3979);
> >
> >   * Multiple SASL "superUsers" (ZOOKEEPER-3959);
> >
> >   * Fast-tracking of throttled requests (ZOOKEEPER-3683);
> >
> >   * Additional security metrics (ZOOKEEPER-3978);
> >
> >   * SASL support in the C and Perl clients (ZOOKEEPER-1112,
> > ZOOKEEPER-3714);
> >
> >   * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
> >
> >   * Notes on how to benchmark ZooKeeper with the YCSB tool
> > (ZOOKEEPER-3264).
> >
> >
> > The release notes are available here:
> >
> >
> >
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/website/releasenotes.html
> >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346617
> >
> > *** Please download, test and vote by March 21st 2021, 23:59 UTC+0. ***
> >
> > Source files:
> >
> >   https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/
> >
> > Maven staging repo:
> >
> >
> >
> https://repository.apache.org/content/repositories/orgapachezookeeper-1067/
> >
> > The release candidate tag in git to be voted upon: release-3.7.0-2
> >
> >   https://github.com/apache/zookeeper/tree/release-3.7.0-2
> >
> > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> >
> >   https://www.apache.org/dist/zookeeper/KEYS
> >
> > The staging version of the website is:
> >
> >
> >
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/website/
> >
> >
> > Should we release this candidate?
> >
> >
> > Damien Diederen
> >
>

Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 2

Posted by Szalay-Bekő Máté <sz...@gmail.com>.
+1 (non-binding)

Congrats Damien, nice job!
And also the tests got definitely much more stable!
(I had a single test that failed on my dockerized
linux: RequestPathMetricsCollectorTest - but this one was successfully
executed on my mac host, so possible it is only related to my docker
environment)

- I built the source code (-Pfull-build) on Ubuntu 18.04.3 using OpenJDK
11.0.10 and maven 3.6.0.
- all the unit tests passed (both Java and C-client).
- I also built and executed unit tests for zkpython
- checkstyle and spotbugs passed
- apache-rat passed
- owasp (CVE check) passed
- fatjar built
- I also executed some quick rolling-upgrade tests from 3.5.9 to 3.7.0 and
also from 3.6.2 to 3.7.0 (using
https://github.com/symat/zk-rolling-upgrade-test)

One minor website related issue: the tab on the top of the website page (
https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/website/index.html)
still says "ZooKeeper 3.6 Documentation"

Kind regards,
Mate

On Wed, Mar 17, 2021 at 12:06 PM Damien Diederen <dd...@apache.org>
wrote:

>
> Greetings, all!
>
> After a long delay, here is a third release candidate for ZooKeeper 3.7.0.
>
> Compared to RC1, it contains... quite a few changes.  It notably fixes
> the quota feature for multi transactions, repairs the test suite on
> macOS (Catalina), makes a few tests less flaky, and avoids a CVE.
>
> The complete set of changes can be obtained with the Git range
> expression 'release-3.7.0-1..release-3.7.0-2', or on GitHub at:
>
>
> https://github.com/apache/zookeeper/compare/release-3.7.0-1...release-3.7.0-2
>
> I cannot say that I find the state of the test suite satisfactory, but
> the failures which are often observed are due to timing and/or TCP/IP
> port assignment issues, and repeated runs are "sufficient" to clear
> them.
>
> I was hoping to contribute more on that front, but have been unable so
> far, and don't want to keep the 3.7 branch hostage—so here is a timid
> RC2.
>
>
> ZooKeeper 3.7.0 introduces a number of new features, notably:
>
>   * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
>
>   * Quota enforcement (ZOOKEEPER-3301);
>
>   * Host name canonicalization in quorum SASL authentication
> (ZOOKEEPER-4030);
>
>   * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
>
>   * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);
>
>   * A "whoami" API and CLI command (ZOOKEEPER-3969);
>
>   * The possibility of disabling digest authentication (ZOOKEEPER-3979);
>
>   * Multiple SASL "superUsers" (ZOOKEEPER-3959);
>
>   * Fast-tracking of throttled requests (ZOOKEEPER-3683);
>
>   * Additional security metrics (ZOOKEEPER-3978);
>
>   * SASL support in the C and Perl clients (ZOOKEEPER-1112,
> ZOOKEEPER-3714);
>
>   * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
>
>   * Notes on how to benchmark ZooKeeper with the YCSB tool
> (ZOOKEEPER-3264).
>
>
> The release notes are available here:
>
>
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/website/releasenotes.html
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346617
>
> *** Please download, test and vote by March 21st 2021, 23:59 UTC+0. ***
>
> Source files:
>
>   https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/
>
> Maven staging repo:
>
>
> https://repository.apache.org/content/repositories/orgapachezookeeper-1067/
>
> The release candidate tag in git to be voted upon: release-3.7.0-2
>
>   https://github.com/apache/zookeeper/tree/release-3.7.0-2
>
> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
>
>   https://www.apache.org/dist/zookeeper/KEYS
>
> The staging version of the website is:
>
>
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/website/
>
>
> Should we release this candidate?
>
>
> Damien Diederen
>

Re: [RESULT] [VOTE] Apache ZooKeeper release 3.7.0 candidate 2

Posted by Damien Diederen <dd...@apache.org>.
Hi Ted, all,

Ted Dunning <te...@gmail.com> writes:
> Btw... I would like to explicitly concur with the reading of my results
> as a non-vote.

Thank you for the confirmation!

Cheers, -D




> On Sat, Mar 27, 2021 at 2:42 AM Damien Diederen <dd...@apache.org>
> wrote:
>
>>
>> Greetings, all!
>>
>> I'm happy to announce that we have unanimously approved this release.
>>
>> There are 6 approving votes, 3 of which are binding:
>>
>> - Szalay-Bekő Máté
>> - Norbert Kalmar
>> - Patrick Hunt (binding)
>> - Mohammad arshad
>> - Enrico Olivelli (binding)
>> - Rakesh Radhakrishnan (binding)
>>
>> There are no disapproving votes.  Ted Dunning reported some issues he
>> encountered while testing: those are acknowledged—but also transient,
>> known, and understood, with progress ongoing on eliminating them.
>>
>> I will promote the artifacts and complete the release procedure.
>>
>> Thank you everybody for the great contributions!
>>
>> Damien Diederen
>>
>>
>>
>>
>> Damien Diederen <dd...@apache.org> writes:
>> > Greetings, all!
>> >
>> > After a long delay, here is a third release candidate for ZooKeeper
>> 3.7.0.
>> >
>> > Compared to RC1, it contains... quite a few changes.  It notably fixes
>> > the quota feature for multi transactions, repairs the test suite on
>> > macOS (Catalina), makes a few tests less flaky, and avoids a CVE.
>> >
>> > The complete set of changes can be obtained with the Git range
>> > expression 'release-3.7.0-1..release-3.7.0-2', or on GitHub at:
>> >
>> >
>> https://github.com/apache/zookeeper/compare/release-3.7.0-1...release-3.7.0-2
>> >
>> > I cannot say that I find the state of the test suite satisfactory, but
>> > the failures which are often observed are due to timing and/or TCP/IP
>> > port assignment issues, and repeated runs are "sufficient" to clear
>> > them.
>> >
>> > I was hoping to contribute more on that front, but have been unable so
>> > far, and don't want to keep the 3.7 branch hostage—so here is a timid
>> > RC2.
>> >
>> >
>> > ZooKeeper 3.7.0 introduces a number of new features, notably:
>> >
>> >   * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
>> >
>> >   * Quota enforcement (ZOOKEEPER-3301);
>> >
>> >   * Host name canonicalization in quorum SASL authentication
>> (ZOOKEEPER-4030);
>> >
>> >   * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
>> >
>> >   * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);
>> >
>> >   * A "whoami" API and CLI command (ZOOKEEPER-3969);
>> >
>> >   * The possibility of disabling digest authentication (ZOOKEEPER-3979);
>> >
>> >   * Multiple SASL "superUsers" (ZOOKEEPER-3959);
>> >
>> >   * Fast-tracking of throttled requests (ZOOKEEPER-3683);
>> >
>> >   * Additional security metrics (ZOOKEEPER-3978);
>> >
>> >   * SASL support in the C and Perl clients (ZOOKEEPER-1112,
>> ZOOKEEPER-3714);
>> >
>> >   * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
>> >
>> >   * Notes on how to benchmark ZooKeeper with the YCSB tool
>> (ZOOKEEPER-3264).
>> >
>> >
>> > The release notes are available here:
>> >
>> >
>> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/website/releasenotes.html
>> >
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346617
>> >
>> > *** Please download, test and vote by March 21st 2021, 23:59 UTC+0. ***
>> >
>> > Source files:
>> >
>> >   https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/
>> >
>> > Maven staging repo:
>> >
>> >
>> https://repository.apache.org/content/repositories/orgapachezookeeper-1067/
>> >
>> > The release candidate tag in git to be voted upon: release-3.7.0-2
>> >
>> >   https://github.com/apache/zookeeper/tree/release-3.7.0-2
>> >
>> > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
>> >
>> >   https://www.apache.org/dist/zookeeper/KEYS
>> >
>> > The staging version of the website is:
>> >
>> >
>> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/website/
>> >
>> >
>> > Should we release this candidate?
>> >
>> >
>> > Damien Diederen
>>

Re: [RESULT] [VOTE] Apache ZooKeeper release 3.7.0 candidate 2

Posted by Ted Dunning <te...@gmail.com>.
Btw... I would like to explicitly concur with the reading of my results
as a non-vote.



On Sat, Mar 27, 2021 at 2:42 AM Damien Diederen <dd...@apache.org>
wrote:

>
> Greetings, all!
>
> I'm happy to announce that we have unanimously approved this release.
>
> There are 6 approving votes, 3 of which are binding:
>
> - Szalay-Bekő Máté
> - Norbert Kalmar
> - Patrick Hunt (binding)
> - Mohammad arshad
> - Enrico Olivelli (binding)
> - Rakesh Radhakrishnan (binding)
>
> There are no disapproving votes.  Ted Dunning reported some issues he
> encountered while testing: those are acknowledged—but also transient,
> known, and understood, with progress ongoing on eliminating them.
>
> I will promote the artifacts and complete the release procedure.
>
> Thank you everybody for the great contributions!
>
> Damien Diederen
>
>
>
>
> Damien Diederen <dd...@apache.org> writes:
> > Greetings, all!
> >
> > After a long delay, here is a third release candidate for ZooKeeper
> 3.7.0.
> >
> > Compared to RC1, it contains... quite a few changes.  It notably fixes
> > the quota feature for multi transactions, repairs the test suite on
> > macOS (Catalina), makes a few tests less flaky, and avoids a CVE.
> >
> > The complete set of changes can be obtained with the Git range
> > expression 'release-3.7.0-1..release-3.7.0-2', or on GitHub at:
> >
> >
> https://github.com/apache/zookeeper/compare/release-3.7.0-1...release-3.7.0-2
> >
> > I cannot say that I find the state of the test suite satisfactory, but
> > the failures which are often observed are due to timing and/or TCP/IP
> > port assignment issues, and repeated runs are "sufficient" to clear
> > them.
> >
> > I was hoping to contribute more on that front, but have been unable so
> > far, and don't want to keep the 3.7 branch hostage—so here is a timid
> > RC2.
> >
> >
> > ZooKeeper 3.7.0 introduces a number of new features, notably:
> >
> >   * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
> >
> >   * Quota enforcement (ZOOKEEPER-3301);
> >
> >   * Host name canonicalization in quorum SASL authentication
> (ZOOKEEPER-4030);
> >
> >   * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
> >
> >   * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);
> >
> >   * A "whoami" API and CLI command (ZOOKEEPER-3969);
> >
> >   * The possibility of disabling digest authentication (ZOOKEEPER-3979);
> >
> >   * Multiple SASL "superUsers" (ZOOKEEPER-3959);
> >
> >   * Fast-tracking of throttled requests (ZOOKEEPER-3683);
> >
> >   * Additional security metrics (ZOOKEEPER-3978);
> >
> >   * SASL support in the C and Perl clients (ZOOKEEPER-1112,
> ZOOKEEPER-3714);
> >
> >   * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
> >
> >   * Notes on how to benchmark ZooKeeper with the YCSB tool
> (ZOOKEEPER-3264).
> >
> >
> > The release notes are available here:
> >
> >
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/website/releasenotes.html
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346617
> >
> > *** Please download, test and vote by March 21st 2021, 23:59 UTC+0. ***
> >
> > Source files:
> >
> >   https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/
> >
> > Maven staging repo:
> >
> >
> https://repository.apache.org/content/repositories/orgapachezookeeper-1067/
> >
> > The release candidate tag in git to be voted upon: release-3.7.0-2
> >
> >   https://github.com/apache/zookeeper/tree/release-3.7.0-2
> >
> > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> >
> >   https://www.apache.org/dist/zookeeper/KEYS
> >
> > The staging version of the website is:
> >
> >
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/website/
> >
> >
> > Should we release this candidate?
> >
> >
> > Damien Diederen
>

[RESULT] [VOTE] Apache ZooKeeper release 3.7.0 candidate 2

Posted by Damien Diederen <dd...@apache.org>.
Greetings, all!

I'm happy to announce that we have unanimously approved this release.
 
There are 6 approving votes, 3 of which are binding:
 
- Szalay-Bekő Máté
- Norbert Kalmar
- Patrick Hunt (binding)
- Mohammad arshad
- Enrico Olivelli (binding)
- Rakesh Radhakrishnan (binding)

There are no disapproving votes.  Ted Dunning reported some issues he
encountered while testing: those are acknowledged—but also transient,
known, and understood, with progress ongoing on eliminating them.
 
I will promote the artifacts and complete the release procedure.

Thank you everybody for the great contributions!
 
Damien Diederen




Damien Diederen <dd...@apache.org> writes:
> Greetings, all!
>
> After a long delay, here is a third release candidate for ZooKeeper 3.7.0.
>
> Compared to RC1, it contains... quite a few changes.  It notably fixes
> the quota feature for multi transactions, repairs the test suite on
> macOS (Catalina), makes a few tests less flaky, and avoids a CVE.
>
> The complete set of changes can be obtained with the Git range
> expression 'release-3.7.0-1..release-3.7.0-2', or on GitHub at:
>
>   https://github.com/apache/zookeeper/compare/release-3.7.0-1...release-3.7.0-2
>
> I cannot say that I find the state of the test suite satisfactory, but
> the failures which are often observed are due to timing and/or TCP/IP
> port assignment issues, and repeated runs are "sufficient" to clear
> them.
>
> I was hoping to contribute more on that front, but have been unable so
> far, and don't want to keep the 3.7 branch hostage—so here is a timid
> RC2.
>
>
> ZooKeeper 3.7.0 introduces a number of new features, notably:
>
>   * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
>
>   * Quota enforcement (ZOOKEEPER-3301);
>
>   * Host name canonicalization in quorum SASL authentication (ZOOKEEPER-4030);
>
>   * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
>
>   * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);
>
>   * A "whoami" API and CLI command (ZOOKEEPER-3969);
>
>   * The possibility of disabling digest authentication (ZOOKEEPER-3979);
>
>   * Multiple SASL "superUsers" (ZOOKEEPER-3959);
>
>   * Fast-tracking of throttled requests (ZOOKEEPER-3683);
>
>   * Additional security metrics (ZOOKEEPER-3978);
>
>   * SASL support in the C and Perl clients (ZOOKEEPER-1112, ZOOKEEPER-3714);
>
>   * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
>
>   * Notes on how to benchmark ZooKeeper with the YCSB tool (ZOOKEEPER-3264).
>
>
> The release notes are available here:
>
>   https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/website/releasenotes.html
>   https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346617
>
> *** Please download, test and vote by March 21st 2021, 23:59 UTC+0. ***
>
> Source files:
>
>   https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/
>
> Maven staging repo:
>
>   https://repository.apache.org/content/repositories/orgapachezookeeper-1067/
>
> The release candidate tag in git to be voted upon: release-3.7.0-2
>
>   https://github.com/apache/zookeeper/tree/release-3.7.0-2
>
> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
>
>   https://www.apache.org/dist/zookeeper/KEYS
>
> The staging version of the website is:
>
>   https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/website/
>
>
> Should we release this candidate?
>
>
> Damien Diederen

[VOTE] Apache ZooKeeper release 3.7.0 candidate 2

Posted by Damien Diederen <dd...@apache.org>.
Greetings, all!

After a long delay, here is a third release candidate for ZooKeeper 3.7.0.

Compared to RC1, it contains... quite a few changes.  It notably fixes
the quota feature for multi transactions, repairs the test suite on
macOS (Catalina), makes a few tests less flaky, and avoids a CVE.

The complete set of changes can be obtained with the Git range
expression 'release-3.7.0-1..release-3.7.0-2', or on GitHub at:

  https://github.com/apache/zookeeper/compare/release-3.7.0-1...release-3.7.0-2

I cannot say that I find the state of the test suite satisfactory, but
the failures which are often observed are due to timing and/or TCP/IP
port assignment issues, and repeated runs are "sufficient" to clear
them.

I was hoping to contribute more on that front, but have been unable so
far, and don't want to keep the 3.7 branch hostage—so here is a timid
RC2.


ZooKeeper 3.7.0 introduces a number of new features, notably:

  * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);

  * Quota enforcement (ZOOKEEPER-3301);

  * Host name canonicalization in quorum SASL authentication (ZOOKEEPER-4030);

  * Support for BCFKS key/trust store format (ZOOKEEPER-3950);

  * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);

  * A "whoami" API and CLI command (ZOOKEEPER-3969);

  * The possibility of disabling digest authentication (ZOOKEEPER-3979);

  * Multiple SASL "superUsers" (ZOOKEEPER-3959);

  * Fast-tracking of throttled requests (ZOOKEEPER-3683);

  * Additional security metrics (ZOOKEEPER-3978);

  * SASL support in the C and Perl clients (ZOOKEEPER-1112, ZOOKEEPER-3714);

  * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);

  * Notes on how to benchmark ZooKeeper with the YCSB tool (ZOOKEEPER-3264).


The release notes are available here:

  https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/website/releasenotes.html
  https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346617

*** Please download, test and vote by March 21st 2021, 23:59 UTC+0. ***

Source files:

  https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/

Maven staging repo:

  https://repository.apache.org/content/repositories/orgapachezookeeper-1067/

The release candidate tag in git to be voted upon: release-3.7.0-2

  https://github.com/apache/zookeeper/tree/release-3.7.0-2

ZooKeeper's KEYS file containing PGP keys we use to sign the release:

  https://www.apache.org/dist/zookeeper/KEYS

The staging version of the website is:

  https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-2/website/


Should we release this candidate?


Damien Diederen

[VOTE] Apache ZooKeeper release 3.7.0 candidate 1

Posted by Damien Diederen <dd...@apache.org>.
Dear all,

This is a second release candidate for ZooKeeper 3.7.0.  Compared to
RC0, it fixes a tarball generation issue, includes a description of the
'whoami' CLI command, and incorporates a contribution to ZooInspector.

ZooKeeper 3.7.0 introduces a number of new features, notably:

  * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
  
  * Quota enforcement (ZOOKEEPER-3301);
  
  * Host name canonicalization in quorum SASL authentication (ZOOKEEPER-4030);

  * Support for BCFKS key/trust store format (ZOOKEEPER-3950);

  * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);

  * A "whoami" API and CLI command (ZOOKEEPER-3969);

  * The possibility of disabling digest authentication (ZOOKEEPER-3979);
  
  * Multiple SASL "superUsers" (ZOOKEEPER-3959);
  
  * Fast-tracking of throttled requests (ZOOKEEPER-3683);
    
  * Additional security metrics (ZOOKEEPER-3978);

  * SASL support in the C and Perl clients (ZOOKEEPER-1112, ZOOKEEPER-3714);

  * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);

  * Notes on how to benchmark ZooKeeper with the YCSB tool (ZOOKEEPER-3264).

The release notes are available here:
  
  https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/website/releasenotes.html
  https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346617

*** Please download, test and vote by January 31st 2020, 23:59 UTC+0. ***

Source files:

  https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/

Maven staging repo:

  https://repository.apache.org/content/repositories/orgapachezookeeper-1066/

The release candidate tag in git to be voted upon: release-3.7.0-1

  https://github.com/apache/zookeeper/tree/release-3.7.0-1

ZooKeeper's KEYS file containing PGP keys we use to sign the release:

  https://www.apache.org/dist/zookeeper/KEYS

The staging version of the website is:

  https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-1/website/

Should we release this candidate?

Damien Diederen

Re: [VOTE] Apache ZooKeeper release 3.7.0 candidate 0

Posted by Patrick Hunt <ph...@apache.org>.
+1 - xsum/sig validated. Compiles/runs fine on macos+jdk11. Verified some
larger ensemble sizes manually and it worked ok.

I looked at a few of the new features listed - they look great! I did
notice some changes without documentation though (whoami eg), would be good
for committers to ensure that docs get updated along the way...

Thanks Damien for acting as RM. Regards,

Patrick

On Tue, Jan 19, 2021 at 4:40 AM Damien Diederen <dd...@apache.org>
wrote:

>
> Dear all,
>
> This is a first release candidate for ZooKeeper 3.7.0.
>
> It introduces a number of new features, notably:
>
>   * An API to start a ZooKeeper server from Java (ZOOKEEPER-3874);
>
>   * Quota enforcement (ZOOKEEPER-3301);
>
>   * Host name canonicalization in quorum SASL authentication
> (ZOOKEEPER-4030);
>
>   * Support for BCFKS key/trust store format (ZOOKEEPER-3950);
>
>   * A choice of mandatory authentication scheme(s) (ZOOKEEPER-3561);
>
>   * A "whoami" API and CLI command (ZOOKEEPER-3969);
>
>   * The possibility of disabling digest authentication (ZOOKEEPER-3979);
>
>   * Multiple SASL "superUsers" (ZOOKEEPER-3959);
>
>   * Fast-tracking of throttled requests (ZOOKEEPER-3683);
>
>   * Additional security metrics (ZOOKEEPER-3978);
>
>   * SASL support in the C and Perl clients (ZOOKEEPER-1112,
> ZOOKEEPER-3714);
>
>   * A new zkSnapshotComparer.sh tool (ZOOKEEPER-3427);
>
>   * Notes on how to benchmark ZooKeeper with the YCSB tool
> (ZOOKEEPER-3264).
>
> The release notes are available here:
>
>
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-0/website/releasenotes.html
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346617
>
> *** Please download, test and vote by January 24th 2020, 23:59 UTC+0. ***
>
> Source files:
>
>   https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-0/
>
> Maven staging repo:
>
>
> https://repository.apache.org/content/repositories/orgapachezookeeper-1065/
>
> The release candidate tag in git to be voted upon: release-3.7.0-0
>
>   https://github.com/apache/zookeeper/tree/release-3.7.0-0
>
> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
>
>   https://www.apache.org/dist/zookeeper/KEYS
>
> The staging version of the website is:
>
>
> https://people.apache.org/~ddiederen/zookeeper-3.7.0-candidate-0/website/
>
> Should we release this candidate?
>
> Damien Diederen
>
>