You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by sunjincheng121 <gi...@git.apache.org> on 2017/03/10 03:56:33 UTC

[GitHub] flink pull request #3503: [FLINK-5995][checkpoints] fix Get a Exception when...

GitHub user sunjincheng121 opened a pull request:

    https://github.com/apache/flink/pull/3503

    [FLINK-5995][checkpoints] fix Get a Exception when creating the ListS\u2026

    \u2026tateDescriptor with a TypeInformation
    
    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [�] General
      - The pull request references the related JIRA issue ("[FLINK-5995] Fix Get a Exception when creating the ListStateDescriptor with a TypeInformation")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sunjincheng121/flink FLINK-5995-PR

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3503.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3503
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3503: [FLINK-5995][checkpoints] fix Get a Exception when creati...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3503
  
    Looks good, merging this...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3503: [FLINK-5995][checkpoints] fix Get a Exception when creati...

Posted by sunjincheng121 <gi...@git.apache.org>.

Github user sunjincheng121 commented on the issue:

    https://github.com/apache/flink/pull/3503
  
    @StephanEwen I had update the PR. I appreciated if you can review this PR.
    Best,
    SunJincheng


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3503: [FLINK-5995][checkpoints] fix Get a Exception when creati...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3503
  
    Thanks for finding and fixing this, important fix!
    
    It would be great if you could add a test for this, to make sure the bug is not accidentally re-introduced later by someone. You can follow the pattern of this test: `flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/StateDescriptorPassingTest.java`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3503: [FLINK-5995][checkpoints] fix Get a Exception when creati...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3503
  
    That sounds reasonable!
    
    On Mar 10, 2017 4:07 PM, "Jincheng Sun" <no...@github.com> wrote:
    
    > Hi,@StephanEwen <https://github.com/StephanEwen>, Thanks a lot for your
    > comment. I seriously think about where to add the test more is reasonable,
    > because the change of this PR is OperatorStateBackend, so I added the
    > test case injava/ src/test/java/org/apache/flink/runtime/state/
    > operatorStateBackendTest.java Is this make sense for you? feel free to
    > tell me if it is incorrect.
    > Best,
    > SunJincheng
    >
    > \u2014
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/flink/pull/3503#issuecomment-285692212>, or mute
    > the thread
    > <https://github.com/notifications/unsubscribe-auth/ABpaqtxMMNduF1zFO5Ph5Q_0A70z99njks5rkWctgaJpZM4MY8Na>
    > .
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3503: [FLINK-5995][checkpoints] fix Get a Exception when creati...

Posted by sunjincheng121 <gi...@git.apache.org>.

Github user sunjincheng121 commented on the issue:

    https://github.com/apache/flink/pull/3503
  
    @StephanEwen I added a test to make sure the `ExecutionConfig` was passed, but I'm not sure whether I understand you correctly. feel free to tell me If it is not right.
    Thanks,
    SunJincheng 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3503: [FLINK-5995][checkpoints] fix Get a Exception when creati...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3503
  
    Looks good. I would actually like to extend the test by one more, just to make sure that the proper `ExecutionConfig` is passed (which is not currently tested - the execution config in the test is null).
    
    A good way to do that would be to create a state of some non-standard type (like `File`) which goes to Kryo and then check that Kryo has the proper registration from the execution config.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3503: [FLINK-5995][checkpoints] fix Get a Exception when creati...

Posted by sunjincheng121 <gi...@git.apache.org>.

Github user sunjincheng121 commented on the issue:

    https://github.com/apache/flink/pull/3503
  
    Hi,@StephanEwen, Thanks a lot for your comment. I seriously think about where to add the test more is reasonable, because the change of this PR is `OperatorStateBackend`, so I added the test case in`java/ src/test/java/org/apache/flink/runtime/state/operatorStateBackendTest.java` Is this make sense for you? feel free to tell me if it is incorrect.
    Best,
    SunJincheng


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---