You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2025/12/01 12:18:22 UTC
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
kollar.nandor@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23721
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
---
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalog.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
3 files changed, 37 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/23721/1
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Daniel Vanko (Code Review)" <ge...@cloudera.org>.
Daniel Vanko has posted comments on this change. ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
Patch Set 1:
(1 comment)
Please also add E2E tests to /testdata/workloads/functional-query/queries/QueryTest/iceberg-migrate-from-external-hdfs-tables.test
Thanks for working on this!
http://gerrit.cloudera.org:8080/#/c/23721/1/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
File fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java:
http://gerrit.cloudera.org:8080/#/c/23721/1/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java@138
PS1, Line 138: if (TIcebergCatalog.HADOOP_CATALOG == IcebergUtil.getTIcebergCatalog(properties_)) {
: throw new AnalysisException("The Hadoop Catalog is not supported because the " +
: "location may change");
: }
Maybe move this to L119 so all check on properties will be together? With condition: if (IcebergUtil.getTIcebergCatalog(value) == TIcebergCatalog.HADOOP_CATALOG)
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Dec 2025 13:58:53 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
Patch Set 5:
(1 comment)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/23721/5/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
File fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java:
http://gerrit.cloudera.org:8080/#/c/23721/5/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java@120
PS5, Line 120: throw new AnalysisException("The Hadoop Catalog is not supported because the " +
line too long (94 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Dec 2025 13:39:23 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/21091/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Dec 2025 14:39:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Daniel Vanko (Code Review)" <ge...@cloudera.org>.
Daniel Vanko has posted comments on this change. ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
Patch Set 11: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 11
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Dec 2025 12:45:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
kollar.nandor@gmail.com has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
This change allows modifying the format version table property
in ALTER TABLE CONVERT TO statements. It adds verification for
the property value too: only 1 or 2 is supported as of now.
Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
---
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalog.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-migrate-from-external-hdfs-tables.test
4 files changed, 66 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/23721/6
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
kollar.nandor@gmail.com has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
This change allows modifying the format version table property
in ALTER TABLE CONVERT TO statements. It adds verification for
the property value too: only 1 or 2 is supported as of now.
Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
---
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalog.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-migrate-from-external-hdfs-tables.test
4 files changed, 65 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/23721/9
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 9
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
Patch Set 10:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12762/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 10
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Dec 2025 13:01:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
Patch Set 11: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 11
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Dec 2025 12:46:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
kollar.nandor@gmail.com has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
This change allows modifying the format version table property
in ALTER TABLE CONVERT TO statements. It adds verification for
the property value too: only 1 or 2 is supported as of now.
Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
---
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalog.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-migrate-from-external-hdfs-tables.test
4 files changed, 60 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/23721/5
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Daniel Vanko (Code Review)" <ge...@cloudera.org>.
Daniel Vanko has posted comments on this change. ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
Patch Set 6:
(1 comment)
After fixing the identation in AnalyzeStmtsTest.java, it's good to go for me.
http://gerrit.cloudera.org:8080/#/c/23721/6/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java:
http://gerrit.cloudera.org:8080/#/c/23721/6/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@5224
PS6, Line 5224: AnalyzesOk("alter table functional_parquet.tinytable convert to iceberg"
: + " tblproperties('format-version'='1')");
: AnalyzesOk("alter table functional_parquet.tinytable convert to iceberg"
: + " tblproperties('format-version'='2')");
: AnalysisError("alter table functional_parquet.tinytable convert to iceberg"
: + " tblproperties('format-version'='3')",
: "Unsupported Iceberg format version '3'");
: AnalysisError("alter table functional_parquet.tinytable convert to iceberg"
: + " tblproperties('format-version'='unknown')",
: "Invalid Iceberg format version 'unknown'");
: AnalysisError("alter table functional_parquet.tinytable convert to iceberg"
: + " tblproperties('metadata.generator.threads'='a1')",
: "CONVERT TO ICEBERG doesn't accept 'metadata.generator.threads' as TBLPROPERTY.");
Identation is off by 2 spaces.
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Dec 2025 10:06:40 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/21092/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Dec 2025 15:51:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
Patch Set 12: Verified+1
query_test.test_scanners.TestHdfsScannerSkew.test_mt_dop_skew_lpt failed in the check job, it's known to be flaky (https://issues.apache.org/jira/browse/IMPALA-11572), and it's not related to this change
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 12
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Dec 2025 08:14:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
kollar.nandor@gmail.com has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
This change allows modifying the format version table property
in ALTER TABLE CONVERT TO statements. It adds verification for
the property value too: only 1 or 2 is supported as of now.
Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
---
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalog.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-migrate-from-external-hdfs-tables.test
4 files changed, 66 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/23721/8
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 8
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
Patch Set 11:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/21136/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 11
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Dec 2025 09:35:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
Patch Set 12: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12780/
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 12
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Dec 2025 17:44:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/21055/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Dec 2025 12:41:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
kollar.nandor@gmail.com has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
This change allows modifying the format version table property
in ALTER TABLE CONVERT TO statements. It adds verification for
the property value too: only 1 or 2 is supported as of now.
Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
---
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalog.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-migrate-from-external-hdfs-tables.test
4 files changed, 64 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/23721/11
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 11
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
Patch Set 12:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12780/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 12
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Dec 2025 12:47:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/21090/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Dec 2025 14:01:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/21067/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Dec 2025 13:38:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
kollar.nandor@gmail.com has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
---
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalog.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
3 files changed, 36 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/23721/2
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
Patch Set 1:
(2 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/23721/1/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
File fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java:
http://gerrit.cloudera.org:8080/#/c/23721/1/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java@128
PS1, Line 128: throw new AnalysisException(String.format("Unsupported Iceberg format version '%s'.", formatVersion));
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/23721/1/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java@130
PS1, Line 130: throw new AnalysisException(String.format("Invalid Iceberg format version '%s'.", value));
line too long (106 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Dec 2025 12:20:32 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has removed a vote on this change.
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 12
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 9
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Dec 2025 13:48:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
kollar.nandor@gmail.com has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
This change allows modifying the format version table property
in ALTER TABLE CONVERT TO statements. It adds verification for
the property value too: only 1 or 2 is supported as of now.
Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
---
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalog.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-migrate-from-external-hdfs-tables.test
4 files changed, 66 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/23721/7
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 7
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
Patch Set 6: Code-Review+1
Thanks, Nandor!
Let's wait for Daniel's response, it looks good to me!
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Dec 2025 09:45:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
Patch Set 12: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 12
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Dec 2025 12:47:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
This change allows modifying the format version table property
in ALTER TABLE CONVERT TO statements. It adds verification for
the property value too: only 1 or 2 is supported as of now.
Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Reviewed-on: http://gerrit.cloudera.org:8080/23721
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Peter Rozsa <pr...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalog.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-migrate-from-external-hdfs-tables.test
4 files changed, 64 insertions(+), 20 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved
Peter Rozsa: Verified
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 13
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
kollar.nandor@gmail.com has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
This change allows modifying the format version table property
in ALTER TABLE CONVERT TO statements. It adds verification for
the property value too: only 1 or 2 is supported as of now.
Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
---
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalog.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-migrate-from-external-hdfs-tables.test
4 files changed, 54 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/23721/4
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Daniel Vanko (Code Review)" <ge...@cloudera.org>.
Daniel Vanko has posted comments on this change. ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
Patch Set 9: Code-Review+1
LGTM, thanks!
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 9
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Dec 2025 12:39:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
Patch Set 10: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 10
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Dec 2025 13:01:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
Patch Set 10: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12762/
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 10
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Dec 2025 18:45:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
Posted by "Daniel Vanko (Code Review)" <ge...@cloudera.org>.
Daniel Vanko has posted comments on this change. ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO
......................................................................
Patch Set 10:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/23721/10/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
File fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java:
http://gerrit.cloudera.org:8080/#/c/23721/10/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java@27
PS10, Line 27: import org.apache.iceberg.TableProperties;
So we don't need this import.
http://gerrit.cloudera.org:8080/#/c/23721/10/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java@132
PS10, Line 132: TableProperties.FORMAT_VERSION
Then we should also use IcebergTable.FORMAT_VERSION here.
http://gerrit.cloudera.org:8080/#/c/23721/10/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java@135
PS10, Line 135: if (formatVersion == TableProperties.FORMAT_VERSION_1
: || formatVersion == TableProperties.FORMAT_VERSION_2)
Use IcebergTable.ICEBERG_FORMAT_V1 and IcebergTable.ICEBERG_FORMAT_V2 instead. My guess is that iceberg.TableProperties doesn't have these in older Iceberg versions, that's why GVD failed.
--
To view, visit http://gerrit.cloudera.org:8080/23721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865
Gerrit-Change-Number: 23721
Gerrit-PatchSet: 10
Gerrit-Owner: Anonymous Coward <ko...@gmail.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Dec 2025 22:34:48 +0000
Gerrit-HasComments: Yes