You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Fabien COELHO <fa...@coelho.net> on 2008/09/05 14:34:55 UTC
Re: svn commit: r32924 - trunk/tools/client-side
> (_svn, _svnadmin): Use '+=' for appending to variables and fix indentation.
That looks good, but it is bash-3 specific:-(
shell> echo $BASH_VERSION
2.05b.0(1)-release
shell> foo=bla
shell> foo+=bli
-bash: foo+=bli: command not found
shell> svn <TAB>
-bash: cmds+= commit ci copy cp delete remove rm diff export help import: command not found
-bash: cmds+= info list ls lock log merge mergeinfo mkdir move mv rename: command not found
-bash: cmds+= propdel pdel propedit pedit propget pget proplist plist: command not found
-bash: cmds+= propset pset resolve resolved revert status switch unlock: command not found
-bash: cmds+= update: command not found
-bash: optsParam+=|-x|--extensions|-m|--message|-F|--file: command not found
-bash: optsParam+=|--encoding|--diff-cmd|--diff3-cmd|--editor-cmd: command not found
-bash: optsParam+=|--old|--new|--config-dir|--native-eol|-l|--limit: command not found
-bash: optsParam+=|-c|--change|--depth|--set-depth|--with-revprop: command not found
-bash: optsParam+=|--changelist|--accept|--show-revs: command not found
--
Fabien.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r32924 - trunk/tools/client-side
Posted by Fabien COELHO <fa...@coelho.net>.
>> That looks good, but it is bash-3 specific:-(
>
> bash-3.0 was released on 2004-07-27.
> Why do you still use bash-2.*?
- Welcome to the real world:-)
- We still have servers in Debian Sarge. If you want to come here and do
the necessary updates without breaking everything, fine:-)
- I just raise an issue. We can decide no break support for bash2. The
comments in the bash_completion mention bash2 compatibility, and ISTM that
it was still the case before the patch.
--
Fabien.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r32924 - trunk/tools/client-side
Posted by Karl Fogel <kf...@red-bean.com>.
I wrote:
> It does seem silly to break compatibility for some users simply so we
> can have slight improvement in expressiveness (that is, using '+='
> instead of 'string = "$string ..."'). Couldn't we revert the '+=' part
> of the change and have an easy win for some users?
>
> If there were some new *feature* enabled by Bash 3, that would be
> different. But we're just talking about a rather minor internal coding
> thing here.
Ah, and then later I saw r32937. Never mind.
-K
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r32924 - trunk/tools/client-side
Posted by Karl Fogel <kf...@red-bean.com>.
Marc Haisenko <ha...@comdasys.com> writes:
> On Friday 05 September 2008 16:40:35 Arfrever Frehtes Taifersar Arahesis
> wrote:
>> 2008-09-05 16:34:55 Fabien COELHO napisał(a):
>> > > (_svn, _svnadmin): Use '+=' for appending to variables and fix
>> > > indentation.
>> >
>> > That looks good, but it is bash-3 specific:-(
>>
>> bash-3.0 was released on 2004-07-27.
>> Why do you still use bash-2.*?
>
> Like that would be a crime or something...
>
> We also do have servers with bash 2.x (and our products do as well) and I
> suspect in every company with more than say 10 Unix/Linux servers you will
> find bash 2.x.
>
> That's simply because of "don't fix it if it ain't broken". Why update a
> server that has proven to do its job reliably ?
It does seem silly to break compatibility for some users simply so we
can have slight improvement in expressiveness (that is, using '+='
instead of 'string = "$string ..."'). Couldn't we revert the '+=' part
of the change and have an easy win for some users?
If there were some new *feature* enabled by Bash 3, that would be
different. But we're just talking about a rather minor internal coding
thing here.
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r32924 - trunk/tools/client-side
Posted by Marc Haisenko <ha...@comdasys.com>.
On Friday 05 September 2008 16:40:35 Arfrever Frehtes Taifersar Arahesis
wrote:
> 2008-09-05 16:34:55 Fabien COELHO napisał(a):
> > > (_svn, _svnadmin): Use '+=' for appending to variables and fix
> > > indentation.
> >
> > That looks good, but it is bash-3 specific:-(
>
> bash-3.0 was released on 2004-07-27.
> Why do you still use bash-2.*?
Like that would be a crime or something...
We also do have servers with bash 2.x (and our products do as well) and I
suspect in every company with more than say 10 Unix/Linux servers you will
find bash 2.x.
That's simply because of "don't fix it if it ain't broken". Why update a
server that has proven to do its job reliably ?
Marc
--
Marc Haisenko
Comdasys AG
Rüdesheimer Str. 7
80686 München
Germany
Tel.: +49 (0)89 548 433 321
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r32924 - trunk/tools/client-side
Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
2008-09-05 16:34:55 Fabien COELHO napisał(a):
>
> > (_svn, _svnadmin): Use '+=' for appending to variables and fix indentation.
>
> That looks good, but it is bash-3 specific:-(
bash-3.0 was released on 2004-07-27.
Why do you still use bash-2.*?
> shell> echo $BASH_VERSION
> 2.05b.0(1)-release
>
> shell> foo=bla
> shell> foo+=bli
> -bash: foo+=bli: command not found
>
> shell> svn <TAB>
>
> -bash: cmds+= commit ci copy cp delete remove rm diff export help import: command not found
> -bash: cmds+= info list ls lock log merge mergeinfo mkdir move mv rename: command not found
> -bash: cmds+= propdel pdel propedit pedit propget pget proplist plist: command not found
> -bash: cmds+= propset pset resolve resolved revert status switch unlock: command not found
> -bash: cmds+= update: command not found
> -bash: optsParam+=|-x|--extensions|-m|--message|-F|--file: command not found
> -bash: optsParam+=|--encoding|--diff-cmd|--diff3-cmd|--editor-cmd: command not found
> -bash: optsParam+=|--old|--new|--config-dir|--native-eol|-l|--limit: command not found
> -bash: optsParam+=|-c|--change|--depth|--set-depth|--with-revprop: command not found
> -bash: optsParam+=|--changelist|--accept|--show-revs: command not found
--
Arfrever Frehtes Taifersar Arahesis