You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/01/21 00:38:00 UTC

[jira] [Commented] (GEODE-8855) Redis Integration Test: add tests for all commands to redisStatsIntegrationTest

    [ https://issues.apache.org/jira/browse/GEODE-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268953#comment-17268953 ] 

ASF GitHub Bot commented on GEODE-8855:
---------------------------------------

nonbinaryprogrammer opened a new pull request #5937:
URL: https://github.com/apache/geode/pull/5937


   - organize tests
   - remove tests that don't belong in this class
   - fix a formatting issue in RedisCommandType
   - make the RedisInfoStatsIntegrationTest run against our redis and
   native redis
   - test all the stats in info
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Redis Integration Test: add tests for all commands to redisStatsIntegrationTest
> -------------------------------------------------------------------------------
>
>                 Key: GEODE-8855
>                 URL: https://issues.apache.org/jira/browse/GEODE-8855
>             Project: Geode
>          Issue Type: Test
>          Components: redis
>            Reporter: Helena Bales
>            Priority: Major
>
> add tests for the unsupported commands and the rest of the untested commands. organize the tests. make the tests run against redis and native redis. remove duplicate tests from the hitsmisses test.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)