Re: Review Request: AWS API calls do not honor the "admin" accounts ability to view/act on the resources owned by regular users.

[Prachi Damle <pr...@citrix.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5606/#review8932
-----------------------------------------------------------

Ship it!


These changes look good to me. I will apply the patch. 



- Prachi Damle


On June 27, 2012, 10:53 a.m., Likitha Shetty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5606/
> -----------------------------------------------------------
> 
> (Updated June 27, 2012, 10:53 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> When an admin runs ./ec2-describe-instances, list all the vm's including the ones owned by the regular users. 
> And when the "owner-id" filter is used with the command, list the instances owned by the user specified in the value of the filter.
> 
> Same behavior with ./ec2-describe-group.
> 
> 
> This addresses bug CS-15167.
> 
> 
> Diffs
> -----
> 
>   awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java b15cb7b 
>   awsapi/src/com/cloud/stack/CloudStackApi.java 095a29a 
>   awsapi/src/com/cloud/stack/models/ApiConstants.java 6a6df71 
> 
> Diff: https://reviews.apache.org/r/5606/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Likitha Shetty
> 
>