You are viewing a plain text version of this content. The canonical link for it is here.
Posted to modperl-cvs@perl.apache.org by ra...@apache.org on 2005/03/08 16:01:11 UTC

svn commit: r156534 - perl/modperl/branches/apache2-rename-unstable/t/filter/out_str_req_mix.t

Author: randyk
Date: Tue Mar  8 07:01:07 2005
New Revision: 156534

URL: http://svn.apache.org/viewcvs?view=rev&rev=156534
Log:
chomp the response.

Modified:
    perl/modperl/branches/apache2-rename-unstable/t/filter/out_str_req_mix.t

Modified: perl/modperl/branches/apache2-rename-unstable/t/filter/out_str_req_mix.t
URL: http://svn.apache.org/viewcvs/perl/modperl/branches/apache2-rename-unstable/t/filter/out_str_req_mix.t?view=diff&r1=156533&r2=156534
==============================================================================
--- perl/modperl/branches/apache2-rename-unstable/t/filter/out_str_req_mix.t (original)
+++ perl/modperl/branches/apache2-rename-unstable/t/filter/out_str_req_mix.t Tue Mar  8 07:01:07 2005
@@ -13,6 +13,7 @@
 
 my $expected = 'This is a clear text';
 my $received = POST_BODY $location, content => $content;
+chomp $received;
 
 ok t_cmp($expected, $received, 
     "mixing output httpd and mod_perl filters, while preserving order");



Re: svn commit: r156534 - perl/modperl/branches/apache2-rename-unstable/t/filter/out_str_req_mix.t

Posted by Geoffrey Young <ge...@modperlcookbook.org>.

Joe Schaefer wrote:
> Geoffrey Young <ge...@modperlcookbook.org> writes:
> 
> 
>>> my $expected = 'This is a clear text';
>>> my $received = POST_BODY $location, content => $content;
>>>+chomp $received;
>>
>>yeah, what's up with this?  I'm finding I need to do the same
>>with both_str_req_mix.t.  they both pass on trunk, so what's going on
>>here? 
> 
> 
> One of the sledgehammers I used for the first commit must 
> have appended trailing newline onto the end of clear.shtml.
> Since all the other files in the t/htdocs/includes directory
> have it, perhaps this was an omission in the original clear.shtml file?

as long as we can nail down a root cause I don't think it much matters.  we
can just chomp the output now that we know.

--Geoff


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: svn commit: r156534 - perl/modperl/branches/apache2-rename-unstable/t/filter/out_str_req_mix.t

Posted by Joe Schaefer <jo...@sunstarsys.com>.
Geoffrey Young <ge...@modperlcookbook.org> writes:

>>  my $expected = 'This is a clear text';
>>  my $received = POST_BODY $location, content => $content;
>> +chomp $received;
>
> yeah, what's up with this?  I'm finding I need to do the same
> with both_str_req_mix.t.  they both pass on trunk, so what's going on
> here? 

One of the sledgehammers I used for the first commit must 
have appended trailing newline onto the end of clear.shtml.
Since all the other files in the t/htdocs/includes directory
have it, perhaps this was an omission in the original clear.shtml file?

-- 
Joe Schaefer


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: svn commit: r156534 - perl/modperl/branches/apache2-rename-unstable/t/filter/out_str_req_mix.t

Posted by Geoffrey Young <ge...@modperlcookbook.org>.
>  my $expected = 'This is a clear text';
>  my $received = POST_BODY $location, content => $content;
> +chomp $received;

yeah, what's up with this?  I'm finding I need to do the same with
both_str_req_mix.t.  they both pass on trunk, so what's going on here?

--Geoff

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org