You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/11/01 04:05:47 UTC
[GitHub] [bookkeeper] wenbingshen opened a new pull request, #3596: Optimized debug log enable
wenbingshen opened a new pull request, #3596:
URL: https://github.com/apache/bookkeeper/pull/3596
### Motivation
As the title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] wenbingshen commented on pull request #3596: Optimized debug log enable
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on PR #3596:
URL: https://github.com/apache/bookkeeper/pull/3596#issuecomment-1298176791
> Why not adjust log level to print debug logs?
@yaalsn Why adjust the log level? Debug logs are generally only dynamically enabled and used when troubleshooting is required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] merlimat commented on pull request #3596: Optimized debug log enable
Posted by GitBox <gi...@apache.org>.
merlimat commented on PR #3596:
URL: https://github.com/apache/bookkeeper/pull/3596#issuecomment-1298699740
@hangc0276 the `log.debug("xxx {}", var)` is in many cases allocating objects on the heap for the variable arguments, even when the log level is info or above. Using the `if (log.isDebugEnabled()) {...}` avoids all allocations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on pull request #3596: Optimized debug log enable
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on PR #3596:
URL: https://github.com/apache/bookkeeper/pull/3596#issuecomment-1298654103
@wenbingshen Would you please explain the improvements of this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] merlimat merged pull request #3596: Optimized debug log enable
Posted by GitBox <gi...@apache.org>.
merlimat merged PR #3596:
URL: https://github.com/apache/bookkeeper/pull/3596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] yaalsn commented on pull request #3596: Optimized debug log enable
Posted by GitBox <gi...@apache.org>.
yaalsn commented on PR #3596:
URL: https://github.com/apache/bookkeeper/pull/3596#issuecomment-1298149932
Why not adjust log level to print debug logs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] wenbingshen commented on pull request #3596: Optimized debug log enable
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on PR #3596:
URL: https://github.com/apache/bookkeeper/pull/3596#issuecomment-1298173167
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] wenbingshen commented on pull request #3596: Optimized debug log enable
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on PR #3596:
URL: https://github.com/apache/bookkeeper/pull/3596#issuecomment-1299486078
@merlimat Thanks for your explanation and review! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org