You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2023/05/30 23:33:20 UTC

Re: Review Request 74395: RANGER-4168 :Improvement Adding Unit test cases are some of the missing classes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74395/#review225496
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On April 20, 2023, 4:18 p.m., Ramachandran Krishnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74395/
> -----------------------------------------------------------
> 
> (Updated April 20, 2023, 4:18 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4168
>     https://issues.apache.org/jira/browse/RANGER-4168
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The Unit Test cases are added for the below classes :
> 1.TagDBStore.java
> 2.RangerMetricsUtil.java
> 3.MetricsREST.java
> 
> This also needs to be added as part of improvement Task which will help the developer whenever they make code changes
> 
> As well as some refactoring in the logging side
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/rest/MetricsREST.java 5b3638b98 
>   security-admin/src/main/java/org/apache/ranger/util/RangerMetricsUtil.java d76be225d 
>   security-admin/src/test/java/org/apache/ranger/biz/TestTagDBStore.java PRE-CREATION 
>   security-admin/src/test/java/org/apache/ranger/rest/TestMetricsREST.java PRE-CREATION 
>   security-admin/src/test/java/org/apache/ranger/util/TestRangerMetricsUtil.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/74395/diff/2/
> 
> 
> Testing
> -------
> 
> All the Unit test cases are Tested and it is working fine
> 
> 
> Thanks,
> 
> Ramachandran Krishnan
> 
>