You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org> on 2005/12/31 13:26:02 UTC

[jira] Created: (MYFACES-991) equals validator shows text (nit nice by validating passwords...)

equals validator shows text (nit nice by validating passwords...)
-----------------------------------------------------------------

         Key: MYFACES-991
         URL: http://issues.apache.org/jira/browse/MYFACES-991
     Project: MyFaces
        Type: Bug
  Components: Tomahawk  
    Versions: Nightly    
    Reporter: Matthias Weßendorf
 Assigned to: Matthias Weßendorf 


<dave>
I am using t:validateEqual for password. when two passwords are not equal, the passwords(clear) show up on client browser in validation error message. Would it be nice if there is a flag to hide the passard on server side?
</dave>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Re: [jira] Updated: (TOMAHAWK-50) equals validator shows text (nit nice by validating passwords...)

Posted by Mike Kienenberger <mk...@gmail.com>.
The only issues I see keeping validateCompareTo in the sandbox are localization.

On 9/21/06, Mike Kienenberger <mk...@gmail.com> wrote:
> I also think this entire equalsTo component needs to become a subclass
> of validateCompareTo with some of the attributes hardcoded.
>

Re: [jira] Updated: (TOMAHAWK-50) equals validator shows text (nit nice by validating passwords...)

Posted by Mike Kienenberger <mk...@gmail.com>.
On 9/21/06, Martin Marinschek (JIRA) <de...@myfaces.apache.org> wrote:
>      [ http://issues.apache.org/jira/browse/TOMAHAWK-50?page=all ]
>
> Martin Marinschek updated TOMAHAWK-50:
> --------------------------------------
>
>            Status: Resolved  (was: Patch Available)
>     Fix Version/s: 1.1.4-SNAPSHOT
>        Resolution: Fixed
>          Assignee: Martin Marinschek  (was: Matthias Weßendorf)
>
> Mike had already something close to this to tomahawk. I've been trying to do a merge where it made sense, e.g. I find the addition of a summaryMessage attribute definitely useful, also the resolving of the FacesMessage is somehow handled better.
>
> What I've seen throughout the validator code - the value-bindings are never set as value-bindings, but always as pure string-values. Is that really what we want to do?

Sure.  I think we should update ValidatorBase to support
summaryMessage and detailMessage as well as message.

I also think this entire equalsTo component needs to become a subclass
of validateCompareTo with some of the attributes hardcoded.

[jira] Updated: (MYFACES-991) equals validator shows text (nit nice by validating passwords...)

Posted by "Steve Peterson (JIRA)" <de...@myfaces.apache.org>.
     [ http://issues.apache.org/jira/browse/MYFACES-991?page=all ]

Steve Peterson updated MYFACES-991:
-----------------------------------

    Attachment: myfaces-991.zip

The attachment implements a BaseValidator and BaseValidatorTag that together support new validator tag attributes summaryMessage and detailMessage.  These attributes are value bindings that should return a string message to be displayed.  The string is presented to MessageFormat using standard locale processing and a validator-defined list of arguments.

CreditCardValidator, EqualValidator, EmailValidator, URLValidator, and RegExprValidator are modified to support these tags.

This patch targets the Mavenized build structure.

> equals validator shows text (nit nice by validating passwords...)
> -----------------------------------------------------------------
>
>          Key: MYFACES-991
>          URL: http://issues.apache.org/jira/browse/MYFACES-991
>      Project: MyFaces
>         Type: Bug
>   Components: Tomahawk
>     Versions: Nightly
>     Reporter: Matthias Weßendorf
>     Assignee: Matthias Weßendorf
>  Attachments: myfaces-991.zip
>
> <dave>
> I am using t:validateEqual for password. when two passwords are not equal, the passwords(clear) show up on client browser in validation error message. Would it be nice if there is a flag to hide the passard on server side?
> </dave>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Updated: (TOMAHAWK-50) equals validator shows text (nit nice by validating passwords...)

Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
     [ http://issues.apache.org/jira/browse/TOMAHAWK-50?page=all ]

Martin Marinschek updated TOMAHAWK-50:
--------------------------------------

           Status: Resolved  (was: Patch Available)
    Fix Version/s: 1.1.4-SNAPSHOT
       Resolution: Fixed
         Assignee: Martin Marinschek  (was: Matthias Weßendorf)

Mike had already something close to this to tomahawk. I've been trying to do a merge where it made sense, e.g. I find the addition of a summaryMessage attribute definitely useful, also the resolving of the FacesMessage is somehow handled better.

What I've seen throughout the validator code - the value-bindings are never set as value-bindings, but always as pure string-values. Is that really what we want to do?

regards,

Martin



> equals validator shows text (nit nice by validating passwords...)
> -----------------------------------------------------------------
>
>                 Key: TOMAHAWK-50
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-50
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Validators
>            Reporter: Matthias Weßendorf
>         Assigned To: Martin Marinschek
>             Fix For: 1.1.4-SNAPSHOT
>
>         Attachments: myfaces-991.zip
>
>
> <dave>
> I am using t:validateEqual for password. when two passwords are not equal, the passwords(clear) show up on client browser in validation error message. Would it be nice if there is a flag to hide the passard on server side?
> </dave>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (TOMAHAWK-50) equals validator shows text (nit nice by validating passwords...)

Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
     [ http://issues.apache.org/jira/browse/TOMAHAWK-50?page=all ]

Mike Kienenberger updated TOMAHAWK-50:
--------------------------------------


> equals validator shows text (nit nice by validating passwords...)
> -----------------------------------------------------------------
>
>          Key: TOMAHAWK-50
>          URL: http://issues.apache.org/jira/browse/TOMAHAWK-50
>      Project: MyFaces Tomahawk
>         Type: Bug
>   Components: Validatiors
>     Reporter: Matthias Weßendorf
>     Assignee: Matthias Weßendorf
>  Attachments: myfaces-991.zip
>
> <dave>
> I am using t:validateEqual for password. when two passwords are not equal, the passwords(clear) show up on client browser in validation error message. Would it be nice if there is a flag to hide the passard on server side?
> </dave>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira