You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/07 19:55:28 UTC

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6000: sched/pthread: thread id should updated before start routine

pkarashchenko commented on PR #6000:
URL: https://github.com/apache/incubator-nuttx/pull/6000#issuecomment-1092144260

   Personally I do not see any harm in assigning thread ID before taking `pjoin->data_sem` and if it helps to users, then I think we should proceed with this change. On the other hand I understand comment from @yamt and accessing global variable from a child thread assuming that it should already contain a value is a signal of bad software design and `pthread_self` should be used instead and the exact behaviour in such situation is not documented.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org