[GitHub] [solr] risdenk commented on a diff in pull request #1513: SOLR-15703: replace all SolrException.log usage in Solr to just call log.error(...) directly

["risdenk (via GitHub)" <gi...@apache.org>]

risdenk commented on code in PR #1513:
URL: https://github.com/apache/solr/pull/1513#discussion_r1154885795


##########
solr/core/src/java/org/apache/solr/core/SolrCore.java:
##########
@@ -3013,10 +3013,6 @@ public static void postDecorateResponse(
     }
   }
 
-  public static final void log(Throwable e) {
-    SolrException.log(log, null, e);
-  }

Review Comment:
   I can leave this to cleanup w/ the other SolrException.log, but this was only used in 3 places so just cleaned it up.



##########
solr/solrj/src/java/org/apache/solr/common/SolrException.java:
##########
@@ -139,6 +140,7 @@ public String getRootThrowable() {
    * @deprecated Use the Logger directly
    */
   @Deprecated
+  @SuppressForbidden(reason = "self referencing")
   public void log(Logger log) {

Review Comment:
   I'm going to remove all of these `log` methods in main once this is merged.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org