[jira] Updated: (WICKET-1039) parameters for Image never used when using a ResourceReference

["Frank Bille Jensen (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Bille Jensen updated WICKET-1039:
---------------------------------------

    Fix Version/s:     (was: 1.3.0-beta4)
                   1.3.0-beta5

> parameters for Image never used when using a ResourceReference
> --------------------------------------------------------------
>
>                 Key: WICKET-1039
>                 URL: https://issues.apache.org/jira/browse/WICKET-1039
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta3
>            Reporter: Doug Leeper
>             Fix For: 1.3.0-beta5
>
>
> When using parameters (ValueMap) for an Image with a ResourceReference, they are essentially wiped out because of the code in onComponentTag().
> <code>
> public final void onComponentTag(...) {
>        ...
>                 final ResourceReference resourceReference = getImageResourceReference();
>                 if (resourceReference != null)
>                 {
>                         localizedImageResource.setResourceReference(resourceReference);
>                 }
>       ...
> }
> </code> 
> This in turns calls LocalizedImageResource.setResourceReference( resourceReference, null ). Which nulls out the parameters set in the constructor.
> A possible change would to change LocalizedImageResource.setResourceReference( resourceRef ) to the following:
> <code>
> 	public final void setResourceReference(final ResourceReference resourceReference)
> 	{
> 		setResourceReference(resourceReference, resourceParameters);
> 	}
> </code>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.