You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/12/19 07:44:10 UTC

[GitHub] [maven-surefire] andpab commented on a diff in pull request #584: [SUREFIRE-2135] Use native.encoding for parsing ps

andpab commented on code in PR #584:
URL: https://github.com/apache/maven-surefire/pull/584#discussion_r1051892390


##########
surefire-booter/src/main/java/org/apache/maven/surefire/booter/PpidChecker.java:
##########
@@ -170,7 +169,7 @@ private void checkProcessInfo()
     // http://hg.openjdk.java.net/jdk7/jdk7/jdk/file/9b8c96f96a0f/test/java/lang/ProcessBuilder/Basic.java#L167
     ProcessInfo unix()
     {
-        ProcessInfoConsumer reader = new ProcessInfoConsumer( Charset.defaultCharset().name() )
+        ProcessInfoConsumer reader = new ProcessInfoConsumer( System.getProperty( "native.encoding", "UTF-8" ) )

Review Comment:
   Good idea. Somehow I didn't think of that, but it makes sense.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org