You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "sweetcocoa (via GitHub)" <gi...@apache.org> on 2023/04/03 11:22:07 UTC
[GitHub] [tvm] sweetcocoa opened a new pull request, #14462: preserve the order of input_info
sweetcocoa opened a new pull request, #14462:
URL: https://github.com/apache/tvm/pull/14462
This is for resolving https://github.com/apache/tvm/issues/14461
The direct cause of this problem is that the order of input nodes found in `_analysis.free_vars(ret)` is not guaranteed in the order of names in `input_info`. From what I understand, `_analysis.free_vars(ret)` uses DFS to find input nodes from output nodes. Since DFS cannot guarantee the order in which nodes are found, it is intuitive to modify the order of input nodes after DFS, as shown in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sweetcocoa commented on pull request #14462: [relay] preserve the order of input_info of pytorch
Posted by "sweetcocoa (via GitHub)" <gi...@apache.org>.
sweetcocoa commented on PR #14462:
URL: https://github.com/apache/tvm/pull/14462#issuecomment-1498906417
@masahi Now all checks have passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #14462: [relay] preserve the order of input_info of pytorch
Posted by "masahi (via GitHub)" <gi...@apache.org>.
masahi commented on PR #14462:
URL: https://github.com/apache/tvm/pull/14462#issuecomment-1497060027
@tvm-bot rerun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sweetcocoa commented on pull request #14462: [relay] preserve the order of input_info of pytorch
Posted by "sweetcocoa (via GitHub)" <gi...@apache.org>.
sweetcocoa commented on PR #14462:
URL: https://github.com/apache/tvm/pull/14462#issuecomment-1498395770
@masahi Could you run again please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sweetcocoa commented on pull request #14462: [relay] preserve the order of input_info of pytorch
Posted by "sweetcocoa (via GitHub)" <gi...@apache.org>.
sweetcocoa commented on PR #14462:
URL: https://github.com/apache/tvm/pull/14462#issuecomment-1498396240
@tvm-bot rerun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #14462: preserve the order of input_info
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14462:
URL: https://github.com/apache/tvm/pull/14462#issuecomment-1494143251
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* No users to auto-tag found, no teams are specified in PR title <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sweetcocoa commented on pull request #14462: [relay] preserve the order of input_info of pytorch
Posted by "sweetcocoa (via GitHub)" <gi...@apache.org>.
sweetcocoa commented on PR #14462:
URL: https://github.com/apache/tvm/pull/14462#issuecomment-1495690611
I fixed lint. please re-review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #14462: [relay] preserve the order of input_info of pytorch
Posted by "masahi (via GitHub)" <gi...@apache.org>.
masahi commented on PR #14462:
URL: https://github.com/apache/tvm/pull/14462#issuecomment-1498540023
@tvm-bot rerun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #14462: [relay] preserve the order of input_info of pytorch
Posted by "masahi (via GitHub)" <gi...@apache.org>.
masahi merged PR #14462:
URL: https://github.com/apache/tvm/pull/14462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #14462: [relay] preserve the order of input_info of pytorch
Posted by "masahi (via GitHub)" <gi...@apache.org>.
masahi commented on PR #14462:
URL: https://github.com/apache/tvm/pull/14462#issuecomment-1495706475
Some tests are broken, please fix them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sweetcocoa commented on pull request #14462: [relay] preserve the order of input_info of pytorch
Posted by "sweetcocoa (via GitHub)" <gi...@apache.org>.
sweetcocoa commented on PR #14462:
URL: https://github.com/apache/tvm/pull/14462#issuecomment-1497053950
@masahi I fixed a test failure. However, I cannot interpret the current test results. `cross-isa-minimal/pr-head — The build of this commit was aborted`. Is this caused by a change in my code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sweetcocoa commented on pull request #14462: [relay] preserve the order of input_info of pytorch
Posted by "sweetcocoa (via GitHub)" <gi...@apache.org>.
sweetcocoa commented on PR #14462:
URL: https://github.com/apache/tvm/pull/14462#issuecomment-1498394821
@tvm-bot rerun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org