You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/12/22 16:09:11 UTC
[kudu-CR] [tools] kudu CLI auto detects replication scheme
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8915
Change subject: [tools] kudu CLI auto detects replication scheme
......................................................................
[tools] kudu CLI auto detects replication scheme
Added functionality to allow for automatic detection of appropriate
replica move scenario by the 'kudu tablet replica move' sub-command.
This is a follow-up for 9120cdd1d288ef6b3e03e2cd8445436712a7d4a9.
Change-Id: Ia536c1f64ef8173aa4385db8ba01581bc3528154
---
M src/kudu/consensus/consensus.proto
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool_action_tablet.cc
M src/kudu/tserver/tablet_service.cc
4 files changed, 61 insertions(+), 48 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/8915/1
--
To view, visit http://gerrit.cloudera.org:8080/8915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia536c1f64ef8173aa4385db8ba01581bc3528154
Gerrit-Change-Number: 8915
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [tools] kudu CLI auto detects replication scheme
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8915 )
Change subject: [tools] kudu CLI auto detects replication scheme
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/8915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ia536c1f64ef8173aa4385db8ba01581bc3528154
Gerrit-Change-Number: 8915
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [tools] make kudu CLI auto-detect the replication scheme
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8915
to look at the new patch set (#4).
Change subject: [tools] make kudu CLI auto-detect the replication scheme
......................................................................
[tools] make kudu CLI auto-detect the replication scheme
Added functionality to allow for automatic detection of appropriate
replica move scenario by the 'kudu tablet replica move' sub-command.
This is a follow-up for 9120cdd1d288ef6b3e03e2cd8445436712a7d4a9.
Change-Id: Ia536c1f64ef8173aa4385db8ba01581bc3528154
---
M src/kudu/consensus/consensus.proto
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool_action_tablet.cc
M src/kudu/tserver/tablet_service.cc
4 files changed, 61 insertions(+), 48 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/8915/4
--
To view, visit http://gerrit.cloudera.org:8080/8915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia536c1f64ef8173aa4385db8ba01581bc3528154
Gerrit-Change-Number: 8915
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [tools] kudu CLI auto detects replication scheme
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8915 )
Change subject: [tools] kudu CLI auto detects replication scheme
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8915/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/8915/3//COMMIT_MSG@7
PS3, Line 7: [tools] kudu CLI auto detects replication scheme
nit: how about:
[tools] make the replica move tool auto-detect the replication scheme
per https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53 (we don't really follow all these rules but the imperative mood makes for a more readable message; i.e. "add", "make", "remove", "fix", etc)
http://gerrit.cloudera.org:8080/#/c/8915/3/src/kudu/consensus/consensus.proto
File src/kudu/consensus/consensus.proto:
http://gerrit.cloudera.org:8080/#/c/8915/3/src/kudu/consensus/consensus.proto@496
PS3, Line 496: optional ReplicaManagementInfoPB replica_management_info = 3;
nit: we usually leave the error as the last entry in the message, even if that means the field indexes end up out of order
--
To view, visit http://gerrit.cloudera.org:8080/8915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia536c1f64ef8173aa4385db8ba01581bc3528154
Gerrit-Change-Number: 8915
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Sat, 06 Jan 2018 02:44:09 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tools] make kudu CLI auto-detect the replication scheme
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8915 )
Change subject: [tools] make kudu CLI auto-detect the replication scheme
......................................................................
[tools] make kudu CLI auto-detect the replication scheme
Added functionality to allow for automatic detection of appropriate
replica move scenario by the 'kudu tablet replica move' sub-command.
This is a follow-up for 9120cdd1d288ef6b3e03e2cd8445436712a7d4a9.
Change-Id: Ia536c1f64ef8173aa4385db8ba01581bc3528154
Reviewed-on: http://gerrit.cloudera.org:8080/8915
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/consensus/consensus.proto
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool_action_tablet.cc
M src/kudu/tserver/tablet_service.cc
4 files changed, 61 insertions(+), 48 deletions(-)
Approvals:
Kudu Jenkins: Verified
Mike Percy: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/8915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia536c1f64ef8173aa4385db8ba01581bc3528154
Gerrit-Change-Number: 8915
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [tools] make kudu CLI auto-detect the replication scheme
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8915 )
Change subject: [tools] make kudu CLI auto-detect the replication scheme
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia536c1f64ef8173aa4385db8ba01581bc3528154
Gerrit-Change-Number: 8915
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 09 Jan 2018 01:38:49 +0000
Gerrit-HasComments: No
[kudu-CR] [tools] make kudu CLI auto-detect the replication scheme
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8915 )
Change subject: [tools] make kudu CLI auto-detect the replication scheme
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8915/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/8915/3//COMMIT_MSG@7
PS3, Line 7: [tools] kudu CLI auto detects replication scheme
> nit: how about:
That seems a bit long. I resorted to:
[tools] make kudu CLI auto-detect the replication scheme
http://gerrit.cloudera.org:8080/#/c/8915/3/src/kudu/consensus/consensus.proto
File src/kudu/consensus/consensus.proto:
http://gerrit.cloudera.org:8080/#/c/8915/3/src/kudu/consensus/consensus.proto@496
PS3, Line 496: optional ReplicaManagementInfoPB replica_management_info = 3;
> nit: we usually leave the error as the last entry in the message, even if t
Done
--
To view, visit http://gerrit.cloudera.org:8080/8915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia536c1f64ef8173aa4385db8ba01581bc3528154
Gerrit-Change-Number: 8915
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Mon, 08 Jan 2018 23:42:16 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tools] kudu CLI auto detects replication scheme
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8915 )
Change subject: [tools] kudu CLI auto detects replication scheme
......................................................................
Patch Set 1: Verified+1
Unrelated flake in TabletServerDiskFailureTest.TestRandomOpSequence
--
To view, visit http://gerrit.cloudera.org:8080/8915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia536c1f64ef8173aa4385db8ba01581bc3528154
Gerrit-Change-Number: 8915
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 22 Dec 2017 17:44:33 +0000
Gerrit-HasComments: No