You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/08/08 19:28:21 UTC

[GitHub] [trafficcontrol] jhg03a commented on issue #2391: TP - Improve profile diffing

jhg03a commented on issue #2391: TP - Improve profile diffing
URL: https://github.com/apache/trafficcontrol/issues/2391#issuecomment-519655769
 
 
   I like it.  Rather than forcing the UI to include/exclude non-changes, I'd recommend a checkbox to show unchanged values.  Normally I wouldn't expect it to be relevant, but it is handy to turn on to verify that all 3 in this case had a given parameter to begin with and not have to change UI pages (probably still leaning on [ctrl]+f here, unless there's a search of some kind).
   
   The only piece that's going to look terrible is when a param value is huge, like a lua file.  If a parameter has more than X lines of text there might be a better way to display it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services