You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "dongnuo123 (via GitHub)" <gi...@apache.org> on 2025/06/24 00:57:40 UTC

[PR] DRAFT: testDelayedTxnOffsetCommitWithBumpedEpochIsRejected [kafka]

dongnuo123 opened a new pull request, #20024:
URL: https://github.com/apache/kafka/pull/20024

   Delete this text and replace it with a detailed description of your change. The 
   PR title and body will become the squashed commit message.
   
   If you would like to tag individuals, add some commentary, upload images, or
   include other supplemental information that should not be part of the eventual
   commit message, please use a separate comment.
   
   If applicable, please include a summary of the testing strategy (including 
   rationale) for the proposed change. Unit and/or integration tests are expected
   for any behavior change and system tests should be considered for larger
   changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: testDelayedTxnOffsetCommitWithBumpedEpochIsRejected [kafka]

Posted by "dongnuo123 (via GitHub)" <gi...@apache.org>.
dongnuo123 commented on PR #20024:
URL: https://github.com/apache/kafka/pull/20024#issuecomment-3054314280

   @FrankYang0529 Did you mean `WriteTxnMarkers` request? For `EndTxnRequest` we already have some integration tests in TransactionTest.scala but I guess we should have one for `WriteTxnMarkersRequest`. Let me prepare a commit to add it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Add tests on TxnOffsetCommit and EndTxnMarker protection against invalid producer epoch when TV2 is used [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #20024:
URL: https://github.com/apache/kafka/pull/20024


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Add tests on TxnOffsetCommit and EndTxnMarker protection against invalid producer epoch when TV2 is used [kafka]

Posted by "squah-confluent (via GitHub)" <gi...@apache.org>.
squah-confluent commented on code in PR #20024:
URL: https://github.com/apache/kafka/pull/20024#discussion_r2202026091


##########
core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala:
##########
@@ -421,6 +452,27 @@ class GroupCoordinatorBaseRequestTest(cluster: ClusterInstance) {
     groupResponse
   }
 
+  protected def fetchOffset(
+    topic: String,
+    partition: Int,
+    groupId: String

Review Comment:
   nit: The other methods in this class put the groupId as the first parameter. Could we re-order the parameters for consistency?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Add tests on TxnOffsetCommit and EndTxnMarker protection against invalid producer epoch when TV2 is used [kafka]

Posted by "dongnuo123 (via GitHub)" <gi...@apache.org>.
dongnuo123 commented on PR #20024:
URL: https://github.com/apache/kafka/pull/20024#issuecomment-3058796452

   @FrankYang0529 For EndTxnRequest we already have some integration tests in TransactionTest.scala but I guess we should have one for WriteTxnMarkersRequest to test the protection on the group coordinator side


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org