You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by yj...@apache.org on 2025/06/26 12:56:17 UTC
(cloudberry) branch fix_log_wal created (now f3faa68c11b)
This is an automated email from the ASF dual-hosted git repository.
yjhjstz pushed a change to branch fix_log_wal
in repository https://gitbox.apache.org/repos/asf/cloudberry.git
at f3faa68c11b Remove misleading elog(LOG) on WAL compression failure without ZSTD support
This branch includes the following new commits:
new f3faa68c11b Remove misleading elog(LOG) on WAL compression failure without ZSTD support
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
(cloudberry) 01/01: Remove misleading elog(LOG) on WAL compression failure without ZSTD support
Posted by yj...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
yjhjstz pushed a commit to branch fix_log_wal
in repository https://gitbox.apache.org/repos/asf/cloudberry.git
commit f3faa68c11bfe3496b4dbb3b64e7fde0abd9c494
Author: Jianghua Yang <yj...@gmail.com>
AuthorDate: Sat Jun 21 01:20:26 2025 +0800
Remove misleading elog(LOG) on WAL compression failure without ZSTD support
When USE_ZSTD is not defined, XLogCompressBackupBlock() always returns false, indicating that WAL page compression did not succeed. The existing elog(LOG, "WAL compression failed, using uncompressed image") message may be misleading in such builds, as compression is not even attempted.
Remove the log message to avoid confusion in builds without ZSTD support.
---
src/backend/access/transam/xloginsert.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/backend/access/transam/xloginsert.c b/src/backend/access/transam/xloginsert.c
index 168ed8a5b6a..7243b97d467 100644
--- a/src/backend/access/transam/xloginsert.c
+++ b/src/backend/access/transam/xloginsert.c
@@ -655,8 +655,6 @@ XLogRecordAssemble(RmgrId rmid, uint8 info,
cbimg.hole_length,
regbuf->compressed_page,
&compressed_len);
- if (!is_compressed)
- elog(LOG, "WAL compression failed, using uncompressed image");
}
/*
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org