You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Greg Stein <gs...@lyra.org> on 2000/11/09 07:55:12 UTC
Re: cvs commit: apache-2.0/src/lib/apr/misc/unix Makefile.in otherchild.c misc.h
On Thu, Nov 09, 2000 at 06:30:13AM -0000, rbb@locus.apache.org wrote:
>...
> --- otherchild.c 2000/10/16 06:04:47 1.16
> +++ otherchild.c 2000/11/09 06:30:11 1.17
> @@ -55,7 +55,7 @@
> #include "apr.h"
> #include "misc.h"
> #include "threadproc.h"
> -#include "../../file_io/unix/fileio.h"
> +#include "fileio.h"
> #ifdef HAVE_TIME_H
> #include <sys/time.h>
> #endif
Should that be unix/fileio.h ?
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
Re: cvs commit: apache-2.0/src/lib/apr/misc/unix Makefile.in
otherchild.c misc.h
Posted by rb...@covalent.net.
On Wed, 8 Nov 2000, Greg Stein wrote:
> On Thu, Nov 09, 2000 at 06:30:13AM -0000, rbb@locus.apache.org wrote:
> >...
> > --- otherchild.c 2000/10/16 06:04:47 1.16
> > +++ otherchild.c 2000/11/09 06:30:11 1.17
> > @@ -55,7 +55,7 @@
> > #include "apr.h"
> > #include "misc.h"
> > #include "threadproc.h"
> > -#include "../../file_io/unix/fileio.h"
> > +#include "fileio.h"
> > #ifdef HAVE_TIME_H
> > #include <sys/time.h>
> > #endif
>
> Should that be unix/fileio.h ?
No. This is correct. The reason for the difference is that the
misc/unix/Makefile sets and INCDIR of arch/@OSDIR@. The reason for this,
is that the fileio.h is used from the appropriate OS. We need the correct
definition for apr_file_t's based on each platform, so we can't just
include the unix version, because other platforms may use a different
apr_file_t. The reason this works, is that all platforms that use this
code have a filedes field in the apr_file_t.
Ryan
_______________________________________________________________________________
Ryan Bloom rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------