You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by sr...@apache.org on 2018/01/08 13:04:06 UTC
[12/15] flink git commit: [hotfix][runtime] Remove unused methods
[hotfix][runtime] Remove unused methods
Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/d5d4da1b
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/d5d4da1b
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/d5d4da1b
Branch: refs/heads/master
Commit: d5d4da1b3785c493e441eeeb99b94718374b1556
Parents: 5cf3778
Author: Piotr Nowojski <pi...@gmail.com>
Authored: Tue Dec 5 09:42:19 2017 +0100
Committer: Stefan Richter <s....@data-artisans.com>
Committed: Mon Jan 8 11:46:00 2018 +0100
----------------------------------------------------------------------
.../runtime/io/network/api/TaskEventHandler.java | 6 ------
.../runtime/util/event/TaskEventHandlerTest.java | 16 ++++------------
2 files changed, 4 insertions(+), 18 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flink/blob/d5d4da1b/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/TaskEventHandler.java
----------------------------------------------------------------------
diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/TaskEventHandler.java b/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/TaskEventHandler.java
index 9ef170a..4121587 100644
--- a/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/TaskEventHandler.java
+++ b/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/TaskEventHandler.java
@@ -39,12 +39,6 @@ public class TaskEventHandler {
}
}
- public void unsubscribe(EventListener<TaskEvent> listener, Class<? extends TaskEvent> eventType) {
- synchronized (listeners) {
- listeners.remove(eventType, listener);
- }
- }
-
/**
* Publishes the task event to all subscribed event listeners.
*
http://git-wip-us.apache.org/repos/asf/flink/blob/d5d4da1b/flink-runtime/src/test/java/org/apache/flink/runtime/util/event/TaskEventHandlerTest.java
----------------------------------------------------------------------
diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/util/event/TaskEventHandlerTest.java b/flink-runtime/src/test/java/org/apache/flink/runtime/util/event/TaskEventHandlerTest.java
index cb76276..259adcb 100644
--- a/flink-runtime/src/test/java/org/apache/flink/runtime/util/event/TaskEventHandlerTest.java
+++ b/flink-runtime/src/test/java/org/apache/flink/runtime/util/event/TaskEventHandlerTest.java
@@ -19,15 +19,16 @@
package org.apache.flink.runtime.util.event;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
-
import org.apache.flink.runtime.event.TaskEvent;
import org.apache.flink.runtime.event.task.IntegerTaskEvent;
import org.apache.flink.runtime.event.task.StringTaskEvent;
import org.apache.flink.runtime.io.network.api.TaskEventHandler;
+
import org.junit.Test;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+
/**
* This class contains unit tests for the {@link TaskEventHandler}.
*
@@ -78,7 +79,6 @@ public class TaskEventHandlerTest {
evm.subscribe(listener, StringTaskEvent.class);
final StringTaskEvent stringTaskEvent1 = new StringTaskEvent("Test 1");
- final StringTaskEvent stringTaskEvent2 = new StringTaskEvent("Test 2");
evm.publish(stringTaskEvent1);
evm.publish(new IntegerTaskEvent(5));
@@ -86,13 +86,5 @@ public class TaskEventHandlerTest {
assertNotNull(listener.getLastReceivedEvent());
StringTaskEvent receivedStringEvent = (StringTaskEvent) listener.getLastReceivedEvent();
assertEquals(stringTaskEvent1, receivedStringEvent);
-
- evm.unsubscribe(listener, StringTaskEvent.class);
-
- evm.publish(stringTaskEvent2);
-
- assertNotNull(listener.getLastReceivedEvent());
- receivedStringEvent = (StringTaskEvent) listener.getLastReceivedEvent();
- assertEquals(stringTaskEvent1, receivedStringEvent);
}
}