You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Andras Salamon <an...@melda.info> on 2018/11/05 12:58:57 UTC
Review Request 69252: OOZIE 3378 - Coordinator action's status is
SUBMITTED after E1003 error
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69252/
-----------------------------------------------------------
Review request for oozie, András Piros, Peter Cseh, and Kinga Marton.
Repository: oozie-git
Description
-------
OOZIE 3378 - Coordinator action's status is SUBMITTED after E1003 error
Diffs
-----
core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 267943ee5
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 4215a32b1
Diff: https://reviews.apache.org/r/69252/diff/1/
Testing
-------
Created a coordinator.xml which gives us E1003 error. (See details in upstream Jira).
Thanks,
Andras Salamon
Re: Review Request 69252: OOZIE 3378 - Coordinator action's status is
SUBMITTED after E1003 error
Posted by András Piros via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69252/#review210346
-----------------------------------------------------------
Ship it!
Ship It!
- András Piros
On Nov. 6, 2018, 9 a.m., Andras Salamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69252/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2018, 9 a.m.)
>
>
> Review request for oozie, András Piros, Peter Cseh, and Kinga Marton.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE 3378 - Coordinator action's status is SUBMITTED after E1003 error
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 267943ee5
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 4215a32b1
>
>
> Diff: https://reviews.apache.org/r/69252/diff/2/
>
>
> Testing
> -------
>
> Created a coordinator.xml which gives us E1003 error. (See details in upstream Jira).
>
>
> Thanks,
>
> Andras Salamon
>
>
Re: Review Request 69252: OOZIE 3378 - Coordinator action's status is
SUBMITTED after E1003 error
Posted by Andras Salamon <an...@melda.info>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69252/
-----------------------------------------------------------
(Updated Nov. 6, 2018, 9 a.m.)
Review request for oozie, András Piros, Peter Cseh, and Kinga Marton.
Changes
-------
Using Map<String,String>
Repository: oozie-git
Description
-------
OOZIE 3378 - Coordinator action's status is SUBMITTED after E1003 error
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 267943ee5
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 4215a32b1
Diff: https://reviews.apache.org/r/69252/diff/2/
Changes: https://reviews.apache.org/r/69252/diff/1-2/
Testing
-------
Created a coordinator.xml which gives us E1003 error. (See details in upstream Jira).
Thanks,
Andras Salamon
Re: Review Request 69252: OOZIE 3378 - Coordinator action's status is
SUBMITTED after E1003 error
Posted by András Piros via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69252/#review210330
-----------------------------------------------------------
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java
Lines 238 (patched)
<https://reviews.apache.org/r/69252/#comment294991>
Isn't a `Map<String, String>` better?
- András Piros
On Nov. 5, 2018, 12:58 p.m., Andras Salamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69252/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2018, 12:58 p.m.)
>
>
> Review request for oozie, András Piros, Peter Cseh, and Kinga Marton.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE 3378 - Coordinator action's status is SUBMITTED after E1003 error
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 267943ee5
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 4215a32b1
>
>
> Diff: https://reviews.apache.org/r/69252/diff/1/
>
>
> Testing
> -------
>
> Created a coordinator.xml which gives us E1003 error. (See details in upstream Jira).
>
>
> Thanks,
>
> Andras Salamon
>
>