[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #42542: [SPARK-44214][CORE] Support Spark Driver Live Log UI

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on code in PR #42542:
URL: https://github.com/apache/spark/pull/42542#discussion_r1300790498


##########
core/src/main/scala/org/apache/spark/internal/config/package.scala:
##########
@@ -123,6 +123,13 @@ package object config {
         "Ensure that memory overhead is a double greater than 0")
       .createWithDefault(0.1)
 
+  private[spark] val DRIVER_LOG_LOCAL_DIR =
+    ConfigBuilder("spark.driver.log.localDir")
+      .doc("Specifies a local directory to write driver logs and enable Driver Log UI Tab.")

Review Comment:
   The `enable` is connected to `to write ... and enable`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org