You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Purshotam Shah <pu...@yahoo-inc.com> on 2014/04/17 22:37:26 UTC
Review Request 20461: OOZIE-1797 Workflow rerun command should use existing
workflow properties
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20461/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-1797
https://issues.apache.org/jira/browse/OOZIE-1797
Repository: oozie-git
Description
-------
Workflow rerun command should use existing workflow properties
Diffs
-----
client/src/main/java/org/apache/oozie/cli/OozieCLI.java c31c8ee
client/src/main/java/org/apache/oozie/client/OozieClient.java 129579a
core/src/main/java/org/apache/oozie/DagEngine.java 7d316b8
core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 6b82d7b
core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java e97fec3
core/src/test/java/org/apache/oozie/servlet/TestV0JobServlet.java cdd4903
docs/src/site/twiki/DG_WorkflowReRun.twiki 94084fc
Diff: https://reviews.apache.org/r/20461/diff/
Testing
-------
UTC and manual.
$ ~/views/log_slow/oozie/distro/target/oozie-4.1.0-SNAPSHOT-distro/oozie-4.1.0-SNAPSHOT/bin/oozie job -oozie http://localhost:11000/oozie -config examples/apps/map-reduce/job.properties -run
job: 0000002-140417103459754-oozie-puru-W
$ ~/views/log_slow/oozie/distro/target/oozie-4.1.0-SNAPSHOT-distro/oozie-4.1.0-SNAPSHOT/bin/oozie job -oozie http://localhost:11000/oozie -kill 0000002-140417103459754-oozie-puru-W
$ ~/views/rerun/oozie/distro/target/oozie-4.1.0-SNAPSHOT-distro/oozie-4.1.0-SNAPSHOT/bin/oozie job -oozie http://localhost:11000/oozie -rerun 0000002-140417103459754-oozie-puru-W -Doozie.wf.rerun.failnodes=true
$
Thanks,
Purshotam Shah
Re: Review Request 20461: OOZIE-1797 Workflow rerun command should use
existing workflow properties
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20461/#review40695
-----------------------------------------------------------
client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/20461/#comment73795>
Can be removed and inlined with a simple else condition.
client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/20461/#comment73796>
Just add
else if (!commandLine.hasOption("D)) {
throw new IOException("Configuration is not specified");
}
client/src/main/java/org/apache/oozie/client/OozieClient.java
<https://reviews.apache.org/r/20461/#comment73798>
This private constructor can be avoided as nothing special is done here.
client/src/main/java/org/apache/oozie/client/OozieClient.java
<https://reviews.apache.org/r/20461/#comment73799>
jobId, new Properties()
core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java
<https://reviews.apache.org/r/20461/#comment73841>
Need to retain this check passing in the merged wf configuration.
docs/src/site/twiki/DG_WorkflowReRun.twiki
<https://reviews.apache.org/r/20461/#comment73832>
Please add this additional note.
Currently there is no way to remove an existing configuration but only override by passing a different value in the input configuration.
- Rohini Palaniswamy
On April 17, 2014, 8:37 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20461/
> -----------------------------------------------------------
>
> (Updated April 17, 2014, 8:37 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1797
> https://issues.apache.org/jira/browse/OOZIE-1797
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Workflow rerun command should use existing workflow properties
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java c31c8ee
> client/src/main/java/org/apache/oozie/client/OozieClient.java 129579a
> core/src/main/java/org/apache/oozie/DagEngine.java 7d316b8
> core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 6b82d7b
> core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java e97fec3
> core/src/test/java/org/apache/oozie/servlet/TestV0JobServlet.java cdd4903
> docs/src/site/twiki/DG_WorkflowReRun.twiki 94084fc
>
> Diff: https://reviews.apache.org/r/20461/diff/
>
>
> Testing
> -------
>
> UTC and manual.
>
> $ ~/views/log_slow/oozie/distro/target/oozie-4.1.0-SNAPSHOT-distro/oozie-4.1.0-SNAPSHOT/bin/oozie job -oozie http://localhost:11000/oozie -config examples/apps/map-reduce/job.properties -run
> job: 0000002-140417103459754-oozie-puru-W
> $ ~/views/log_slow/oozie/distro/target/oozie-4.1.0-SNAPSHOT-distro/oozie-4.1.0-SNAPSHOT/bin/oozie job -oozie http://localhost:11000/oozie -kill 0000002-140417103459754-oozie-puru-W
> $ ~/views/rerun/oozie/distro/target/oozie-4.1.0-SNAPSHOT-distro/oozie-4.1.0-SNAPSHOT/bin/oozie job -oozie http://localhost:11000/oozie -rerun 0000002-140417103459754-oozie-puru-W -Doozie.wf.rerun.failnodes=true
> $
>
>
> Thanks,
>
> Purshotam Shah
>
>