You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/03 13:19:17 UTC
[GitHub] [spark] wangyum opened a new pull request #24282:
[SPARK-27354][SQL] Add a new empty hive-thriftserver module for Hive 2.3.4
wangyum opened a new pull request #24282: [SPARK-27354][SQL] Add a new empty hive-thriftserver module for Hive 2.3.4
URL: https://github.com/apache/spark/pull/24282
## What changes were proposed in this pull request?
When we upgraded the built-in Hive to 2.3.4, the current `hive-thriftserver` module is not compatible, such as these Hive changes:
1. [HIVE-12442](https://issues.apache.org/jira/browse/HIVE-12442) HiveServer2: Refactor/repackage HiveServer2's Thrift code so that it can be used in the tasks
2. [HIVE-12237](https://issues.apache.org/jira/browse/HIVE-12237) Use slf4j as logging facade
3. [HIVE-13169](https://issues.apache.org/jira/browse/HIVE-13169) HiveServer2: Support delegation token based connection when using http transport
So this PR adds a new `hive-thriftserver` module for Hive 2.3.4:
1. Add a new empty module for Hive 2.3.4 named `hive-thriftserverV2`.
2. Make `hive-thriftserver` can only be activated when testing with hadoop-2.7.
3. Make `hive-thriftserverV2` can only be activated when testing with hadoop-3.2.
## How was this patch tested?
manual tests:
```
export HADOOP_PROFILE=hadoop3.2
./dev/run-tests
[info] Checking Scala style using SBT with these profiles: -Phadoop-3.2 -Pkubernetes -Pkinesis-asl -Pyarn -Phive-thriftserverV2 -Pspark-ganglia-lgpl -Phive -Pmesos
export HADOOP_PROFILE=hadoop2.7
./dev/run-tests
[info] Checking Scala style using SBT with these profiles: -Phadoop-2.7 -Pkubernetes -Phive-thriftserver -Pkinesis-asl -Pyarn -Pspark-ganglia-lgpl -Phive -Pmesos
unset HADOOP_PROFILE
./dev/run-tests
[info] Checking Scala style using SBT with these profiles: -Phadoop-2.7 -Pkubernetes -Phive-thriftserver -Pkinesis-asl -Pyarn -Pspark-ganglia-lgpl -Phive -Pmesos
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org