[GitHub] [qpid-proton] astitcher commented on issue #182: PROTON-2040: Alternative suggestion for updating connection options:

[GitBox <gi...@apache.org>]

astitcher commented on issue #182: PROTON-2040: Alternative suggestion for updating connection options:
URL: https://github.com/apache/qpid-proton/pull/182#issuecomment-490086385
 
 
   @alanconway This is basically the same idea as your PR #181 
   
   Implementing this I noticed that there are a couple of issues with this approach:
   * There is no way to replace/change the initial connection url.
      For full control of reconnect we definitely need to be able to control this. maybe we need to treat it as a connection option. So that we can replace it by updating the options.
   * When the initial connection url gets used is a little obscure. Your version and mine actually have different behaviours here which are caused by the slightly different approach to updating the reconnect context. But it is a little unintuitive to me that you get the initial url used again after failing then updating the failover url list.
      If we had a way to change the initial connection url then this might be a moot point.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org