[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #568: [#567] feat: add a shuffle-server metric about read_used_buffer_size

["zuston (via GitHub)" <gi...@apache.org>]

zuston commented on code in PR #568:
URL: https://github.com/apache/incubator-uniffle/pull/568#discussion_r1101039024


##########
server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBufferManager.java:
##########
@@ -362,10 +363,12 @@ public boolean requireReadMemoryWithRetry(long size) {
   public void releaseReadMemory(long size) {
     if (readDataMemory.get() >= size) {
       readDataMemory.addAndGet(-size);
+      ShuffleServerMetrics.gaugeReadBufferUsedSize.dec(size);

Review Comment:
   Yes, it's Ok. The metrics should be always consistent with the value of `readDataMemory.`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org