You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/05/22 04:49:15 UTC

[GitHub] [superset] nytai commented on a change in pull request #14695: feat: make tabs sticky in homepage

nytai commented on a change in pull request #14695:
URL: https://github.com/apache/superset/pull/14695#discussion_r637353901



##########
File path: superset-frontend/src/views/CRUD/welcome/DashboardTable.tsx
##########
@@ -69,6 +73,13 @@ function DashboardTable({
   const [editModal, setEditModal] = useState<Dashboard>();
   const [dashboardFilter, setDashboardFilter] = useState('Mine');
 
+  useEffect(() => {
+    const filter = getFromLocalStorage('dashboard', null);

Review comment:
       👍 on keeping these in a constants file or using an enum. It’ll make it much easier to add a new key without risk of collision with an existing one




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org