You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "shrutisinghania (via GitHub)" <gi...@apache.org> on 2025/06/10 10:50:11 UTC
[I] Add a Default User-Agent for GCS Interactions in pinot-gcs [pinot]
shrutisinghania opened a new issue, #16061:
URL: https://github.com/apache/pinot/issues/16061
### Description
Currently, when Apache Pinot interacts with Google Cloud Storage (GCS) via the pinot-gcs plugin, it does not set a default User-Agent string for its API requests. The User-Agent is only populated if a user explicitly configures the _fs.gcs.application.name_ property in their Pinot configuration.
This means that by default, traffic from a Pinot cluster is not easily distinguishable from other applications using the standard GCS Hadoop Connector.
This proposal suggests a minor enhancement to provide a default User-Agent for all GCS requests, improving the observability of Pinot in a Google Cloud environment.
### Proposed Solution
The solution is to programmatically set a default application name if one is not already provided by the user. This change would be implemented in the init() method of the GcsPinotFS class within the pinot-gcs module.
The logic would be as follows:
1. In the init() method, inspect the incoming PinotConfiguration object.
2. Check if the key fs.gcs.application.name already exists.
3. If the key does not exist, set a default value, for example: config.setProperty("fs.gcs.application.name", "apache-pinot-client").
4. Proceed with the GCS client initialization using the (now guaranteed to be populated) configuration.
This ensures that all GCS requests will be tagged, either with the user's custom name or the Pinot default.
**I believe this is a valuable, non-intrusive enhancement for the project. I would be happy to contribute a pull request to implement this change for community review.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] PEP-Request: Add a Default User-Agent for GCS Interactions in pinot-gcs [pinot]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #16061:
URL: https://github.com/apache/pinot/issues/16061#issuecomment-4113207748
This issue has been automatically marked as stale because it has not had any activity in the last 150 days. It will be closed in 30 days if no further activity occurs. If this issue is still relevant, please leave a comment to keep it open. Thank you for your contributions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] PEP-Request: Add a Default User-Agent for GCS Interactions in pinot-gcs [pinot]
Posted by "shrutisinghania (via GitHub)" <gi...@apache.org>.
shrutisinghania closed issue #16061: PEP-Request: Add a Default User-Agent for GCS Interactions in pinot-gcs
URL: https://github.com/apache/pinot/issues/16061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org