You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/06/21 03:21:13 UTC
[GitHub] [superset] novemberde opened a new pull request, #20446: doc(featureflags): add GENERIC_CHART_AXES flag
novemberde opened a new pull request, #20446:
URL: https://github.com/apache/superset/pull/20446
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
I found that GENERIC_CHART_AXES flag exists via superset config file, but GENERIC_CHART_AXES is not described in the document.(This feature was applied via https://github.com/apache/superset/pull/17917)
This would be helpful for the superset user reading only documents.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] srinify merged pull request #20446: docs(featureflags): add GENERIC_CHART_AXES flag
Posted by GitBox <gi...@apache.org>.
srinify merged PR #20446:
URL: https://github.com/apache/superset/pull/20446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #20446: docs(featureflags): add GENERIC_CHART_AXES flag
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on PR #20446:
URL: https://github.com/apache/superset/pull/20446#issuecomment-1161290016
@novemberde I think that the feature should still need polishing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ commented on pull request #20446: doc(featureflags): add GENERIC_CHART_AXES flag
Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on PR #20446:
URL: https://github.com/apache/superset/pull/20446#issuecomment-1161199338
Thanks for the suggestion! I think the only point we might need to check is whether to put it into `stable` or `in testing`. cc @rusackas @villebro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] srinify commented on pull request #20446: docs(featureflags): add GENERIC_CHART_AXES flag
Posted by GitBox <gi...@apache.org>.
srinify commented on PR #20446:
URL: https://github.com/apache/superset/pull/20446#issuecomment-1163082530
Thanks for the contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] novemberde commented on pull request #20446: docs(featureflags): add GENERIC_CHART_AXES flag
Posted by GitBox <gi...@apache.org>.
novemberde commented on PR #20446:
URL: https://github.com/apache/superset/pull/20446#issuecomment-1161323665
@zhaoyongjie Thank you for your review.
I've moved GENERIC_CHART_AXES feature to "in testing" block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org