You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "mihailoale-db (via GitHub)" <gi...@apache.org> on 2025/12/11 10:57:52 UTC
[PR] [SPARK-54668] [SQL] [TEST-ONLY] Add tests for CTEs in multi-children operators [spark]
mihailoale-db opened a new pull request, #53442:
URL: https://github.com/apache/spark/pull/53442
### What changes were proposed in this pull request?
We miss some golden files for CTEs in multi-children operators. In this issue I propose to add it.
### Why are the changes needed?
To improve the coverage for the explained case.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Testing change.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54668] [SQL] [TEST-ONLY] Add tests for CTEs in multi-children operators [spark]
Posted by "dtenedor (via GitHub)" <gi...@apache.org>.
dtenedor commented on PR #53442:
URL: https://github.com/apache/spark/pull/53442#issuecomment-3644347210
Thanks for working on this, merging to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54668] [SQL] [TEST-ONLY] Add tests for CTEs in multi-children operators [spark]
Posted by "mihailoale-db (via GitHub)" <gi...@apache.org>.
mihailoale-db commented on PR #53442:
URL: https://github.com/apache/spark/pull/53442#issuecomment-3643602954
@dtenedor it passed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54668] [SQL] [TEST-ONLY] Add tests for CTEs in multi-children operators [spark]
Posted by "dtenedor (via GitHub)" <gi...@apache.org>.
dtenedor commented on PR #53442:
URL: https://github.com/apache/spark/pull/53442#issuecomment-3643420362
It looks like the "[Run / Build modules: sql - extended tests](https://github.com/mihailoale-db/spark/actions/runs/20130731081/job/57815527748)" CI job is still running, let's wait for it to finish.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54668] [SQL] [TEST-ONLY] Add tests for CTEs in multi-children operators [spark]
Posted by "dtenedor (via GitHub)" <gi...@apache.org>.
dtenedor closed pull request #53442: [SPARK-54668] [SQL] [TEST-ONLY] Add tests for CTEs in multi-children operators
URL: https://github.com/apache/spark/pull/53442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org