You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "TeodorDjelic (via GitHub)" <gi...@apache.org> on 2025/08/20 20:56:32 UTC
[PR] Expand golden test coverage on multivariable DECLARE [spark]
TeodorDjelic opened a new pull request, #52086:
URL: https://github.com/apache/spark/pull/52086
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Added missing tests from the sql golden file test for the multivariable DECLARE.
Missing variants were:
- DECLARE with type and default
- DECLARE with just default
- DECLARE OR REPLACE with type and default
- DECLARE OR REPLACE with just default
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To improve the code coverage of golden files.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
This patch includes only the golden file tests themselves.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53341][Core] Expand golden test coverage on multivariable DECLARE [spark]
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #52086:
URL: https://github.com/apache/spark/pull/52086#discussion_r2293732188
##########
sql/core/src/test/resources/sql-tests/analyzer-results/sql-session-variables.sql.out:
##########
@@ -1284,6 +1246,139 @@ DropVariable false
+- ResolvedIdentifier org.apache.spark.sql.catalyst.analysis.FakeSystemCatalog$@xxxxxxxx, session.var3
+-- !query
+SET VARIABLE title = 'DECLARE VARIABLE - multiple variables declared at once'
+-- !query analysis
+SetVariable [variablereference(system.session.title='SET VARIABLE - comma separated target')]
++- Project [DECLARE VARIABLE - multiple variables declared at once AS title#x]
+ +- OneRowRelation
+
+
+-- !query
+DECLARE VARIABLE var1, var2, var3 INT
+-- !query analysis
+CreateVariable defaultvalueexpression(null, null), false
+:- ResolvedIdentifier org.apache.spark.sql.catalyst.analysis.FakeSystemCatalog$@xxxxxxxx, session.var1
+:- ResolvedIdentifier org.apache.spark.sql.catalyst.analysis.FakeSystemCatalog$@xxxxxxxx, session.var2
++- ResolvedIdentifier org.apache.spark.sql.catalyst.analysis.FakeSystemCatalog$@xxxxxxxx, session.var3
+
+
+-- !query
+DECLARE VARIABLE var4, var5, var6 INT DEFAULT 5
Review Comment:
What happens when the default in non-deterministic e.g. RAND()?
They should all share the same value. We should test that.
The way to test will be to test for equality after the creating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53341][Core] Expand golden test coverage on multivariable DECLARE [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #52086: [SPARK-53341][Core] Expand golden test coverage on multivariable DECLARE
URL: https://github.com/apache/spark/pull/52086
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53341][Core] Expand golden test coverage on multivariable DECLARE [spark]
Posted by "davidm-db (via GitHub)" <gi...@apache.org>.
davidm-db commented on PR #52086:
URL: https://github.com/apache/spark/pull/52086#issuecomment-3213477611
cc @cloud-fan @srielau to review as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53341][Core] Expand golden test coverage on multivariable DECLARE [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #52086:
URL: https://github.com/apache/spark/pull/52086#issuecomment-3235581282
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53341][Core] Expand golden test coverage on multivariable DECLARE [spark]
Posted by "davidm-db (via GitHub)" <gi...@apache.org>.
davidm-db commented on PR #52086:
URL: https://github.com/apache/spark/pull/52086#issuecomment-3233876504
cc @cloud-fan to merge this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53341][Core] Expand golden test coverage on multivariable DECLARE [spark]
Posted by "miland-db (via GitHub)" <gi...@apache.org>.
miland-db commented on code in PR #52086:
URL: https://github.com/apache/spark/pull/52086#discussion_r2290273275
##########
sql/core/src/test/resources/sql-tests/inputs/sql-session-variables.sql:
##########
@@ -215,8 +207,29 @@ DROP TEMPORARY VARIABLE var1;
DROP TEMPORARY VARIABLE var2;
DROP TEMPORARY VARIABLE var3;
-DECLARE VARIABLE var1, var2, vAr1 INT;
+SET VARIABLE title = 'DECLARE VARIABLE - multiple variables defined at once';
Review Comment:
nit: multiple variables `declared` at one
##########
sql/core/src/test/resources/sql-tests/inputs/sql-session-variables.sql:
##########
@@ -215,8 +207,29 @@ DROP TEMPORARY VARIABLE var1;
DROP TEMPORARY VARIABLE var2;
DROP TEMPORARY VARIABLE var3;
-DECLARE VARIABLE var1, var2, vAr1 INT;
+SET VARIABLE title = 'DECLARE VARIABLE - multiple variables defined at once';
Review Comment:
nit: multiple variables `declared` at once
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org