You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/04/01 08:27:35 UTC
[GitHub] [cloudstack] Spaceman1984 opened a new pull request #4005: Fixed
create template from snapshot never returning
Spaceman1984 opened a new pull request #4005: Fixed create template from snapshot never returning
URL: https://github.com/apache/cloudstack/pull/4005
## Description
<!--- Describe your changes in detail -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
When creating a snapshot from a template, the notification is not updated after the task is completed.
This PR fixes the issue.
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
Fixes: #3711
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
This has been tested by creating a template from a volume snapshot from the UI
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #4005: Fixed create
template from snapshot never returning
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #4005: Fixed create template from snapshot never returning
URL: https://github.com/apache/cloudstack/pull/4005#issuecomment-607113856
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #4005: Fixed create
template from snapshot never returning
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #4005: Fixed create template from snapshot never returning
URL: https://github.com/apache/cloudstack/pull/4005#issuecomment-607122973
Packaging result: ✔centos7 ✔debian. JID-1112
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #4005: Fixed create
template from snapshot never returning
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #4005: Fixed create template from snapshot never returning
URL: https://github.com/apache/cloudstack/pull/4005#issuecomment-607113490
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #4005: Fixed create
template from snapshot never returning
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #4005: Fixed create template from snapshot never returning
URL: https://github.com/apache/cloudstack/pull/4005#issuecomment-607314476
A very simple change, tested x2, not need for regression automated tests as it's a simple JS change
merging based on ^^^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #4005: Fixed create
template from snapshot never returning
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #4005: Fixed create template from snapshot never returning
URL: https://github.com/apache/cloudstack/pull/4005#issuecomment-607312540
LGTM
manually tested on multiple snaps--> templates - GUI shows job completed properly as soon as it's finished.
good work, thx @Spaceman1984
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb merged pull request #4005: Fixed create
template from snapshot never returning
Posted by GitBox <gi...@apache.org>.
andrijapanicsb merged pull request #4005: Fixed create template from snapshot never returning
URL: https://github.com/apache/cloudstack/pull/4005
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services