You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by fa...@apache.org on 2020/02/18 03:55:42 UTC

[dubbo-go] branch develop updated: Fix: do not release conn when can not get response

This is an automated email from the ASF dual-hosted git repository.

fangyc pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/dubbo-go.git


The following commit(s) were added to refs/heads/develop by this push:
     new d71ca0b  Fix: do not release conn when can not get response
     new 26238d4  Merge pull request #361 from divebomb/develop
d71ca0b is described below

commit d71ca0b30744903bba001ea5297d78956e3a2616
Author: AlexStocks <al...@foxmail.com>
AuthorDate: Sun Feb 16 23:52:13 2020 +0800

    Fix: do not release conn when can not get response
---
 protocol/dubbo/client.go | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/protocol/dubbo/client.go b/protocol/dubbo/client.go
index 3923b7e..0765a33 100644
--- a/protocol/dubbo/client.go
+++ b/protocol/dubbo/client.go
@@ -24,9 +24,9 @@ import (
 )
 
 import (
-	"github.com/apache/dubbo-go-hessian2"
+	hessian "github.com/apache/dubbo-go-hessian2"
 	"github.com/dubbogo/getty"
-	"github.com/dubbogo/gost/sync"
+	gxsync "github.com/dubbogo/gost/sync"
 	perrors "github.com/pkg/errors"
 	"go.uber.org/atomic"
 	"gopkg.in/yaml.v2"
@@ -274,8 +274,8 @@ func (c *Client) call(ct CallType, request *Request, response *Response, callbac
 
 	select {
 	case <-getty.GetTimeWheel().After(c.opts.RequestTimeout):
-		err = errClientReadTimeout
 		c.removePendingResponse(SequenceType(rsp.seq))
+		return perrors.WithStack(errClientReadTimeout)
 	case <-rsp.done:
 		err = rsp.err
 	}