You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2022/09/19 11:54:18 UTC

[GitHub] [sling-org-apache-sling-distribution-core] ManasMaji commented on a diff in pull request #66: SLING-11560 : Vault error when importing a node with the same name and UUID as a pre-existing non-sibling node

ManasMaji commented on code in PR #66:
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/66#discussion_r974162347


##########
src/main/java/org/apache/sling/distribution/serialization/impl/vlt/FileVaultContentSerializer.java:
##########
@@ -131,7 +133,7 @@ public void importFromStream(ResourceResolver resourceResolver, InputStream inpu
         Archive archive = null;
         try {
             session = getSession(resourceResolver);
-            ImportOptions importOptions = VltUtils.getImportOptions(aclHandling, cugHandling, importMode, autosaveThreshold, strict);
+            ImportOptions importOptions = VltUtils.getImportOptions(aclHandling, cugHandling, importMode, autosaveThreshold, strict, idConflictPolicy);
             ErrorListener errorListener = new ErrorListener();
             importOptions.setListener(errorListener);
             Importer importer = new Importer(importOptions);

Review Comment:
   @kwin We already have a property for strict mode - [here](https://github.com/apache/sling-org-apache-sling-distribution-core/blob/501c4e8824458454e676e8c62a7398b68f309a98/src/main/java/org/apache/sling/distribution/serialization/impl/vlt/VaultDistributionPackageBuilderFactory.java#L168).
   
   I wasn't sure if we needed `overwritePrimaryTypesOfFoldersByDefault`, please let me know if we should include that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org