You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/07/13 14:54:08 UTC
[GitHub] wohali commented on a change in pull request #1435: report git sha
on welcome request
wohali commented on a change in pull request #1435: report git sha on welcome request
URL: https://github.com/apache/couchdb/pull/1435#discussion_r202375981
##########
File path: src/couch/rebar.config.script
##########
@@ -39,6 +39,13 @@ Version = case os:getenv("COUCHDB_VERSION") of
string:strip(Version0, right)
end,
+VersionSuffix = case os:getenv("COUCHDB_VERSION_SUFFIX") of
Review comment:
I don't think this will t work when building from a release tarball, when we're not inside of git. Test case should be:
```
./configure -c
make dist
cd apache-couchdb-*
./configure -c
make couch
```
which I expect to fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services