You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hugegraph.apache.org by "chengxin1374 (via GitHub)" <gi...@apache.org> on 2023/07/11 13:52:51 UTC
[GitHub] [incubator-hugegraph-commons] chengxin1374 opened a new pull request, #132: add some construction methods for more convenient use
chengxin1374 opened a new pull request, #132:
URL: https://github.com/apache/incubator-hugegraph-commons/pull/132
add some construction methods for more convenient use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-commons] VGalaxies commented on pull request #132: add some construction methods for more convenient use
Posted by "VGalaxies (via GitHub)" <gi...@apache.org>.
VGalaxies commented on PR #132:
URL: https://github.com/apache/incubator-hugegraph-commons/pull/132#issuecomment-1631791996
> thanks，maybe change the merge branch to master？
>
> @VGalaxies all need meet？
All the required ctors are now in place 🎈
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-commons] codecov[bot] commented on pull request #132: add some construction methods for more convenient use
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #132:
URL: https://github.com/apache/incubator-hugegraph-commons/pull/132#issuecomment-1631811754
## [Codecov](https://app.codecov.io/gh/apache/incubator-hugegraph-commons/pull/132?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#132](https://app.codecov.io/gh/apache/incubator-hugegraph-commons/pull/132?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9fa7fd3) into [master](https://app.codecov.io/gh/apache/incubator-hugegraph-commons/commit/297e49123298da7c17aecd5db826f4ff8d8a5fe5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (297e491) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #132 +/- ##
=========================================
Coverage 93.15% 93.15%
Complexity 65 65
=========================================
Files 9 9
Lines 263 263
Branches 22 22
=========================================
Hits 245 245
Misses 8 8
Partials 10 10
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-commons] imbajin commented on pull request #132: add some construction methods for more convenient use
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on PR #132:
URL: https://github.com/apache/incubator-hugegraph-commons/pull/132#issuecomment-1630921731
thanks，maybe change the merge branch to master？
@VGalaxies all need meet？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-commons] javeme commented on a diff in pull request #132: refact(common): add more construction methods for convenient
Posted by "javeme (via GitHub)" <gi...@apache.org>.
javeme commented on code in PR #132:
URL: https://github.com/apache/incubator-hugegraph-commons/pull/132#discussion_r1261149583
##########
hugegraph-common/src/main/java/org/apache/hugegraph/event/EventHub.java:
##########
@@ -49,21 +49,27 @@ public class EventHub {
// Event executor
private static ExecutorService executor = null;
- private String name;
- private Map<String, List<EventListener>> listeners;
+ private final String name;
+ private final Map<String, List<EventListener>> listeners;
public EventHub() {
this("hub");
}
public EventHub(String name) {
LOG.debug("Create new EventHub: {}", name);
-
this.name = name;
this.listeners = new ConcurrentHashMap<>();
EventHub.init(1);
}
+ public EventHub(String name, int threadSize) {
Review Comment:
just let `EventHub(String name)` call `EventHub(name, 1)`
##########
hugegraph-common/src/main/java/org/apache/hugegraph/rest/RestResult.java:
##########
@@ -43,6 +43,12 @@ public RestResult(Response response) {
this.content = response.readEntity(String.class);
}
+ public RestResult(int status, String content, MultivaluedMap<String, Object> headers) {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-commons] javeme merged pull request #132: refact(common): add more construction methods for convenient
Posted by "javeme (via GitHub)" <gi...@apache.org>.
javeme merged PR #132:
URL: https://github.com/apache/incubator-hugegraph-commons/pull/132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org