[jira] [Commented] (STORM-2797) LogViewer worker logs broken on Windows

["Lawrence Craft (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238619#comment-16238619 ] 

Lawrence Craft commented on STORM-2797:
---------------------------------------

I'm planning on fixing this by wrapping the few places the path separator is used as a regex in a function that'll sanitize it first. 

I had a look at the Java version in master and it doesn't seem to be affected, but I haven't had a chance to test it yet. 

> LogViewer worker logs broken on Windows
> ---------------------------------------
>
>                 Key: STORM-2797
>                 URL: https://issues.apache.org/jira/browse/STORM-2797
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-webapp
>    Affects Versions: 1.x
>         Environment: Windows
>            Reporter: Lawrence Craft
>            Priority: Minor
>         Attachments: logviewer.log
>
>
> LogViewer worker logs are broken on Windows. Attempting to access the log (e.g. http://localhost:8000/log?file=word-topo-5-1509750559%5C6701%5Cworker.log) leads to a 500 Server Error.
> I've attached the LogViewer logs which show the stack trace. The issue is pretty clear from the log: on line 123 of logviewer.clj, the path is split using the path separator as a regex. This is fine on Posix systems as / is a normal character in regex; however, on Windows, backslash is the path separator. As this is also the regex escape character, it is not a valid regular expression.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)