[jira] [Commented] (HBASE-5281) Should a failure in creating an unassigned node abort the master?

["Hadoop QA (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-5281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196039#comment-13196039 ] 

Hadoop QA commented on HBASE-5281:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12512395/HBASE-5281.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated -140 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 161 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.master.TestSplitLogManager
                  org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
                  org.apache.hadoop.hbase.mapred.TestTableMapReduce
                  org.apache.hadoop.hbase.mapreduce.TestImportTsv

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/869//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/869//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/869//console

This message is automatically generated.
                
> Should a failure in creating an unassigned node abort the master?
> -----------------------------------------------------------------
>
>                 Key: HBASE-5281
>                 URL: https://issues.apache.org/jira/browse/HBASE-5281
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 0.90.5
>            Reporter: Harsh J
>            Assignee: Harsh J
>             Fix For: 0.94.0, 0.92.1
>
>         Attachments: HBASE-5281.patch
>
>
> In {{AssignmentManager}}'s {{CreateUnassignedAsyncCallback}}, we have the following condition:
> {code}
> if (rc != 0) {
>         // Thisis resultcode.  If non-zero, need to resubmit.
>         LOG.warn("rc != 0 for " + path + " -- retryable connectionloss -- " +
>           "FIX see http://wiki.apache.org/hadoop/ZooKeeper/FAQ#A2");
>         this.zkw.abort("Connectionloss writing unassigned at " + path +
>           ", rc=" + rc, null);
>         return;
> }
> {code}
> While a similar structure inside {{ExistsUnassignedAsyncCallback}} (which the above is linked to), does not have such a force abort.
> Do we really require the abort statement here, or can we make do without?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira